* [PATCH V3 1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect
@ 2024-06-01 13:52 Adam Ford
2024-06-01 13:52 ` [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS Adam Ford
2024-06-01 17:41 ` [PATCH V3 1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect Fabio Estevam
0 siblings, 2 replies; 5+ messages in thread
From: Adam Ford @ 2024-06-01 13:52 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Laurent Pinchart, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-kernel
The DSI to HDMI bridge supports hot-plug-detect.The driver
supports shared GPIO IRQ pins, so it's save to enable them
which allows for hot-plug detect.
Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
V3: Update commit message, no functional changes.
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
index e5d3901f2913..da836172ae46 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
@@ -304,6 +304,8 @@ adv_bridge: hdmi@3d {
compatible = "adi,adv7535";
reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
reg-names = "main", "cec", "edid", "packet";
+ interrupt-parent = <&gpio4>;
+ interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
adi,dsi-lanes = <4>;
#sound-dai-cells = <0>;
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS
2024-06-01 13:52 [PATCH V3 1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect Adam Ford
@ 2024-06-01 13:52 ` Adam Ford
2024-06-01 17:43 ` Fabio Estevam
2024-06-01 17:41 ` [PATCH V3 1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect Fabio Estevam
1 sibling, 1 reply; 5+ messages in thread
From: Adam Ford @ 2024-06-01 13:52 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
devicetree, imx, linux-kernel
The adv7535 has some unnecessary entries which can be removed since
they were not setup properly anyway and the defaults work just fine.
Removing them and adding some required regulators make the errors
detected from CHECK_DTBS go away:
reg-names:1: 'edid' was expected
reg-names:2: 'cec' was expected
'avdd-supply' is a required property
'dvdd-supply' is a required property
'pvdd-supply' is a required property
'a2vdd-supply' is a required property
'v3p3-supply' is a required property
Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2: No Change
V3: Update commit message, no functional changes.
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
index da836172ae46..5c4b68c18bb2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
@@ -302,12 +302,19 @@ pca6416_3: gpio@20 {
adv_bridge: hdmi@3d {
compatible = "adi,adv7535";
- reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
- reg-names = "main", "cec", "edid", "packet";
+ reg = <0x3d>;
+ reg-names = "main";
interrupt-parent = <&gpio4>;
interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
adi,dsi-lanes = <4>;
#sound-dai-cells = <0>;
+ avdd-supply = <&buck5>;
+ dvdd-supply = <&buck5>;
+ pvdd-supply = <&buck5>;
+ a2vdd-supply = <&buck5>;
+ v1p2-supply = <&buck5>;
+ v3p3-supply = <&buck4>;
+
ports {
#address-cells = <1>;
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS
2024-06-01 13:52 ` [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS Adam Ford
@ 2024-06-01 17:43 ` Fabio Estevam
2024-06-16 7:01 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2024-06-01 17:43 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
devicetree, imx, linux-kernel
On Sat, Jun 1, 2024 at 10:52 AM Adam Ford <aford173@gmail.com> wrote:
> adv_bridge: hdmi@3d {
> compatible = "adi,adv7535";
> - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
> - reg-names = "main", "cec", "edid", "packet";
> + reg = <0x3d>;
> + reg-names = "main";
> interrupt-parent = <&gpio4>;
> interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
> adi,dsi-lanes = <4>;
> #sound-dai-cells = <0>;
> + avdd-supply = <&buck5>;
> + dvdd-supply = <&buck5>;
> + pvdd-supply = <&buck5>;
> + a2vdd-supply = <&buck5>;
> + v1p2-supply = <&buck5>;
> + v3p3-supply = <&buck4>;
> +
The extra blank line is not needed.
Thanks for fixing the dt-schema warnings:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS
2024-06-01 17:43 ` Fabio Estevam
@ 2024-06-16 7:01 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2024-06-16 7:01 UTC (permalink / raw)
To: Fabio Estevam
Cc: Adam Ford, linux-arm-kernel, aford, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, devicetree, imx, linux-kernel
On Sat, Jun 01, 2024 at 02:43:07PM -0300, Fabio Estevam wrote:
> On Sat, Jun 1, 2024 at 10:52 AM Adam Ford <aford173@gmail.com> wrote:
>
> > adv_bridge: hdmi@3d {
> > compatible = "adi,adv7535";
> > - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
> > - reg-names = "main", "cec", "edid", "packet";
> > + reg = <0x3d>;
> > + reg-names = "main";
> > interrupt-parent = <&gpio4>;
> > interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
> > adi,dsi-lanes = <4>;
> > #sound-dai-cells = <0>;
> > + avdd-supply = <&buck5>;
> > + dvdd-supply = <&buck5>;
> > + pvdd-supply = <&buck5>;
> > + a2vdd-supply = <&buck5>;
> > + v1p2-supply = <&buck5>;
> > + v3p3-supply = <&buck4>;
> > +
>
> The extra blank line is not needed.
Fixed it up and applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V3 1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect
2024-06-01 13:52 [PATCH V3 1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect Adam Ford
2024-06-01 13:52 ` [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS Adam Ford
@ 2024-06-01 17:41 ` Fabio Estevam
1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2024-06-01 17:41 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Laurent Pinchart, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, devicetree, imx, linux-kernel
Hi Adam,
On Sat, Jun 1, 2024 at 10:52 AM Adam Ford <aford173@gmail.com> wrote:
>
> The DSI to HDMI bridge supports hot-plug-detect.The driver
> supports shared GPIO IRQ pins, so it's save to enable them
> which allows for hot-plug detect.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-16 7:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-01 13:52 [PATCH V3 1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect Adam Ford
2024-06-01 13:52 ` [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS Adam Ford
2024-06-01 17:43 ` Fabio Estevam
2024-06-16 7:01 ` Shawn Guo
2024-06-01 17:41 ` [PATCH V3 1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).