* [PATCH 3/3] ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification
@ 2016-01-27 20:24 Russell King
[not found] ` <E1aOWdF-00058a-0X-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2016-01-27 20:24 UTC (permalink / raw)
To: Sascha Hauer, Shawn Guo
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
PCIe reset signals are active low, and our GPIO for this is directly
connected to the PCIe reset. However, as the PCIe driver does not use
the flag, the specification of '0' flags (which means active high) has
not been noticed. Correct this oversight, and switch to using the
GPIO flag definitions instead.
Signed-off-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
---
arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
index 3a06516fe7a9..258107246d64 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
@@ -253,7 +253,7 @@
&pcie {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_hummingboard_pcie_reset>;
- reset-gpio = <&gpio3 4 0>;
+ reset-gpio = <&gpio3 4 GPIO_ACTIVE_LOW>;
status = "okay";
};
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <E1aOWdF-00058a-0X-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>]
* Re: [PATCH 3/3] ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification [not found] ` <E1aOWdF-00058a-0X-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org> @ 2016-01-27 21:07 ` Fabio Estevam [not found] ` <CAOMZO5Ciq-kq4xQm4TH+dF3cdYxFfWUmvuykvorZ-oaEoyBWFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Fabio Estevam @ 2016-01-27 21:07 UTC (permalink / raw) To: Russell King Cc: Sascha Hauer, Shawn Guo, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll, Ian Campbell, Rob Herring, Kumar Gala, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On Wed, Jan 27, 2016 at 6:24 PM, Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> wrote: > PCIe reset signals are active low, and our GPIO for this is directly > connected to the PCIe reset. However, as the PCIe driver does not use > the flag, the specification of '0' flags (which means active high) has > not been noticed. Correct this oversight, and switch to using the Yes, the mx6 pci driver did not use the flag, but it does now since 5c5fb40de8f1 ("PCI: imx6: Add support for active-low reset GPIO"), so it would be better to adjust the commit log. Apart from that, patch looks good. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CAOMZO5Ciq-kq4xQm4TH+dF3cdYxFfWUmvuykvorZ-oaEoyBWFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 3/3] ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification [not found] ` <CAOMZO5Ciq-kq4xQm4TH+dF3cdYxFfWUmvuykvorZ-oaEoyBWFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-02-02 7:34 ` Shawn Guo 0 siblings, 0 replies; 3+ messages in thread From: Shawn Guo @ 2016-02-02 7:34 UTC (permalink / raw) To: Fabio Estevam Cc: Russell King, Sascha Hauer, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll, Ian Campbell, Rob Herring, Kumar Gala, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On Wed, Jan 27, 2016 at 07:07:38PM -0200, Fabio Estevam wrote: > On Wed, Jan 27, 2016 at 6:24 PM, Russell King > <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> wrote: > > PCIe reset signals are active low, and our GPIO for this is directly > > connected to the PCIe reset. However, as the PCIe driver does not use > > the flag, the specification of '0' flags (which means active high) has > > not been noticed. Correct this oversight, and switch to using the > > Yes, the mx6 pci driver did not use the flag, but it does now since 5c5fb40de8f1 > ("PCI: imx6: Add support for active-low reset GPIO"), so it would be > better to adjust the commit log. I updated the commit log a bit and applied the series. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-02 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27 20:24 [PATCH 3/3] ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification Russell King
[not found] ` <E1aOWdF-00058a-0X-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2016-01-27 21:07 ` Fabio Estevam
[not found] ` <CAOMZO5Ciq-kq4xQm4TH+dF3cdYxFfWUmvuykvorZ-oaEoyBWFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-02 7:34 ` Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).