From: Fabio Estevam <festevam@gmail.com>
To: Peter Chen <peter.chen@nxp.com>
Cc: USB list <linux-usb@vger.kernel.org>,
Schrempf Frieder <frieder.schrempf@exceet.de>,
NXP Linux Team <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
Date: Tue, 16 Oct 2018 13:24:40 -0300 [thread overview]
Message-ID: <CAOMZO5Cts2=Y10P0bAXDRTnQ7trgzwb2EBpxjcV7GBY7HwXKCA@mail.gmail.com> (raw)
In-Reply-To: <20181016045846.2345-5-peter.chen@nxp.com>
Hi Peter,
On Tue, Oct 16, 2018 at 2:02 AM Peter Chen <peter.chen@nxp.com> wrote:
>
> For USB HSIC, the data and strobe pin needs to be pulled down
> at default, we consider it as "idle" state. When the USB host
> is ready to be used, the strobe pin needs to be pulled up,
> we consider it as "active" state.
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> index 529e51879fb2..10c8d793ea49 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> @@ -81,6 +81,7 @@ Optional properties:
> mux state of 1 indicates host mode.
> - mux-control-names: Shall be "usb_switch" if mux-controls is specified.
> - pinctrl-names: Names for optional pin modes in "default", "host", "device"
> + Or names for HSIC "idle" and "active" pin modes.
I don't think this description is clear enough.
Could you please add a real dts snippet for the HSIC case instead?
next prev parent reply other threads:[~2018-10-16 16:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 5:01 [PATCH 0/4] usb: chipidea: imx: add HSIC support Peter Chen
2018-10-16 5:01 ` [PATCH 1/4] usb: chipidea: add flag for imx hsic implementation Peter Chen
2018-10-16 5:01 ` [PATCH 2/4] usb: chipidea: imx: add HSIC support Peter Chen
2018-10-16 5:52 ` kbuild test robot
2018-10-16 6:07 ` Peter Chen
2018-10-17 7:03 ` Frieder Schrempf
2018-10-18 1:18 ` Peter Chen
2018-10-16 5:01 ` [PATCH 3/4] usb: chipidea: host: override ehci->hub_control Peter Chen
2018-10-16 5:01 ` [PATCH 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups Peter Chen
2018-10-16 16:24 ` Fabio Estevam [this message]
2018-10-17 1:04 ` Peter Chen
2018-10-17 7:02 ` [PATCH 0/4] usb: chipidea: imx: add HSIC support Frieder Schrempf
2018-10-17 7:23 ` Peter Chen
2018-10-17 9:56 ` Frieder Schrempf
2018-10-17 11:04 ` Frieder Schrempf
2018-10-17 14:59 ` Frieder Schrempf
2018-10-18 1:22 ` Peter Chen
2018-10-18 7:46 ` Frieder Schrempf
2018-10-18 8:48 ` Peter Chen
2018-10-18 8:56 ` Frieder Schrempf
2018-10-18 9:04 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5Cts2=Y10P0bAXDRTnQ7trgzwb2EBpxjcV7GBY7HwXKCA@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frieder.schrempf@exceet.de \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).