From: Fabio Estevam <festevam@gmail.com>
To: Chester Lin <clin@suse.com>
Cc: "Dong Aisheng" <aisheng.dong@nxp.com>,
"Shawn Guo" <shawnguo@kernel.org>, "Jacky Bai" <ping.bai@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
s32@nxp.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Larisa Grigore" <larisa.grigore@nxp.com>,
"Ghennadi Procopciuc" <Ghennadi.Procopciuc@nxp.com>,
"Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
"Radu Pirea" <radu-nicolae.pirea@nxp.com>,
"Andreas Färber" <afaerber@suse.de>,
"Matthias Brugger" <mbrugger@suse.com>,
"Matthew Nunez" <matthew.nunez@nxp.com>,
"Phu Luu An" <phu.luuan@nxp.com>,
"Stefan-Gabriel Mirea" <stefan-gabriel.mirea@nxp.com>
Subject: Re: [PATCH v2 2/2] pinctrl: add NXP S32 SoC family support
Date: Wed, 7 Dec 2022 20:04:18 -0300 [thread overview]
Message-ID: <CAOMZO5D0wJcfbFsvUN3K17S5F4zT2Yf8yQB+wMKQPzuMBitrpA@mail.gmail.com> (raw)
In-Reply-To: <20221128054820.1771-3-clin@suse.com>
Hi Chester,
On Mon, Nov 28, 2022 at 2:49 AM Chester Lin <clin@suse.com> wrote:
> +static struct platform_driver s32g_pinctrl_driver = {
> + .driver = {
> + .name = "s32g-siul2-pinctrl",
> + .owner = THIS_MODULE,
> + .of_match_table = s32_pinctrl_of_match,
> + .pm = &s32g_pinctrl_pm_ops,
> + },
> + .probe = s32g_pinctrl_probe,
> + .remove = s32_pinctrl_remove,
Do you really want to allow this pinctrl driver to be removed?
In other imx8m pinctrl drivers we pass:
.suppress_bind_attrs = true,
Check drivers/pinctrl/freescale/pinctrl-imx8mm.c for example.
> +module_platform_driver(s32g_pinctrl_driver);
And we also register it in arch_initcall() level.
Maybe you want to align these points with imx8m?
next prev parent reply other threads:[~2022-12-07 23:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 5:48 [PATCH v2 0/2] Add pinctrl support for S32 SoC family Chester Lin
2022-11-28 5:48 ` [PATCH v2 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs Chester Lin
2022-11-29 14:00 ` Andreas Färber
2022-11-29 14:52 ` Chester Lin
2022-11-30 14:58 ` Krzysztof Kozlowski
2022-12-05 6:16 ` Chester Lin
2022-12-05 9:02 ` Krzysztof Kozlowski
2022-12-05 11:05 ` Chester Lin
2022-12-05 13:26 ` Krzysztof Kozlowski
2022-11-28 5:48 ` [PATCH v2 2/2] pinctrl: add NXP S32 SoC family support Chester Lin
2022-11-29 13:40 ` Andreas Färber
2022-12-05 7:06 ` Chester Lin
2022-12-07 22:52 ` Linus Walleij
2022-12-07 23:04 ` Fabio Estevam [this message]
2022-12-08 21:37 ` Linus Walleij
2022-12-09 4:38 ` Chester Lin
2022-12-09 11:27 ` Linus Walleij
2022-12-14 23:08 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5D0wJcfbFsvUN3K17S5F4zT2Yf8yQB+wMKQPzuMBitrpA@mail.gmail.com \
--to=festevam@gmail.com \
--cc=Ghennadi.Procopciuc@nxp.com \
--cc=afaerber@suse.de \
--cc=aisheng.dong@nxp.com \
--cc=andrei.stefanescu@nxp.com \
--cc=clin@suse.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=larisa.grigore@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.nunez@nxp.com \
--cc=mbrugger@suse.com \
--cc=phu.luuan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=radu-nicolae.pirea@nxp.com \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
--cc=stefan-gabriel.mirea@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).