devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Martyn Welch <martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Cc: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	nux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Fabien Lahoudere
	<fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
	Sebastian Reichel
	<sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Subject: Re: [PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD
Date: Wed, 12 Jul 2017 09:32:44 -0300	[thread overview]
Message-ID: <CAOMZO5D6xw4hVCOWfM0+++PQ87xBwihGSCJZsW8qBdn==vrLvA@mail.gmail.com> (raw)
In-Reply-To: <cffaa6f22474ff2ba4ca46d4252d35fc75cb0dd7.1499779628.git.martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

On Tue, Jul 11, 2017 at 10:42 AM, Martyn Welch
<martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> wrote:

> Changes since PATCHv3: https://patchwork.kernel.org/patch/9819017/
>  - licensing modified
>  - manufacturer changed to GE
>  - regulator nodes corrected
>  - backlight node corrected
>  - flags rather than magic numbers used
>  - registers for usbphys added
>  - set up IOMUX configuration correctly
>  - various whitespace corrections
>  - removed unused fsl,mode node

Actually I still see 'fsl,mode' under the ssi2 node. Please remove it.

> +#define I2C_PAD_CTL 0xc0000000

This still sets bits 31, which means the kernel will rely on the IOMUX
configuration from the bootloader.

It is better if you could just pass the real IOMUX values here instead.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-07-12 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 13:42 [PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD Martyn Welch
     [not found] ` <cffaa6f22474ff2ba4ca46d4252d35fc75cb0dd7.1499779628.git.martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2017-07-12 12:32   ` Fabio Estevam [this message]
2017-07-12 12:34     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5D6xw4hVCOWfM0+++PQ87xBwihGSCJZsW8qBdn==vrLvA@mail.gmail.com' \
    --to=festevam-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
    --cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
    --cc=nux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).