From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD Date: Wed, 12 Jul 2017 09:32:44 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Martyn Welch Cc: Sebastian Reichel , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , nux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel , Fabien Lahoudere , Sebastian Reichel List-Id: devicetree@vger.kernel.org On Tue, Jul 11, 2017 at 10:42 AM, Martyn Welch wrote: > Changes since PATCHv3: https://patchwork.kernel.org/patch/9819017/ > - licensing modified > - manufacturer changed to GE > - regulator nodes corrected > - backlight node corrected > - flags rather than magic numbers used > - registers for usbphys added > - set up IOMUX configuration correctly > - various whitespace corrections > - removed unused fsl,mode node Actually I still see 'fsl,mode' under the ssi2 node. Please remove it. > +#define I2C_PAD_CTL 0xc0000000 This still sets bits 31, which means the kernel will rely on the IOMUX configuration from the bootloader. It is better if you could just pass the real IOMUX values here instead. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html