* [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl
@ 2015-12-09 8:15 Bai Ping
2015-12-14 3:07 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Bai Ping @ 2015-12-09 8:15 UTC (permalink / raw)
To: shawnguo, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel
The 'assigned-clock-parents' and 'assigned-clock-rates' list
should corresponding to the 'assigned-clocks' property clock list.
Signed-off-by: Bai Ping <b51503@freescale.com>
---
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
index 5a26173..dd92279 100644
--- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
@@ -113,14 +113,14 @@
&clks {
assigned-clocks = <&clks IMX6QDL_PLL4_BYPASS_SRC>,
<&clks IMX6QDL_PLL4_BYPASS>,
- <&clks IMX6QDL_CLK_PLL4_POST_DIV>,
<&clks IMX6QDL_CLK_LDB_DI0_SEL>,
- <&clks IMX6QDL_CLK_LDB_DI1_SEL>;
+ <&clks IMX6QDL_CLK_LDB_DI1_SEL>,
+ <&clks IMX6QDL_CLK_PLL4_POST_DIV>;
assigned-clock-parents = <&clks IMX6QDL_CLK_LVDS2_IN>,
<&clks IMX6QDL_PLL4_BYPASS_SRC>,
<&clks IMX6QDL_CLK_PLL3_USB_OTG>,
<&clks IMX6QDL_CLK_PLL3_USB_OTG>;
- assigned-clock-rates = <0>, <0>, <24576000>;
+ assigned-clock-rates = <0>, <0>, <0>, <0>, <24576000>;
};
&ecspi1 {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl
2015-12-09 8:15 [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl Bai Ping
@ 2015-12-14 3:07 ` Shawn Guo
2015-12-15 8:52 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2015-12-14 3:07 UTC (permalink / raw)
To: Bai Ping
Cc: kernel, mark.rutland, devicetree, robh+dt, linux-kernel,
linux-arm-kernel
On Wed, Dec 09, 2015 at 04:15:55PM +0800, Bai Ping wrote:
> The 'assigned-clock-parents' and 'assigned-clock-rates' list
> should corresponding to the 'assigned-clocks' property clock list.
>
> Signed-off-by: Bai Ping <b51503@freescale.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl
2015-12-14 3:07 ` Shawn Guo
@ 2015-12-15 8:52 ` Shawn Guo
2015-12-15 11:16 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2015-12-15 8:52 UTC (permalink / raw)
To: Bai Ping, Fabio Estevam
Cc: mark.rutland, devicetree, linux-kernel, robh+dt, kernel,
linux-arm-kernel
On Mon, Dec 14, 2015 at 11:07:50AM +0800, Shawn Guo wrote:
> On Wed, Dec 09, 2015 at 04:15:55PM +0800, Bai Ping wrote:
> > The 'assigned-clock-parents' and 'assigned-clock-rates' list
> > should corresponding to the 'assigned-clocks' property clock list.
> >
> > Signed-off-by: Bai Ping <b51503@freescale.com>
>
> Applied, thanks.
As this essentially a fix to ed339363de1b ("ARM: dts: imx6qdl-sabreauto:
Allow HDMI and LVDS to work simultaneously"), I'm going to send it as a
fix with copying stable.
@Fabio,
Do you agree with the fix?
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl
2015-12-15 8:52 ` Shawn Guo
@ 2015-12-15 11:16 ` Fabio Estevam
2015-12-15 12:25 ` Bai Ping
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2015-12-15 11:16 UTC (permalink / raw)
To: Shawn Guo
Cc: Bai Ping, Fabio Estevam, Mark Rutland,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Sascha Hauer,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
On Tue, Dec 15, 2015 at 6:52 AM, Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Mon, Dec 14, 2015 at 11:07:50AM +0800, Shawn Guo wrote:
>> On Wed, Dec 09, 2015 at 04:15:55PM +0800, Bai Ping wrote:
>> > The 'assigned-clock-parents' and 'assigned-clock-rates' list
>> > should corresponding to the 'assigned-clocks' property clock list.
>> >
>> > Signed-off-by: Bai Ping <b51503-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>
>> Applied, thanks.
>
> As this essentially a fix to ed339363de1b ("ARM: dts: imx6qdl-sabreauto:
> Allow HDMI and LVDS to work simultaneously"), I'm going to send it as a
> fix with copying stable.
Actually the mismatch exists since 97dae8590fa314c ("ARM: dts:
imx6qdl-sabreauto: Add audio support").
> @Fabio,
>
> Do you agree with the fix?
It seems that even after this patch we still have a mismatch:
assigned-clocks has 5 members and assigned-clock-parents has 4.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl
2015-12-15 11:16 ` Fabio Estevam
@ 2015-12-15 12:25 ` Bai Ping
[not found] ` <567006C4.8050906-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Bai Ping @ 2015-12-15 12:25 UTC (permalink / raw)
To: Fabio Estevam, Shawn Guo
Cc: Fabio Estevam, Mark Rutland, devicetree@vger.kernel.org,
linux-kernel, robh+dt@kernel.org, Sascha Hauer,
linux-arm-kernel@lists.infradead.org
On 2015/12/15 19:16, Fabio Estevam wrote:
> On Tue, Dec 15, 2015 at 6:52 AM, Shawn Guo <shawnguo@kernel.org> wrote:
>> On Mon, Dec 14, 2015 at 11:07:50AM +0800, Shawn Guo wrote:
>>> On Wed, Dec 09, 2015 at 04:15:55PM +0800, Bai Ping wrote:
>>>> The 'assigned-clock-parents' and 'assigned-clock-rates' list
>>>> should corresponding to the 'assigned-clocks' property clock list.
>>>>
>>>> Signed-off-by: Bai Ping <b51503@freescale.com>
>>> Applied, thanks.
>> As this essentially a fix to ed339363de1b ("ARM: dts: imx6qdl-sabreauto:
>> Allow HDMI and LVDS to work simultaneously"), I'm going to send it as a
>> fix with copying stable.
> Actually the mismatch exists since 97dae8590fa314c ("ARM: dts:
> imx6qdl-sabreauto: Add audio support").
>
>> @Fabio,
>>
>> Do you agree with the fix?
> It seems that even after this patch we still have a mismatch:
> assigned-clocks has 5 members and assigned-clock-parents has 4.
I think if it is the last clock in the assigned-clock list, the
corresponding
'assigned-clock-parents' and 'assigned-clock-rates' entry can be omitted.
BR
Jacky Bai
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-15 12:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09 8:15 [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl Bai Ping
2015-12-14 3:07 ` Shawn Guo
2015-12-15 8:52 ` Shawn Guo
2015-12-15 11:16 ` Fabio Estevam
2015-12-15 12:25 ` Bai Ping
[not found] ` <567006C4.8050906-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-12-15 12:44 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).