From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH v4 2/4] crypto: mxs-dcp - Add support for dcp clk Date: Wed, 17 Oct 2018 10:02:41 -0300 Message-ID: References: <95dce7010676581691b1ac9906e9298470e0aa1a.1539779579.git.leonard.crestez@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Leonard Crestez Cc: NXP Linux Team , linux-kernel , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Fabio Estevam , Aymen Sghaier , Franck LENORMAND , Mark Rutland , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "David S. Miller" , Horia Geanta Neag , Sascha Hauer , Herbert Xu , Marek Vasut "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" List-Id: devicetree@vger.kernel.org On Wed, Oct 17, 2018 at 9:59 AM Leonard Crestez wrote: > There is a changelog in the cover letter. It did not show up: https://lkml.org/lkml/2018/10/17/673 > This only looks slightly odd in git diff but it's not unrelated. > > I placed clk get/prepare/enable just before stmp_reset_block and made > stmp_reset_block print a message and goto err_disable_unprepare_clk on > failure instead of just "if (ret) return ret;" Got it! Then it looks fine, thanks: Reviewed-by: Fabio Estevam