[PATCH] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

[PATCH] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

[Pierluigi Passaro]

According section
    8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
of 
    i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
the required setting for this specific pin configuration is "1"

Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h b/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
index 83c8f715cd90..b1f11098d248 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
+++ b/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
@@ -602,7 +602,7 @@
 #define MX8MM_IOMUXC_UART1_RXD_GPIO5_IO22                                   0x234 0x49C 0x000 0x5 0x0
 #define MX8MM_IOMUXC_UART1_RXD_TPSMP_HDATA24                                0x234 0x49C 0x000 0x7 0x0
 #define MX8MM_IOMUXC_UART1_TXD_UART1_DCE_TX                                 0x238 0x4A0 0x000 0x0 0x0
-#define MX8MM_IOMUXC_UART1_TXD_UART1_DTE_RX                                 0x238 0x4A0 0x4F4 0x0 0x0
+#define MX8MM_IOMUXC_UART1_TXD_UART1_DTE_RX                                 0x238 0x4A0 0x4F4 0x0 0x1
 #define MX8MM_IOMUXC_UART1_TXD_ECSPI3_MOSI                                  0x238 0x4A0 0x000 0x1 0x0
 #define MX8MM_IOMUXC_UART1_TXD_GPIO5_IO23                                   0x238 0x4A0 0x000 0x5 0x0
 #define MX8MM_IOMUXC_UART1_TXD_TPSMP_HDATA25                                0x238 0x4A0 0x000 0x7 0x0
-- 
2.37.2

Re: [PATCH] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

[Fabio Estevam]

Hi Pierluigi,

Thanks for the patch.

On Sun, Jan 15, 2023 at 7:32 AM Pierluigi Passaro
<pierluigi.passaro@gmail.com> wrote:
>
> According section
>     8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> of
>     i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> the required setting for this specific pin configuration is "1"

Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Re: [PATCH] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

[Fabio Estevam]

Hi Pierluigi,

On Sun, Jan 15, 2023 at 9:27 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Pierluigi,
>
> Thanks for the patch.
>
> On Sun, Jan 15, 2023 at 7:32 AM Pierluigi Passaro
> <pierluigi.passaro@gmail.com> wrote:
> >
> > According section
> >     8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> > of
> >     i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> > the required setting for this specific pin configuration is "1"
>
> Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

./scripts/checkpatch.pl shows the following problem with your patch:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Pierluigi
Passaro <pierluigi.passaro@gmail.com>' != 'Signed-off-by: Pierluigi
Passaro <pierluigi.p@variscite.com>'

Please adjust this, add the Fixes tag and send a v2.

Thanks

Re: [PATCH] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

[Pierluigi Passaro]

On Sun, Jan 15, 2023 at 9:48 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Pierluigi,
>
> On Sun, Jan 15, 2023 at 9:27 AM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > Hi Pierluigi,
> >
> > Thanks for the patch.
> >
> > On Sun, Jan 15, 2023 at 7:32 AM Pierluigi Passaro
> > <pierluigi.passaro@gmail.com> wrote:
> > >
> > > According section
> > >     8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> > > of
> > >     i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> > > the required setting for this specific pin configuration is "1"
> >
> > Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")
> >
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> ./scripts/checkpatch.pl shows the following problem with your patch:
>
> WARNING: From:/Signed-off-by: email address mismatch: 'From: Pierluigi
> Passaro <pierluigi.passaro@gmail.com>' != 'Signed-off-by: Pierluigi
> Passaro <pierluigi.p@variscite.com>'
>
> Please adjust this, add the Fixes tag and send a v2.
>
I have a temporary SMTP configuration problem with my company account.
As soon as it will be fixed, the patch will have no changes, will only change
the SMTP mail server: is this warning so critical ?
>
> Thanks

Re: [PATCH] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

[Fabio Estevam]

On Sun, Jan 15, 2023 at 5:54 PM Pierluigi Passaro
<pierluigi.passaro@gmail.com> wrote:

> I have a temporary SMTP configuration problem with my company account.
> As soon as it will be fixed, the patch will have no changes, will only change
> the SMTP mail server: is this warning so critical ?

You can manually edit the From line of your patch and change:

From: Pierluigi Passaro <pierluigi.passaro@gmail.com>

to

From: Pierluigi Passaro <pierluigi.p@variscite.com>

and then send it from your Gmail account.