From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock Date: Tue, 9 Jan 2018 07:26:43 -0200 Message-ID: References: <1515466276-5541-1-git-send-email-Anson.Huang@nxp.com> <1515466276-5541-2-git-send-email-Anson.Huang@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1515466276-5541-2-git-send-email-Anson.Huang@nxp.com> Sender: linux-clk-owner@vger.kernel.org To: Anson Huang Cc: Horia Geanta Neag , aymen.sghaier@nxp.com, Herbert Xu , "David S. Miller" , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King - ARM Linux , Michael Turquette , Stephen Boyd , adriana.reus@nxp.com, Stefan Agner , Dong Aisheng , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" List-Id: devicetree@vger.kernel.org Hi Anson, On Tue, Jan 9, 2018 at 12:51 AM, Anson Huang wrote: > + - clocks > + Usage: required if SNVS LP RTC requires explicit enablement of clocks > + Value type: > + Definition: A list of phandle and clock specifier pairs describing > + the clocks required for enabling and disabling SNVS LP RTC. It is a single clock that is used here, so it would be better to describe the text as: Definition: A clock specifier describing the clock required for enabling and disabling SNVS LP RTC > + - clock-names > + Usage: required if SNVS LP RTC requires explicit enablement of clocks > + Value type: > + Definition: A list of clock name strings in the same order as the > + clocks property. and here you must describe that the name should be "snvs-rtc": Definition: Clock name string should be "snvs-rtc".