From: Fabio Estevam <festevam@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Trimarchi <michael@amarulasolutions.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Yongcai Huang <anson.huang@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH v2] dt-bindings: clock: imx6ul: Do not change the clock definition order
Date: Wed, 6 Jun 2018 18:56:26 -0300 [thread overview]
Message-ID: <CAOMZO5DOBg+f4Lvh2KoMBjHDnenFh09Sy5HDWfA1Qb5Lit2mng@mail.gmail.com> (raw)
In-Reply-To: <3be11aeea9cd0399837acb201f6226d9@agner.ch>
Hi Stefan,
On Wed, Jun 6, 2018 at 1:27 PM, Stefan Agner <stefan@agner.ch> wrote:
>> +#define IMX6ULL_CLK_ESAI_SEL 236
>
> Nit: Add an empty line here?
The lack of an empty line is on purpose because I wanted to avoid
someone thinking:
"Oh, there is hole here, let me fill it with new clocks here" :-)
> Reviewed-by: Stefan Agner <stefan@agner.ch>
Thanks for reviewing!
next prev parent reply other threads:[~2018-06-06 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 14:02 [PATCH v2] dt-bindings: clock: imx6ul: Do not change the clock definition order Fabio Estevam
2018-06-05 21:08 ` Rob Herring
2018-06-06 16:27 ` Stefan Agner
2018-06-06 21:56 ` Fabio Estevam [this message]
2018-06-29 18:26 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5DOBg+f4Lvh2KoMBjHDnenFh09Sy5HDWfA1Qb5Lit2mng@mail.gmail.com \
--to=festevam@gmail.com \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-clk@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).