From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD Date: Fri, 26 Jan 2018 22:28:30 -0200 Message-ID: References: <20180127000752.2879-1-benoit.thebaudeau.dev@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20180127000752.2879-1-benoit.thebaudeau.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Cc: linux-kernel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Russell King , Mark Rutland , Rob Herring , Fabio Estevam , Sascha Hauer , Shawn Guo , Michael Nazzareno Trimarchi , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= List-Id: devicetree@vger.kernel.org On Fri, Jan 26, 2018 at 10:07 PM, Beno=C3=AEt Th=C3=A9baudeau wrote: > The eSDHC does not work properly if the SION bit is not set for the > bidirectional CMD signal, whatever the eSDHC instance and the selected > pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do > this for MX25_PAD_*__SD*_CMD in imx25-pinfunc.h in order to enforce this > behavior for all boards. > > This had already been done for eSDHC1, but not for eSDHC2. Also, define > MX25_PAD_FEC_MDC__SDHC2_CMD so that all the possible cases are covered > from now on. > > Signed-off-by: Beno=C3=AEt Th=C3=A9baudeau Thanks for the fix: Reviewed-by: Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html