devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Zampieri <lzampier@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Charles Mirabile <cmirabil@redhat.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	Samuel Holland <samuel.holland@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Alexandre Ghiti <alex@ghiti.fr>,
	Vivian Wang <dramforever@live.com>,
	devicetree@vger.kernel.org,  linux-riscv@lists.infradead.org,
	Zhang Xincheng <zhangxincheng@ultrarisc.com>
Subject: Re: [PATCH v5 3/3] irqchip/plic: add support for UltraRISC DP1000 PLIC
Date: Fri, 17 Oct 2025 12:52:48 +0100	[thread overview]
Message-ID: <CAOOg__AHpFsxU==JPX_usRnkJSL6agadsGZUxdh0L0DriFwcQg@mail.gmail.com> (raw)
In-Reply-To: <87sefj179h.ffs@tglx>

Hi Thomas

I'm really sorry for that.

On Thu, Oct 16, 2025 at 11:16 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Thu, Oct 16 2025 at 09:42, Lucas Zampieri wrote:
> > @@ -430,6 +516,8 @@ static const struct of_device_id plic_match[] = {
>       ^^^^^^^^^^^^
> How on earth did you manage to screw up the hunk header?
>
I was copying hunks over from one file to another to avoid
format-patch as it was screwing the email headers, after that I
learned that there's --[no-]encode-email-headers in format-patch for
that.

> Applying: irqchip/plic: Add support for UltraRISC DP1000 PLIC
> error: corrupt patch at line 116
>
> >         .data = (const void *)BIT(PLIC_QUIRK_EDGE_INTERRUPT) },
> >       { .compatible = "thead,c900-plic",
> >         .data = (const void *)BIT(PLIC_QUIRK_EDGE_INTERRUPT) },
> > +     { .compatible = "ultrarisc,cp100-plic",
> > +       .data = (const void *)BIT(PLIC_QUIRK_CP100_CLAIM_REGISTER_ERRATUM) },
> >       {}
> >  };
> >
> > @@ -664,12 +752,16 @@ static int plic_probe(struct fwnode_handle *fwnode)
>      ^^^^^^^^^^^^^^^
> Ditto here.
>
> I fixed it up manually. Please be more careful next time.
>
For sure, wont happen again, thanks for taking the time of manually fixing it.

Lucas Zampieri


  reply	other threads:[~2025-10-17 11:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  8:42 [PATCH v5 0/3] Add UltraRISC DP1000 PLIC support Lucas Zampieri
2025-10-16  8:42 ` [PATCH v5 1/3] dt-bindings: vendor-prefixes: add UltraRISC Lucas Zampieri
2025-10-16  8:42 ` [PATCH v5 2/3] dt-bindings: interrupt-controller: add UltraRISC DP1000 PLIC Lucas Zampieri
2025-10-16  8:42 ` [PATCH v5 3/3] irqchip/plic: add support for " Lucas Zampieri
2025-10-16 10:16   ` Thomas Gleixner
2025-10-17 11:52     ` Lucas Zampieri [this message]
2025-10-16 13:17   ` Thomas Gleixner
2025-10-16 15:54     ` Charles Mirabile
2025-10-16 16:12       ` Thomas Gleixner
2025-10-16 16:52         ` Charles Mirabile
2025-10-16 17:53           ` Thomas Gleixner
2025-10-16 19:58             ` Charles Mirabile
2025-10-17 13:28               ` Thomas Gleixner
2025-10-16 21:09   ` Bo Gan
2025-10-16 21:28   ` Bo Gan
2025-10-16 22:01     ` Samuel Holland
2025-10-16 23:19       ` Bo Gan
2025-10-16 23:25     ` Charles Mirabile
2025-10-17 21:25       ` Bo Gan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOOg__AHpFsxU==JPX_usRnkJSL6agadsGZUxdh0L0DriFwcQg@mail.gmail.com' \
    --to=lzampier@redhat.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=cmirabil@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dramforever@live.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=tglx@linutronix.de \
    --cc=zhangxincheng@ultrarisc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).