From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B081305E32 for ; Fri, 24 Oct 2025 08:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761294904; cv=none; b=Q49BkUnFjdEt4DvqaZBMwlt5T/A0RvQ9bGiGsxY5XuqD0gpxgf26vSO0JJ8paYxNZ6EC0uLamvAInL+QNVRkFntNBNtIdlb23OF7ulnMYT6lpfgIA5ioB+HX7OwhlIKcqGEQD0paPDX4/xIMi7gmnUG9z8S/rJOLC27PAsFK8W4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761294904; c=relaxed/simple; bh=M2SzRXTzZ912bnvsnzX8KTcPiQoMOXHFj449bF5Uwl0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=W3sZbCOR8h9BLLqrU3RVPt2k9E08Jo6TlKOV0kp233E17uMZ9nsHN0aT8JhxAJ/aWISvJk3TKu5AjfS/CFidtxNwH+pRlHpUgCWGI832kto4zGTc4M4kfz/iKMFGdukWg6/JoCCtu8Wqs2CY9Vhl5x+AEXJV6HJH9U1OsSpXnIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g8OYVLkf; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g8OYVLkf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761294901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wMiM7iwLyLoXC8XMxApEUes6hHrQXoxnQoRnHPw1Y6A=; b=g8OYVLkfwqEWybw/+Q4CUDSishLDBQ02IggVLYxf97il+TgPus1QF/903KkcDyBU+KqBkn K9sBZ4HLM26OHDPc2hVJOCHM9HVSbLvzanUMIvV6r8b8fNYTrRLMjRbT6U+azL8yWW3TAl mcEamtf3GSj5CHGWgTNgvDucW2KUYSo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-DGrPolURNDatqLowXD4_mA-1; Fri, 24 Oct 2025 04:34:59 -0400 X-MC-Unique: DGrPolURNDatqLowXD4_mA-1 X-Mimecast-MFC-AGG-ID: DGrPolURNDatqLowXD4_mA_1761294898 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-426d4f59cbcso1979303f8f.1 for ; Fri, 24 Oct 2025 01:34:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761294898; x=1761899698; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wMiM7iwLyLoXC8XMxApEUes6hHrQXoxnQoRnHPw1Y6A=; b=NLThZ4EPtA7MV1+UjLVpUA42mNg4Y04fV2nyhEkFtl+Dm/STZ5d4Fyla7v0540oh60 WFO2Eg+B5uo0fjOarsjsRcAuw9aLoeEy5qCWd0+k9CBfDpWwfrVawEIeCEKKcDnPm8Jr 5T/MQ5Jr/STmHrJHCzTWahBMEh/yGc63UVOGyI/bTgbd9Hp/xc1Uxojahb6IvyOxnhfZ AJnu0MxtLn/8kPug9QW5DAmp5uMizXLbfIcFkY49/stWUrfQmEJ1SIjr7yBVGTEt0Ekv U18DIMtm+rGTisPwZ6XMuAlvoLtD1iBmgZMoOg1/EWQLII+He/y0wklsHLA/MetlyH62 sCNA== X-Forwarded-Encrypted: i=1; AJvYcCU/gYTJw1DlXOHNt9zXig/zdCtNYZ5XKIhs3Fsd6tJqcyO09HiUvNdEB33IJ6eL4fiDWLDWyGILGbFc@vger.kernel.org X-Gm-Message-State: AOJu0Yyqkj3UgEJnYnRZCuxysULQACDY00DjkdjyLuyKMhaTYq0W+0Sm gM/v8B1ajYTwCINOxNzFkS/8Jz959f7nh1cBDdD0cAN9RxzF14vT9VofewBOS/RZIshXK+iDzTc aVDLmeH5htYjyjCHO6UJnbjJzWcFgaWXJ97ZV33cVYeEj7F44qPGsiU3z2rhpVfGpjV59nXVBU5 RggA7c2BSQRbyfQIzHJhRQNmp4SBlZJGhZD2fYNQ== X-Gm-Gg: ASbGncvsleKefGo45n4Rpy6l3AJI0wiKZPWSvb7hO2Gm0BBEtxh3o6VpBTq7owgIKVA cN7RuqhYMpWVq1bwOA9B3praENgyywLD2TXCw/hsij/eHObYc4qIB5QTs0IYr08Htna0vcI6bM6 TypSs0gjDX3Kxr8EsaT+LboFjirOQyFAMHKbo2slJ+uctxg2BTRMnojKY= X-Received: by 2002:a05:6000:2283:b0:3e7:6424:1b47 with SMTP id ffacd0b85a97d-4298f51e6c7mr1615343f8f.6.1761294898399; Fri, 24 Oct 2025 01:34:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHneq26JtjC7v0qH5eo9W4vFieyRgtLB+lIw8JjnfPG0eDTw3SOftuEUINlVQTBND/drYvIkk+yrtxFaM/VtJ4= X-Received: by 2002:a05:6000:2283:b0:3e7:6424:1b47 with SMTP id ffacd0b85a97d-4298f51e6c7mr1615312f8f.6.1761294897890; Fri, 24 Oct 2025 01:34:57 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <87zf9hwh5j.ffs@tglx> <20251023201721.549563-1-cmirabil@redhat.com> In-Reply-To: <20251023201721.549563-1-cmirabil@redhat.com> From: Lucas Zampieri Date: Fri, 24 Oct 2025 09:34:47 +0100 X-Gm-Features: AWmQ_bkjLCK7rYokvdeJT5wSgmJ0C1bDhIh6rvdCrhkYGtz_4gZYQEXFLd46qyU Message-ID: Subject: Re: [PATCH v6 0/4] Add UltraRISC DP1000 PLIC support To: Charles Mirabile Cc: tglx@linutronix.de, alex@ghiti.fr, aou@eecs.berkeley.edu, conor+dt@kernel.org, devicetree@vger.kernel.org, dramforever@live.com, krzk+dt@kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, robh@kernel.org, samuel.holland@sifive.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Thomas and Charles, Yes, missed the cc list to on that one, sending the v6 series again with the correct headers. Sorry about that. Lucas Zampieri Platform Enablement Team On Thu, Oct 23, 2025 at 9:17=E2=80=AFPM Charles Mirabile wrote: > > Hi Thomas=E2=80=94 > > On Thu, Oct 23, 2025 at 09:29:44PM +0200, Thomas Gleixner wrote: > > On Thu, Oct 23 2025 at 15:00, Lucas Zampieri wrote: > > > This series adds support for the PLIC implementation in the UltraRISC > > > DP1000 SoC. The UR-CP100 cores used in the DP1000 have a hardware bug= in > > > their PLIC claim register where reading it while multiple interrupts = are > > > pending can return the wrong interrupt ID. The workaround temporarily > > > disables all interrupts except the first pending one before reading t= he > > > claim register, then restores the previous state. > > > > > > The driver matches on "ultrarisc,cp100-plic" (CPU core compatible), a= llowing > > > the quirk to apply to all SoCs using UR-CP100 cores (currently DP1000= , > > > potentially future SoCs). > > > > > > Charles Mirabile (3): > > > dt-bindings: interrupt-controller: add UltraRISC DP1000 PLIC > > > irqchip/plic: enable optimization of interrupt enable state > > > > That one never showed up. Neither in my inbox nor on lore > > Looks like the CC list was missing somehow from that patch=E2=80=94I didn= 't notice because I got it in my inbox because of my Signed-off-by. > > The indexing on the patches was slightly wrong anyways, so we will resend= tomorrow. Sorry for the noise. > > I have attached it here in case you want to take a look. > > > > -- >8 -- > From: Charles Mirabile > Subject: [PATCH v6 3/4] irqchip/plic: enable optimization of interrupt en= able state > > Optimize the PLIC driver by maintaining the interrupt enable state in > the handler's enable_save array during normal operation rather than only > during suspend/resume. This eliminates the need to read enable registers > during suspend and makes the enable state immediately available for > other optimizations. > > Modify __plic_toggle() to take a handler pointer instead of enable_base, > allowing it to update both the hardware registers and the cached > enable_save state atomically within the existing enable_lock protection. > > Remove the suspend-time enable register reading since enable_save now > always reflects the current state. > > Signed-off-by: Charles Mirabile > > --- > drivers/irqchip/irq-sifive-plic.c | 36 +++++++++++-------------------- > 1 file changed, 13 insertions(+), 23 deletions(-) > > diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifi= ve-plic.c > index cbd7697bc1481..d518a8b468742 100644 > --- a/drivers/irqchip/irq-sifive-plic.c > +++ b/drivers/irqchip/irq-sifive-plic.c > @@ -94,15 +94,22 @@ static DEFINE_PER_CPU(struct plic_handler, plic_handl= ers); > > static int plic_irq_set_type(struct irq_data *d, unsigned int type); > > -static void __plic_toggle(void __iomem *enable_base, int hwirq, int enab= le) > +static void __plic_toggle(struct plic_handler *handler, int hwirq, int e= nable) > { > - u32 __iomem *reg =3D enable_base + (hwirq / 32) * sizeof(u32); > + u32 __iomem *base =3D handler->enable_base; > u32 hwirq_mask =3D 1 << (hwirq % 32); > + int group =3D hwirq / 32; > + u32 value; > + > + value =3D readl(base + group); > > if (enable) > - writel(readl(reg) | hwirq_mask, reg); > + value |=3D hwirq_mask; > else > - writel(readl(reg) & ~hwirq_mask, reg); > + value &=3D ~hwirq_mask; > + > + handler->enable_save[group] =3D value; > + writel(value, base + group); > } > > static void plic_toggle(struct plic_handler *handler, int hwirq, int ena= ble) > @@ -110,7 +117,7 @@ static void plic_toggle(struct plic_handler *handler,= int hwirq, int enable) > unsigned long flags; > > raw_spin_lock_irqsave(&handler->enable_lock, flags); > - __plic_toggle(handler->enable_base, hwirq, enable); > + __plic_toggle(handler, hwirq, enable); > raw_spin_unlock_irqrestore(&handler->enable_lock, flags); > } > > @@ -247,33 +254,16 @@ static int plic_irq_set_type(struct irq_data *d, un= signed int type) > > static int plic_irq_suspend(void) > { > - unsigned int i, cpu; > - unsigned long flags; > - u32 __iomem *reg; > struct plic_priv *priv; > > priv =3D per_cpu_ptr(&plic_handlers, smp_processor_id())->priv; > > /* irq ID 0 is reserved */ > - for (i =3D 1; i < priv->nr_irqs; i++) { > + for (unsigned int i =3D 1; i < priv->nr_irqs; i++) { > __assign_bit(i, priv->prio_save, > readl(priv->regs + PRIORITY_BASE + i * PRIOR= ITY_PER_ID)); > } > > - for_each_present_cpu(cpu) { > - struct plic_handler *handler =3D per_cpu_ptr(&plic_handle= rs, cpu); > - > - if (!handler->present) > - continue; > - > - raw_spin_lock_irqsave(&handler->enable_lock, flags); > - for (i =3D 0; i < DIV_ROUND_UP(priv->nr_irqs, 32); i++) { > - reg =3D handler->enable_base + i * sizeof(u32); > - handler->enable_save[i] =3D readl(reg); > - } > - raw_spin_unlock_irqrestore(&handler->enable_lock, flags); > - } > - > return 0; > } > > -- > 2.51.0 > >