From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Caione Subject: Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209 Date: Sat, 1 Mar 2014 18:17:18 +0100 Message-ID: References: <1393692352-10839-1-git-send-email-carlo@caione.org> <53121151.9050804@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <53121151.9050804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Hans de Goede Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Sat, Mar 1, 2014 at 5:56 PM, Hans de Goede wrote: > Hi Carlo, > > Great work, thanks for all the time you're putting into this! Hi Hans :) > I've 2 questions: > > 1) What dependencies does this patch-set have? Obviously it needs the NMI irq > patches for A20, anything else ? I no longer see any use of a special flag > for ack on unmask, is that no longer needed ? Yes, the only dependency is on the NMI controller patch. After a discussion with Maxime and Thomas I decided to not push for including the special flag for ack on unmask in the irqchip core but to use the unmask callback as in the v3 version of the NMI controller driver (so no flag needed) > 2) No poweroff functionality ? That would be really great to have. Actually in [PATCH 1/7] I support the poweroff using the pm_power_off hook. Best, -- Carlo Caione