From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF1B192D7A for ; Tue, 8 Oct 2024 10:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728383005; cv=none; b=kCTqs0MBDOHXqqqDl3Lzrvth3U49B8Y7an2XxMB+PpLDnFrkLu6+bUZHhK26x4QVuP2ZXVZNsmdQs+TuxAMKWcWWs2/67YO6ixaaoqnKIwSEmbjNRYKinKt1PRiy1+4xynEQa5kH8PGu03/Wior10v6kvpSC+JMyk2wrWPb/ow0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728383005; c=relaxed/simple; bh=f2JudxArye2wpiIb8K+RhPOO4cRulPiz/mwLo46SQUc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rtLch8gLZQAHu17Zew6JfmzLYj5zIZD7jW6YiWO3IoSlEJyqCzNaUxZs7EAAHTGgCRlGrF9D1sEb+QcvaH/JDRWnQwzUbaMnoMMYH4JF12cv5+7pgbjrxa3eDSb2MO8nXnIFfOcc++nTxFpKjAA4b41YqcqvIjOmJeL8L6ZxOJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=04fJqgdB; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="04fJqgdB" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-42f6995dab8so219545e9.0 for ; Tue, 08 Oct 2024 03:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728383002; x=1728987802; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fA/J2+ZQcPGnzj8ynI/jiVRpMpa13Bnx0iLjBY9FM9o=; b=04fJqgdBG0FKAXSEomaYi0tYw5yNwfAqSVCoSnlOH0bs+gj8nYzhpoiLXTzfkRHZfH msGf0FuDEr6doSi8oDRXFzNDyPe/911YIrvrJI1pVXAjcE0GgzMSxeRnswMPhvl/YCua j1e3G+e32Ehmr682utsuNtq/A3aNAfBlAXN00yhRyut1YO5JVL7VCzL+mhA/iwASsiEX SCrPgSPNu8ENloQyp5+DQm+4wUqox2eLJfIkiJVuoXyPXUTemqf0wWv+q4BGTGC6WuvH kCt+e/d2ROCuH+QNnbyPiDJLThUqHCKVcHn+ggYV4NLsGFUKoc+MZX/1Gtx9VtZwgbDD fAGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728383002; x=1728987802; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fA/J2+ZQcPGnzj8ynI/jiVRpMpa13Bnx0iLjBY9FM9o=; b=HmyQwFL2vJ3Iw1Hl/gxofOx+cvUhoeAnMnn3aEZfGFtaaxwtuSQZwRE5Nuvk3eucjn rfzia9WixPwjSW/6yISH3Mf8h4A6JLymrQRKFB3EWfBQNLz9QtiC+hqBIp3n3XmeuSqz jN9EdTFKvvbEJgIafvS7qzMLZX87SOaHpTP87OfOhC1GcWxaLNxqF6vsqK14dRFLBkXj BAMwTlDpwoVijcvFOwzSNA0I539UDYs8o398yhNfb2s76wLglBdOKPDLQjlWdJiqljPf LAnDC0toPI2aD+OkUda2B/Hy128BUKY5NdNkELbkwI/qU8+vMGwjuvnxylm6Aam1E/NU SBzA== X-Forwarded-Encrypted: i=1; AJvYcCXAMRECXsirr+luUPbQShsnDwyRvFspgqEC/j5H0CoPANc0a3g27T2qGBTdaDBxHDBu33T6ZvbfPd5U@vger.kernel.org X-Gm-Message-State: AOJu0YxoofbSh30ZixpE143cQ4rao9qPDkd+PxjxdGpyk0xXNylEn8at hVJrImJf/r7ozlTXE8wDsEd56s2FeCKk958Z9yCKA8hiS1KldGewKE79RKtlaFsb/+rOz5wqx2p mooWaH+zRy0Sz2N5HW60oJYceMuStOsm4h5Yo X-Google-Smtp-Source: AGHT+IHT/gNzWk1RKoaELNn2JDzijMxsvMFLG+EZNCcHZ4M5itLUHja0mfJFTvoukwb9uKzDVt6SzyaFPwzH3jyHGVA= X-Received: by 2002:a05:600c:5010:b0:428:e6eb:1340 with SMTP id 5b1f17b1804b1-42fcdcddf49mr4057055e9.4.1728383002113; Tue, 08 Oct 2024 03:23:22 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241007135508.3143756-1-joychakr@google.com> <20241007135508.3143756-2-joychakr@google.com> In-Reply-To: From: Joy Chakraborty Date: Tue, 8 Oct 2024 15:53:07 +0530 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2 de-emphasis To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thinh Nguyen , Felipe Balbi , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 7, 2024 at 8:26=E2=80=AFPM Krzysztof Kozlowski wrote: > > On 07/10/2024 15:55, Joy Chakraborty wrote: > > PIPE4 spec defines an 18bit de-emphasis setting to be passed from > > controller to the PHY. > > TxDeemph[17:0] is split as [5:0] C-1, [11:6] C0, [17:12] C+1 for 3 tap > > filter used for USB Gen2(10GT/s). > > > > Signed-off-by: Joy Chakraborty > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Doc= umentation/devicetree/bindings/usb/snps,dwc3.yaml > > index 1cd0ca90127d..a1f1bbcf1467 100644 > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > @@ -190,6 +190,18 @@ properties: > > - 1 # -3.5dB de-emphasis > > - 2 # No de-emphasis > > > > + snps,tx_gen2_de_emphasis_quirk: > > No underscores. Ack, will fix it with a follow up patch. > > > + description: When set core will set Tx de-emphasis for USB Gen2 > > And why it cannot be implied by compatible? As per my understanding these are tuning coefficients for de-emphasis particular to a platform and not the dwc3 controller, hence should not be a controller compatible. Similar to the property defined right above this definition which is from PIPE3 spec for USB Gen1. Thanks Joy > > > + type: boolean > > + > Best regards, > Krzysztof >