From: Robert Marko <robimarko@gmail.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: ipq5018: add QUP1 SPI controller
Date: Mon, 16 Oct 2023 21:53:23 +0200 [thread overview]
Message-ID: <CAOX2RU6KfMeJRFKdo_Kmb2OxZ12TrB+mARo_1uLJB8JuFsv_3w@mail.gmail.com> (raw)
In-Reply-To: <jxvpt2xo3fc2k7kflfsdov6uxpjpgqpomgmfvfgxwytejvkcgu@xwnfrg7be6qi>
On Mon, 16 Oct 2023 at 20:54, Bjorn Andersson <andersson@kernel.org> wrote:
>
> On Wed, Oct 04, 2023 at 09:12:30PM +0200, Robert Marko wrote:
> > Add the required BAM and QUP nodes for the QUP1 SPI controller on IPQ5018.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
>
> I padded the spi node to 8 digits, and applied the patch.
Thank you for this, it was in my TODO but that is quite long.
Regards,
Robert
>
> Thanks,
> Bjorn
>
> > ---
> > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > index 38ffdc3cbdcd..484034e65f4f 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > @@ -146,6 +146,16 @@ sdhc_1: mmc@7804000 {
> > status = "disabled";
> > };
> >
> > + blsp_dma: dma-controller@7884000 {
> > + compatible = "qcom,bam-v1.7.0";
> > + reg = <0x07884000 0x1d000>;
> > + interrupts = <GIC_SPI 238 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&gcc GCC_BLSP1_AHB_CLK>;
> > + clock-names = "bam_clk";
> > + #dma-cells = <1>;
> > + qcom,ee = <0>;
> > + };
> > +
> > blsp1_uart1: serial@78af000 {
> > compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
> > reg = <0x078af000 0x200>;
> > @@ -156,6 +166,20 @@ blsp1_uart1: serial@78af000 {
> > status = "disabled";
> > };
> >
> > + blsp1_spi1: spi@78b5000 {
> > + compatible = "qcom,spi-qup-v2.2.1";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x78b5000 0x600>;
> > + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&gcc GCC_BLSP1_QUP1_SPI_APPS_CLK>,
> > + <&gcc GCC_BLSP1_AHB_CLK>;
> > + clock-names = "core", "iface";
> > + dmas = <&blsp_dma 4>, <&blsp_dma 5>;
> > + dma-names = "tx", "rx";
> > + status = "disabled";
> > + };
> > +
> > intc: interrupt-controller@b000000 {
> > compatible = "qcom,msm-qgic2";
> > reg = <0x0b000000 0x1000>, /* GICD */
> > --
> > 2.41.0
> >
prev parent reply other threads:[~2023-10-16 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 19:12 [PATCH] arm64: dts: qcom: ipq5018: add QUP1 SPI controller Robert Marko
2023-10-05 13:48 ` Kathiravan Thirumoorthy
2023-10-05 13:55 ` Kathiravan Thirumoorthy
2023-10-16 18:58 ` Bjorn Andersson
2023-10-16 19:53 ` Robert Marko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOX2RU6KfMeJRFKdo_Kmb2OxZ12TrB+mARo_1uLJB8JuFsv_3w@mail.gmail.com \
--to=robimarko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).