From: viresh kumar <viresh.kumar@linaro.org>
To: Chris Ball <cjb@laptop.org>
Cc: spear-devel@list.st.com, linux-mmc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, sr@denx.de
Subject: Re: [PATCH Resend 1/2] mmc: sdhci-spear: add device tree bindings
Date: Fri, 28 Sep 2012 15:48:16 +0530 [thread overview]
Message-ID: <CAOh2x=n8HkH2Nd_t5hDiA8nxLyWQsCn-kF+zrPkhR0fWDCpanQ@mail.gmail.com> (raw)
In-Reply-To: <87626yv4jc.fsf@octavius.laptop.org>
On Fri, Sep 28, 2012 at 3:43 PM, Chris Ball <cjb@laptop.org> wrote:
> I think now is a good time to get the DT bindings right instead of
> propagating previous hacks into the DT, and this should be a pretty
> simple change -- it's not even a code change, since the code for
> automatically handling a vmmc-supply exists already. Once we start
> accepting power-gpios properties we can't easily get rid of them later.
>
> If you don't have time to work on this, I guess I could accept the patch
> without the power-gpios handling included (since it'll still work with
> a DT that provides a vmmc-supply), but I don't want to take the patch
> as-is and legitimize the power-gpios binding. Does that make sense?
Can't disagree with you, for not accepting it :)
Ok. For now i would just remove the power-gpios stuff and somebody from
ST will fix it with regulator stuff later.
--
viresh
next prev parent reply other threads:[~2012-09-28 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 5:18 [PATCH Resend 1/2] mmc: sdhci-spear: add device tree bindings Viresh Kumar
2012-09-28 5:18 ` [PATCH Resend 2/2] mmc: sdhci-spear: Add clk_{un}prepare() support Viresh Kumar
2012-09-28 9:03 ` [PATCH Resend 1/2] mmc: sdhci-spear: add device tree bindings Chris Ball
2012-09-28 9:49 ` viresh kumar
2012-09-28 10:13 ` Chris Ball
2012-09-28 10:18 ` viresh kumar [this message]
2012-09-28 9:59 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOh2x=n8HkH2Nd_t5hDiA8nxLyWQsCn-kF+zrPkhR0fWDCpanQ@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mmc@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).