Re: [PATCH net-next V4 3/9] Altera TSE: Add Altera Ethernet Driver MSGDMA File Components

[Vince Bridgers <vbridgers2013@gmail.com>]

Hi Joe,

On Wed, Mar 12, 2014 at 3:31 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:
>> This patch adds the MSGDMA soft IP support for the Altera Triple
>> Speed Ethernet driver.
>
> []
>
>> Signed-off-by: Vince Bridgers <vbridgers2013@gmail.com>
>> ---
>> V4: - Modify use of dev_* to netdev_* where possible
>
> Hi again Vince.
>
> trivia:
>
> It'd be better to also use the netif_<foo> forms too.
>
> This can be done later in a follow-on patch if desired.
>
>> diff --git a/drivers/net/ethernet/altera/altera_msgdma.c b/drivers/net/ethernet/altera/altera_msgdma.c
> []
>> +void msgdma_reset(struct altera_tse_private *priv)
>> +{
> []
>> +     if ((counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR) &&
>> +         (netif_msg_drv(priv)))
>> +             netdev_warn(priv->dev,
>> +                         "TSE Rx mSGDMA resetting bit never cleared!\n");
>
>         if (counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR)
>                 netif_warn(priv, drv, priv->dev,
>                            "TSE Rx mSGDMA resetting bit never cleared!\n");
>
> []
>
>> +     if ((counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR) &&
>> +         (netif_msg_drv(priv)))
>> +             netdev_warn(priv->dev,
>> +                         "TSE Tx mSGDMA resetting bit never cleared!\n");
>
>         if (counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR)
>                 netif_warn(priv, drv, priv->dev,
>                            "TSE Tx mSGDMA resetting bit never cleared!\n");
>
> cheers, Joe
>

You had mentioned this before, I guess I missed this. My apologies,
I'll pick this up in V5 with the misc other improvements.

All the best,

Vince