From: Tomer Maimon <tmaimon77@gmail.com>
To: Iwona Winiarska <iwona.winiarska@intel.com>
Cc: openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Avi Fishman <avifishman70@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Menzel <pmenzel@molgen.mpg.de>
Subject: Re: [PATCH v3 3/4] ARM: dts: nuvoton: Add PECI controller node
Date: Tue, 1 Aug 2023 11:40:54 +0300 [thread overview]
Message-ID: <CAP6Zq1hh_wr81L4vtYDct69rrqdSrxjap9-uZfvmt0xMvrfRJQ@mail.gmail.com> (raw)
In-Reply-To: <20230727202126.1477515-4-iwona.winiarska@intel.com>
Hi Iwona,
I have done r-b, Just could you do a small modification
On Thu, 27 Jul 2023 at 23:23, Iwona Winiarska <iwona.winiarska@intel.com> wrote:
>
> Add PECI controller node with all required information.
>
> Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com>
> ---
> arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> index c7b5ef15b716..cccc33441050 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> @@ -220,6 +220,15 @@ kcs3: kcs3@0 {
> };
> };
>
> + peci0: peci-controller@f0100000 {
Please modify the peci0 to peci we have only one PECI controller.
> + compatible = "nuvoton,npcm750-peci";
> + reg = <0xf0100000 0x200>;
> + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk NPCM7XX_CLK_APB3>;
> + cmd-timeout-ms = <1000>;
> + status = "disabled";
> + };
> +
> spi0: spi@200000 {
> compatible = "nuvoton,npcm750-pspi";
> reg = <0x200000 0x1000>;
> --
> 2.40.1
>
Reviewed-by: Tomer Maimon <tmaimon77@gmail.com>
Thanks,
Tomer
next prev parent reply other threads:[~2023-08-01 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 20:21 [PATCH v3 0/4] Add support for PECI Nuvoton Iwona Winiarska
2023-07-27 20:21 ` [PATCH v3 1/4] dt-bindings: Add bindings for peci-npcm Iwona Winiarska
2023-07-28 7:07 ` Krzysztof Kozlowski
2023-07-27 20:21 ` [PATCH v3 2/4] peci: Add peci-npcm controller driver Iwona Winiarska
2023-07-27 20:21 ` [PATCH v3 3/4] ARM: dts: nuvoton: Add PECI controller node Iwona Winiarska
2023-08-01 8:40 ` Tomer Maimon [this message]
2023-08-01 22:10 ` Winiarska, Iwona
2023-07-27 20:21 ` [PATCH v3 4/4] arm64: " Iwona Winiarska
2023-08-01 8:43 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP6Zq1hh_wr81L4vtYDct69rrqdSrxjap9-uZfvmt0xMvrfRJQ@mail.gmail.com \
--to=tmaimon77@gmail.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iwona.winiarska@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pmenzel@molgen.mpg.de \
--cc=robh+dt@kernel.org \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).