From: Tomer Maimon <tmaimon77@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: zhengbin13@huawei.com,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Nancy Yuen" <yuenn@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"Tali Perry" <tali.perry1@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Avi Fishman" <avifishman70@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Benjamin Fair" <benjaminfair@google.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
"Patrick Venture" <venture@google.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] dt-bindings: iio: adc: npcm: Add npcm845 compatible string
Date: Tue, 12 Jul 2022 11:03:30 +0300 [thread overview]
Message-ID: <CAP6Zq1jAzHysKaVMt960hsL2rN05_kfC265CS8Xcz1r8KOQDPg@mail.gmail.com> (raw)
In-Reply-To: <1657562119.172361.4172123.nullmailer@robh.at.kernel.org>
Hi Rob,
Thanks for your comment, it will be addressed next version.
On Mon, 11 Jul 2022 at 20:55, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, 11 Jul 2022 16:43:10 +0300, Tomer Maimon wrote:
> > Add a compatible string for Nuvoton BMC NPCM845 ADC.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
> > .../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.example.dtb: adc@f000c000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['nuvoton,npcm750-adc'] is too short
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
Best regards,
Tomer
next prev parent reply other threads:[~2022-07-12 8:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 13:43 [PATCH v1 0/2] iio: adc: npcm: add Arbel NPCM8XX support Tomer Maimon
2022-07-11 13:43 ` [PATCH v1 1/2] dt-bindings: iio: adc: npcm: Add npcm845 compatible string Tomer Maimon
2022-07-11 17:55 ` Rob Herring
2022-07-12 8:03 ` Tomer Maimon [this message]
2022-07-12 8:15 ` Krzysztof Kozlowski
2022-07-12 8:19 ` Tomer Maimon
2022-07-11 13:43 ` [PATCH v1 2/2] iio: adc: npcm: Add NPCM8XX support Tomer Maimon
2022-07-11 14:14 ` Andy Shevchenko
2022-07-11 14:16 ` Andy Shevchenko
2022-07-12 7:59 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP6Zq1jAzHysKaVMt960hsL2rN05_kfC265CS8Xcz1r8KOQDPg@mail.gmail.com \
--to=tmaimon77@gmail.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).