From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jim Davis <jim.epost@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
mingo@redhat.com, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: randconfig build error with next-20140122, in arch/x86/kernel/devicetree.c
Date: Wed, 22 Jan 2014 19:26:12 -0500 [thread overview]
Message-ID: <CAP=VYLq_rhAUqyfPAPYTwAH5zjR4OtpULGPh6dBQJDbGtG8ZcA@mail.gmail.com> (raw)
In-Reply-To: <52DFFAA7.40008@infradead.org>
On Wed, Jan 22, 2014 at 12:06 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 01/22/2014 08:34 AM, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> warning: (X86_INTEL_MID) selects INTEL_SCU_IPC which has unmet direct
>> dependencies (X86 && X86_PLATFORM_DEVICES && X86_INTEL_MID)
>> warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
>> which has unmet direct dependencies (USB_SUPPORT && USB && PM_RUNTIME)
>> warning: (X86_INTEL_MID) selects INTEL_SCU_IPC which has unmet direct
>> dependencies (X86 && X86_PLATFORM_DEVICES && X86_INTEL_MID)
>> warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
>> which has unmet direct dependencies (USB_SUPPORT && USB && PM_RUNTIME)
>>
>> arch/x86/kernel/devicetree.c:67:1: warning: data definition has no
>> type or storage class [enabled by default]
>> module_init(add_bus_probe);
>> ^
>
> For linux-next, devicetree.c needs to #include <linux/module.h>.
> For mainline, it would have needed to #include <linux/init.h>.
> However, it does neither of those.
Thanks guys; I've already queued a fix for this.
http://git.kernel.org/cgit/linux/kernel/git/paulg/init.git/commit/?id=3d83b6b84210066f0886b0916136fa49ca61704d
Paul.
--
>
> See Documentation/SubmitChecklist #1:
>
> 1: If you use a facility then #include the file that defines/declares
> that facility. Don't depend on other header files pulling in ones
> that you use.http://git.kernel.org/cgit/linux/kernel/git/paulg/init.git/commit/?id=3d83b6b84210066f0886b0916136fa49ca61704d
>
>
>> arch/x86/kernel/devicetree.c:67:1: error: type defaults to ‘int’ in
>> declaration of ‘module_init’ [-Werror=implicit-int]
>> arch/x86/kernel/devicetree.c:67:1: warning: parameter names (without
>> types) in function declaration [enabled by default]
>> arch/x86/kernel/devicetree.c:60:19: warning: ‘add_bus_probe’ defined
>> but not used [-Wunused-function]
>> static int __init add_bus_probe(void)
>> ^
>> cc1: some warnings being treated as errors
>> make[2]: *** [arch/x86/kernel/devicetree.o] Error 1
>>
>
>
> --
> ~Randy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-01-23 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 16:34 randconfig build error with next-20140122, in arch/x86/kernel/devicetree.c Jim Davis
2014-01-22 17:06 ` Randy Dunlap
2014-01-23 0:26 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP=VYLq_rhAUqyfPAPYTwAH5zjR4OtpULGPh6dBQJDbGtG8ZcA@mail.gmail.com' \
--to=paul.gortmaker@windriver.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=hpa@zytor.com \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).