[PATCH V3 2/8] dt-bindings: serial: lpuart: add imx8qxp compatible string

[PATCH V3 2/8] dt-bindings: serial: lpuart: add imx8qxp compatible string

[A.s. Dong]

Add imx8qxp compatible string

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-serial@vger.kernel.org
Cc: devicetree@vger.kernel.org
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 Documentation/devicetree/bindings/serial/fsl-lpuart.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt b/Documentation/devicetree/bindings/serial/fsl-lpuart.txt
index 6bd3f2e..21483ba 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.txt
@@ -8,6 +8,8 @@ Required properties:
     on LS1021A SoC with 32-bit big-endian register organization
   - "fsl,imx7ulp-lpuart" for lpuart compatible with the one integrated
     on i.MX7ULP SoC with 32-bit little-endian register organization
+  - "fsl,imx8qxp-lpuart" for lpuart compatible with the one integrated
+    on i.MX8QXP SoC with 32-bit little-endian register organization
 - reg : Address and length of the register set for the device
 - interrupts : Should contain uart interrupt
 - clocks : phandle + clock specifier pairs, one for each entry in clock-names
-- 
2.7.4

Re: [PATCH V3 2/8] dt-bindings: serial: lpuart: add imx8qxp compatible string

[Rob Herring]

On Thu, 18 Oct 2018 18:19:18 +0000, "A.s. Dong" wrote:
> Add imx8qxp compatible string
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-serial@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

[PATCH V3 3/8] dt-bindings: mmc: fsl-imx-esdhc: add imx8qxp compatible string

[A.s. Dong]

Add imx8qxp compatible string

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-serial@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
index 3e29050..9201a7d 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
@@ -16,6 +16,7 @@ Required properties:
 	       "fsl,imx6sl-usdhc"
 	       "fsl,imx6sx-usdhc"
 	       "fsl,imx7d-usdhc"
+	       "fsl,imx8qxp-usdhc"
 
 Optional properties:
 - fsl,wp-controller : Indicate to use controller internal write protection
-- 
2.7.4

Re: [PATCH V3 3/8] dt-bindings: mmc: fsl-imx-esdhc: add imx8qxp compatible string

[Rob Herring]

On Thu, 18 Oct 2018 18:19:24 +0000, "A.s. Dong" wrote:
> Add imx8qxp compatible string
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-serial@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH V3 3/8] dt-bindings: mmc: fsl-imx-esdhc: add imx8qxp compatible string

[Ulf Hansson]

On 18 October 2018 at 20:19, A.s. Dong <aisheng.dong@nxp.com> wrote:
> Add imx8qxp compatible string
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-serial@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt | 1 +

Queued for 4.21, thanks!

Kind regards
Uffe

>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> index 3e29050..9201a7d 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> @@ -16,6 +16,7 @@ Required properties:
>                "fsl,imx6sl-usdhc"
>                "fsl,imx6sx-usdhc"
>                "fsl,imx7d-usdhc"
> +              "fsl,imx8qxp-usdhc"
>
>  Optional properties:
>  - fsl,wp-controller : Indicate to use controller internal write protection
> --
> 2.7.4
>

[PATCH V3 4/8] dt-bindings: i2c: i2c-imx-lpi2c: add imx8qxp compatible string

[A.s. Dong]

Add imx8qxp compatible string

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org
Cc: devicetree@vger.kernel.org
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt
index 00e4365..abbc905 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt
@@ -4,6 +4,7 @@ Required properties:
 - compatible :
   - "fsl,imx7ulp-lpi2c" for LPI2C compatible with the one integrated on i.MX7ULP soc
   - "fsl,imx8dv-lpi2c" for LPI2C compatible with the one integrated on i.MX8DV soc
+  - "fsl,imx8qxp-lpi2c" for LPI2C compatible with the one integrated on i.MX8QXP soc
 - reg : address and length of the lpi2c master registers
 - interrupts : lpi2c interrupt
 - clocks : lpi2c clock specifier
-- 
2.7.4

Re: [PATCH V3 4/8] dt-bindings: i2c: i2c-imx-lpi2c: add imx8qxp compatible string

[Rob Herring]

On Thu, 18 Oct 2018 18:19:29 +0000, "A.s. Dong" wrote:
> Add imx8qxp compatible string
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: linux-i2c@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH V3 4/8] dt-bindings: i2c: i2c-imx-lpi2c: add imx8qxp compatible string

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 628 bytes --]

Hi,

On Thu, Oct 18, 2018 at 06:19:29PM +0000, A.s. Dong wrote:
> Add imx8qxp compatible string
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: linux-i2c@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>

Doesn't apply...

>    - "fsl,imx8dv-lpi2c" for LPI2C compatible with the one integrated on i.MX8DV soc

... I don't have this line in my tree.

Would you maybe volunteer to maintain this driver? To prevent stuff like
this from happening? :)

Regards,

   Wolfram


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH V3 4/8] dt-bindings: i2c: i2c-imx-lpi2c: add imx8qxp compatible string

[A.s. Dong]

Hi Wolfram,

[...]

> Hi,
> 
> On Thu, Oct 18, 2018 at 06:19:29PM +0000, A.s. Dong wrote:
> > Add imx8qxp compatible string
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Wolfram Sang <wsa@the-dreams.de>
> > Cc: linux-i2c@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> 
> Doesn't apply...
> 
> >    - "fsl,imx8dv-lpi2c" for LPI2C compatible with the one integrated
> > on i.MX8DV soc
> 
> ... I don't have this line in my tree.
> 

It seems to be caused by the following commit during the 4.19 RC2+.
f6eb89349078 dt-bindings: imx-lpi2c: Remove mx8dv compatible entry

> Would you maybe volunteer to maintain this driver? To prevent stuff like this
> from happening? :)

Sure, I will open an eye on this driver patches from now on.
And I will resend the patch against your tree.

Thanks

Regards
Dong Aisheng

> 
> Regards,
> 
>    Wolfram

Re: [PATCH V3 4/8] dt-bindings: i2c: i2c-imx-lpi2c: add imx8qxp compatible string

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]


> > Would you maybe volunteer to maintain this driver? To prevent stuff like this
> > from happening? :)
> 
> Sure, I will open an eye on this driver patches from now on.

Great, thank you! Can you add an entry to MAINTAINERS and send this
as a patch, too?

> And I will resend the patch against your tree.

Thanks!


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH V3 4/8] dt-bindings: i2c: i2c-imx-lpi2c: add imx8qxp compatible string

[A.s. Dong]

[...]
 
> > > Would you maybe volunteer to maintain this driver? To prevent stuff
> > > like this from happening? :)
> >
> > Sure, I will open an eye on this driver patches from now on.
> 
> Great, thank you! Can you add an entry to MAINTAINERS and send this as a
> patch, too?
> 

Got it. Thanks

Regards
Dong Aisheng

> > And I will resend the patch against your tree.
> 
> Thanks!

[PATCH V3 5/8] dt-bindings: spi: lpspi: add imx8qxp compatible string

[A.s. Dong]

Add imx8qxp compatible string

Cc: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-spi@vger.kernel.org
Cc: devicetree@vger.kernel.org
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt
index 4af1326..8d178a4 100644
--- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt
+++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt
@@ -3,6 +3,7 @@
 Required properties:
 - compatible :
   - "fsl,imx7ulp-spi" for LPSPI compatible with the one integrated on i.MX7ULP soc
+  - "fsl,imx8qxp-spi" for LPSPI compatible with the one integrated on i.MX8QXP soc
 - reg : address and length of the lpspi master registers
 - interrupts : lpspi interrupt
 - clocks : lpspi clock specifier
-- 
2.7.4

Re: [PATCH V3 5/8] dt-bindings: spi: lpspi: add imx8qxp compatible string

[Rob Herring]

On Thu, 18 Oct 2018 18:19:34 +0000, "A.s. Dong" wrote:
> Add imx8qxp compatible string
> 
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-spi@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Applied "spi: lpspi: add imx8qxp compatible string" to the spi tree

[Mark Brown]

The patch

   spi: lpspi: add imx8qxp compatible string

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 0c903aafc8529f64d24d2cd6df32f2bf16aad20b Mon Sep 17 00:00:00 2001
From: "A.s. Dong" <aisheng.dong@nxp.com>
Date: Thu, 18 Oct 2018 18:19:34 +0000
Subject: [PATCH] spi: lpspi: add imx8qxp compatible string

Add imx8qxp compatible string

Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt
index 4af132606b37..8d178a4503cf 100644
--- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt
+++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt
@@ -3,6 +3,7 @@
 Required properties:
 - compatible :
   - "fsl,imx7ulp-spi" for LPSPI compatible with the one integrated on i.MX7ULP soc
+  - "fsl,imx8qxp-spi" for LPSPI compatible with the one integrated on i.MX8QXP soc
 - reg : address and length of the lpspi master registers
 - interrupts : lpspi interrupt
 - clocks : lpspi clock specifier
-- 
2.19.0

[PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[A.s. Dong]

i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
graphic and multimedia features. This patch adds the core SoC dtsi
file support.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
v2->v3:
 * add more SoC specific compatible string to IP nodes
 * move memory node into board dts
 * change pd reg value into hex
 * add more explanation about SoC in commit message
 * add external clocks
 * remove pmu compatible string which is not supported
v1->v2:
 * mu binding usage update
 * no define for node address
 * do not use '_' for node name
 * drop 'fsl-' prefix for imx dtsi
 * no defines for unit address
 * generic node names
 * range map for 32bit register
 * separate board dts
---
 Documentation/devicetree/bindings/arm/fsl.txt |   4 +
 arch/arm64/boot/dts/freescale/imx8-ca35.dtsi  |  61 ++
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi    | 870 ++++++++++++++++++++++++++
 3 files changed, 935 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp.dtsi

diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
index 968f238..baeb1fc 100644
--- a/Documentation/devicetree/bindings/arm/fsl.txt
+++ b/Documentation/devicetree/bindings/arm/fsl.txt
@@ -119,6 +119,10 @@ i.MX6q generic board
 Required root node properties:
     - compatible = "fsl,imx6q";
 
+i.MX8QXP generic board
+Required root node properties:
+    - compatible = "fsl,imx8qxp";
+
 Freescale Vybrid Platform Device Tree Bindings
 ----------------------------------------------
 
diff --git a/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
new file mode 100644
index 0000000..c79e97a
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
@@ -0,0 +1,61 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2016 Freescale Semiconductor, Inc.
+ * Copyright 2017~2018 NXP
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
+/{
+	cpus {
+		#address-cells = <2>;
+		#size-cells = <0>;
+
+		/* We have 1 clusters with 4 Cortex-A35 cores */
+		A35_0: cpu@0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a35";
+			reg = <0x0 0x0>;
+			enable-method = "psci";
+			next-level-cache = <&A35_L2>;
+		};
+
+		A35_1: cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a35";
+			reg = <0x0 0x1>;
+			enable-method = "psci";
+			next-level-cache = <&A35_L2>;
+		};
+
+		A35_2: cpu@2 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a35";
+			reg = <0x0 0x2>;
+			enable-method = "psci";
+			next-level-cache = <&A35_L2>;
+		};
+
+		A35_3: cpu@3 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a35";
+			reg = <0x0 0x3>;
+			enable-method = "psci";
+			next-level-cache = <&A35_L2>;
+		};
+
+		A35_L2: l2-cache0 {
+			compatible = "cache";
+		};
+	};
+
+	pmu {
+		compatible = "arm,armv8-pmuv3";
+		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
+	};
+
+	psci {
+		compatible = "arm,psci-1.0";
+		method = "smc";
+	};
+};
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
new file mode 100644
index 0000000..acb4770
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -0,0 +1,870 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2016 Freescale Semiconductor, Inc.
+ * Copyright 2017-2018 NXP
+ *	Dong Aisheng <aisheng.dong@nxp.com>
+ */
+
+#include <dt-bindings/clock/imx8qxp-clock.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pinctrl/pads-imx8qxp.h>
+
+#include "imx8-ca35.dtsi"
+
+/ {
+	interrupt-parent = <&gic>;
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	aliases {
+		serial0 = &dma_lpuart0;
+		mmc0 = &usdhc1;
+		mmc1 = &usdhc2;
+		mmc2 = &usdhc3;
+	};
+
+	gic: interrupt-controller@51a00000 {
+		compatible = "arm,gic-v3";
+		reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
+		      <0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base + SGI_base) */
+		#interrupt-cells = <3>;
+		interrupt-controller;
+		interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+	};
+
+	timer {
+		compatible = "arm,armv8-timer";
+		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /* Physical Secure */
+			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, /* Physical Non-Secure */
+			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, /* Virtual */
+			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /* Hypervisor */
+	};
+
+	xtal32k: clock-xtal32k {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <32768>;
+		clock-output-names = "xtal_32KHz";
+	};
+
+	xtal24m: clock-xtal24m {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <24000000>;
+		clock-output-names = "xtal_24MHz";
+	};
+
+	scu {
+		compatible = "fsl,imx-scu";
+		mbox-names = "tx0", "tx1", "tx2", "tx3",
+			     "rx0", "rx1", "rx2", "rx3";
+		mboxes = <&lsio_mu1 0 0
+			  &lsio_mu1 0 1
+			  &lsio_mu1 0 2
+			  &lsio_mu1 0 3
+			  &lsio_mu1 1 0
+			  &lsio_mu1 1 1
+			  &lsio_mu1 1 2
+			  &lsio_mu1 1 3>;
+
+		clk: clock-controller {
+			compatible = "fsl,imx8qxp-clk";
+			#clock-cells = <1>;
+			clocks = <&xtal32k &xtal24m>;
+			clock-names = "xtal_32KHz", "xtal_24Mhz";
+		};
+
+		iomuxc: pinctrl {
+			compatible = "fsl,imx8qxp-iomuxc";
+		};
+
+		imx8qx-pm {
+			compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			pd_lsio: lsio-power-domain {
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_lsio_pwm0: lsio-pwm0@bf {
+					reg = <0xbf>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_pwm1: lsio-pwm1@c0 {
+					reg = <0xc0>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_pwm2: lsio-pwm2@c1 {
+					reg = <0xc1>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_pwm3: lsio-pwm3@c2 {
+					reg = <0xc2>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_pwm4: lsio-pwm4@c3 {
+					reg = <0xc3>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_pwm5: lsio-pwm5@c4 {
+					reg = <0xc4>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_pwm6: lsio-pwm6@c5 {
+					reg = <0xc5>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_pwm7: lsio-pwm7@c6 {
+					reg = <0xc6>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpio0: lsio-gpio0@c7 {
+					reg = <0xc7>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpio1: lsio-gpio1@c8 {
+					reg = <0xc8>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpio2: lsio-gpio2@c9 {
+					reg = <0xc9>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpio3: lsio-gpio3@ca {
+					reg = <0xca>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpio4: lsio-gpio4@cb {
+					reg = <0xcb>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpio5: lsio-gpio5@cc {
+					reg = <0xcc>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpio6: lsio-gpio6@cd {
+					reg = <0xcd>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpio7: lsio-gpio7@ce {
+					reg = <0xce>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpt0: lsio-gpt0@cf {
+					reg = <0xcf>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpt1: lsio-gpt1@d0 {
+					reg = <0xd0>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpt2: lsio-gpt2@d1 {
+					reg = <0xd1>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpt3: lsio-gpt3@d2 {
+					reg = <0xd2>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_gpt4: lsio-gpt4@d3 {
+					reg = <0xd3>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_kpp: lsio-kpp@d4 {
+					reg = <0xd4>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_flexspi0: lsio-fspi0@ed {
+					reg = <0xed>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+
+				pd_lsio_flexspi1: lsio-fspi1@ee {
+					reg = <0xee>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_lsio>;
+				};
+			};
+
+			pd_conn: connectivity-power-domain {
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_conn_sdhc0: conn-sdhc0@f8 {
+					reg = <0xf8>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_sdhc1: conn-sdhc1@f9 {
+					reg = <0xf9>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_sdhc2: conn-sdhc2@fa {
+					reg = <0xfa>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_enet0: conn-enet0@fb {
+					reg = <0xfb>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_enet1: conn-enet1@fc {
+					reg = <0xfc>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_mlb0: conn-mlb0@fd {
+					reg = <0xfd>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_usbotg0: conn-usb0@103 {
+					reg = <0x103>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_usbotg1: conn-usb1@104 {
+					reg = <0x104>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_usbotg0_phy: conn-usb0-phy@105 {
+					reg = <0x105>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_usb2: conn-usb2@106 {
+					reg = <0x106>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_usb2_phy: conn-usb2-phy@107 {
+					reg = <0x107>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_nand: conn-nand@109 {
+					reg = <0x109>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_conn>;
+				};
+
+				pd_conn_edma_ch0: conn-dma4-ch0@174 {
+					reg = <0x174>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_conn>;
+				};
+
+				pd_conn_edma_ch1: conn-dma4-ch1@175 {
+					reg = <0x175>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_conn>;
+				};
+
+				pd_conn_edma_ch2: conn-dma4-ch2@176 {
+					reg = <0x176>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_conn>;
+				};
+
+				pd_conn_edma_ch3: conn-dma4-ch3@177 {
+					reg = <0x177>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_conn>;
+				};
+
+				pd_conn_edma_ch4: conn-dma4-ch4@178 {
+					reg = <0x178>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_conn>;
+				};
+			};
+
+			pd_dma: dma-power-domain {
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_dma_lpspi0: dma-spi0@35 {
+					reg = <0x35>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpspi1: dma-spi1@36 {
+					reg = <0x36>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpspi2: dma-spi2@37 {
+					reg = <0x37>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpspi3: dma-spi3@38 {
+					reg = <0x38>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpuart0: dma-lpuart0@39 {
+					reg = <0x39>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpuart1: dma-lpuart1@3a {
+					reg = <0x3a>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpuart2: dma-lpuart2@3b {
+					reg = <0x3b>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpuart3: dma-lpuart3@3c {
+					reg = <0x3c>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpi2c0: dma-lpi2c0@60 {
+					reg = <0x60>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpi2c1: dma-lpi2c1@61 {
+					reg = <0x61>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpi2c2: dma-lpi2c2@62 {
+					reg = <0x62>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lpi2c3: dma-lpi2c3@63 {
+					reg = <0x63>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_adc0: dma-adc0@65 {
+					reg = <0x65>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_ftm0: dma-ftm0@67 {
+					reg = <0x67>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_ftm1: dma-ftm1@68 {
+					reg = <0x68>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_flexcan0: dma-flexcan0@69 {
+					reg = <0x69>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_flexcan1: dma-flexcan1@6a {
+					reg = <0x6a>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_flexcan2: dma-flexcan2@6b {
+					reg = <0x6b>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_lcd0: dma-lcd0@bb {
+					reg = <0xbb>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+
+				pd_dma_pwm0: dma-pwm0@bc {
+					reg = <0xbc>;
+					#power-domain-cells = <0>;
+					power-domains = <&pd_dma>;
+				};
+			};
+
+			pd_gpu: gpu-power-domain {
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_gpu0: gpu0@90 {
+					reg = <0x90>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_gpu>;
+					#address-cells = <1>;
+					#size-cells = <0>;
+				};
+			};
+
+			pd_vpu: vpu-power-domain@166 {
+				reg = <0x166>;
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_vpu_core: vpu-core@16f {
+					reg = <0x16f>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_vpu>;
+				};
+			};
+
+			pd_hsio: hsio-power-domain {
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_pcie: hsio-pcie-pd@98 {
+					reg = <0x98>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_hsio>;
+				};
+			};
+
+			pd_dc: dc-power-domain {
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_dc0: dc0-power-domain@20 {
+					reg = <0x20>;
+					#power-domain-cells = <0>;
+					power-domains =<&pd_dc>;
+				};
+			};
+
+			pd_mipi_dsi: mipi0-dsi-power-domain@189 {
+				reg = <0x189>;
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_mipi_pwm0: mipi0-dsi-pwm0@18a {
+					reg = <0x18a>;
+					power-domains =<&pd_mipi_dsi>;
+				};
+
+				pd_mipi_dsi_i2c0: mipi0-dsi-i2c0@18b {
+					reg = <0x18b>;
+					power-domains =<&pd_mipi_dsi>;
+				};
+
+				pd_mipi_dsi_i2c1: mipi0-dsi-i2c1@18c {
+					reg = <0x18c>;
+					power-domains =<&pd_mipi_dsi>;
+				};
+			};
+
+			pd_mipi_csi: mipi-csi0-power-domain@191 {
+				reg = <0x191>;
+				#power-domain-cells = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				pd_mipi_csi0_pwm0: mipi-csi0-pwm@192 {
+					reg = <0x192>;
+					power-domains =<&pd_mipi_csi>;
+				};
+
+				pd_mipi_csi0_i2c0: mipi-csi0-i2c@193 {
+					reg = <0x193>;
+					power-domains =<&pd_mipi_csi>;
+				};
+			};
+		};
+	};
+
+	audio_subsys: bus@59000000 {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x59000000 0x0 0x59000000 0x1000000>;
+	};
+
+	dma_subsys: bus@5a000000 {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x5a000000 0x0 0x5a000000 0x1000000>;
+
+		dma_lpuart0: serial@5a060000 {
+			compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+			reg = <0x5a060000 0x1000>;
+			interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-parent = <&gic>;
+			clocks = <&clk IMX8QXP_UART0_CLK>;
+			clock-names = "ipg";
+			status = "disabled";
+		};
+
+		dma_i2c0: i2c@5a800000 {
+			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
+			reg = <0x5a800000 0x4000>;
+			interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-parent = <&gic>;
+			clocks = <&clk IMX8QXP_I2C0_CLK>;
+			clock-names = "per";
+			assigned-clocks = <&clk IMX8QXP_I2C0_CLK>;
+			assigned-clock-rates = <24000000>;
+			power-domains = <&pd_dma_lpi2c0>;
+			status = "disabled";
+		};
+
+		dma_i2c1: i2c@5a810000 {
+			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
+			reg = <0x5a810000 0x4000>;
+			interrupts = <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-parent = <&gic>;
+			clocks = <&clk IMX8QXP_I2C1_CLK>;
+			clock-names = "per";
+			assigned-clocks = <&clk IMX8QXP_I2C1_CLK>;
+			assigned-clock-rates = <24000000>;
+			status = "disabled";
+		};
+
+		dma_i2c2: i2c@5a820000 {
+			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
+			reg = <0x5a820000 0x4000>;
+			interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-parent = <&gic>;
+			clocks = <&clk IMX8QXP_I2C2_CLK>;
+			clock-names = "per";
+			assigned-clocks = <&clk IMX8QXP_I2C2_CLK>;
+			assigned-clock-rates = <24000000>;
+			power-domains = <&pd_dma_lpi2c2>;
+			status = "disabled";
+		};
+
+		dma_i2c3: i2c@5a830000 {
+			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
+			reg = <0x5a830000 0x4000>;
+			interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-parent = <&gic>;
+			clocks = <&clk IMX8QXP_I2C3_CLK>;
+			clock-names = "per";
+			assigned-clocks = <&clk IMX8QXP_I2C3_CLK>;
+			assigned-clock-rates = <24000000>;
+			power-domains = <&pd_dma_lpi2c3>;
+			status = "disabled";
+		};
+	};
+
+	conn_subsys: bus@5b000000 {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x5b000000 0x0 0x5b000000 0x1000000>;
+
+		usdhc1: mmc@5b010000 {
+			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+			interrupt-parent = <&gic>;
+			interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
+			reg = <0x5b010000 0x10000>;
+			clocks = <&clk IMX8QXP_SDHC0_IPG_CLK>,
+				 <&clk IMX8QXP_SDHC0_CLK>,
+				 <&clk IMX8QXP_CLK_DUMMY>;
+			clock-names = "ipg", "per", "ahb";
+			assigned-clocks = <&clk IMX8QXP_SDHC0_DIV>;
+			assigned-clock-rates = <200000000>;
+			power-domains = <&pd_conn_sdhc0>;
+			status = "disabled";
+		};
+
+		usdhc2: mmc@5b020000 {
+			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+			interrupt-parent = <&gic>;
+			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
+			reg = <0x5b020000 0x10000>;
+			clocks = <&clk IMX8QXP_SDHC1_IPG_CLK>,
+				 <&clk IMX8QXP_SDHC1_CLK>,
+				 <&clk IMX8QXP_CLK_DUMMY>;
+			clock-names = "ipg", "per", "ahb";
+			assigned-clocks = <&clk IMX8QXP_SDHC1_DIV>;
+			assigned-clock-rates = <200000000>;
+			power-domains = <&pd_conn_sdhc1>;
+			fsl,tuning-start-tap = <20>;
+			fsl,tuning-step= <2>;
+			status = "disabled";
+		};
+
+		usdhc3: mmc@5b030000 {
+			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+			interrupt-parent = <&gic>;
+			interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
+			reg = <0x5b030000 0x10000>;
+			clocks = <&clk IMX8QXP_SDHC2_IPG_CLK>,
+				 <&clk IMX8QXP_SDHC2_CLK>,
+				 <&clk IMX8QXP_CLK_DUMMY>;
+			clock-names = "ipg", "per", "ahb";
+			assigned-clocks = <&clk IMX8QXP_SDHC2_DIV>;
+			assigned-clock-rates = <200000000>;
+			power-domains = <&pd_conn_sdhc2>;
+			status = "disabled";
+		};
+
+		fec1: ethernet@5b040000 {
+			compatible = "fsl,imx8qxp-fec", "fsl,imx6sx-fec";
+			reg = <0x5b040000 0x10000>;
+			interrupts = <GIC_SPI 258 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 257 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 259 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clk IMX8QXP_ENET0_IPG_CLK>, <&clk IMX8QXP_ENET0_AHB_CLK>, <&clk IMX8QXP_ENET0_TX_CLK>,
+				<&clk IMX8QXP_ENET0_PTP_CLK>;
+			clock-names = "ipg", "ahb", "enet_clk_ref", "ptp";
+			assigned-clocks = <&clk IMX8QXP_ENET0_REF_DIV>, <&clk IMX8QXP_ENET0_PTP_CLK>;
+			assigned-clock-rates = <125000000>, <125000000>;
+			fsl,num-tx-queues=<3>;
+			fsl,num-rx-queues=<3>;
+			power-domains = <&pd_conn_enet0>;
+			status = "disabled";
+		};
+
+		fec2: ethernet@5b050000 {
+			compatible = "fsl,imx8qxp-fec", "fsl,imx6sx-fec";
+			reg = <0x5b050000 0x10000>;
+			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 260 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 261 IRQ_TYPE_LEVEL_HIGH>,
+					<GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clk IMX8QXP_ENET1_IPG_CLK>, <&clk IMX8QXP_ENET1_AHB_CLK>, <&clk IMX8QXP_ENET1_TX_CLK>,
+				<&clk IMX8QXP_ENET1_PTP_CLK>;
+			clock-names = "ipg", "ahb", "enet_clk_ref", "ptp";
+			assigned-clocks = <&clk IMX8QXP_ENET1_REF_DIV>, <&clk IMX8QXP_ENET1_PTP_CLK>;
+			assigned-clock-rates = <125000000>, <125000000>;
+			fsl,num-tx-queues=<3>;
+			fsl,num-rx-queues=<3>;
+			power-domains = <&pd_conn_enet1>;
+			status = "disabled";
+		};
+	};
+
+	db_subsys: bus@5c000000 {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x5c000000 0x0 0x5c000000 0x1000000>;
+
+		ddr_pmu0: pmu@5c020000 {
+			reg = <0x5c020000 0x10000>;
+		};
+	};
+
+	lsio_subsys: bus@5d000000 {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x5d000000 0x0 0x5d000000 0x1000000>;
+
+		lsio_mu0: mailbox@5d1b0000 {
+			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+			reg = <0x5d1b0000 0x10000>;
+			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
+			#mbox-cells = <0>;
+			status = "disabled";
+		};
+
+		lsio_mu1: mailbox@5d1c0000 {
+			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+			reg = <0x5d1c0000 0x10000>;
+			interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
+			#mbox-cells = <2>;
+		};
+
+		lsio_mu3: mailbox@5d1e0000 {
+			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+			reg = <0x5d1e0000 0x10000>;
+			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
+			#mbox-cells = <0>;
+			status = "disabled";
+		};
+
+		lsio_mu4: mailbox@5d1f0000 {
+			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+			reg = <0x5d1f0000 0x10000>;
+			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
+			#mbox-cells = <0>;
+			status = "disabled";
+		};
+
+		lsio_gpio0: gpio@5d080000 {
+			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
+			reg = <0x5d080000 0x10000>;
+			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			power-domains = <&pd_lsio_gpio0>;
+		};
+
+		lsio_gpio1: gpio@5d090000 {
+			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
+			reg = <0x5d090000 0x10000>;
+			interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			power-domains = <&pd_lsio_gpio1>;
+		};
+
+		lsio_gpio2: gpio@5d0a0000 {
+			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
+			reg = <0x5d0a0000 0x10000>;
+			interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			power-domains = <&pd_lsio_gpio2>;
+		};
+
+		lsio_gpio3: gpio@5d0b0000 {
+			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
+			reg = <0x5d0b0000 0x10000>;
+			interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			power-domains = <&pd_lsio_gpio3>;
+		};
+
+		lsio_gpio4: gpio@5d0c0000 {
+			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
+			reg = <0x5d0c0000 0x10000>;
+			interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			power-domains = <&pd_lsio_gpio4>;
+		};
+
+		lsio_gpio5: gpio@5d0d0000 {
+			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
+			reg = <0x5d0d0000 0x10000>;
+			interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			power-domains = <&pd_lsio_gpio5>;
+		};
+
+		lsio_gpio6: gpio@5d0e0000 {
+			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
+			reg = <0x5d0e0000 0x10000>;
+			interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			power-domains = <&pd_lsio_gpio6>;
+		};
+
+		lsio_gpio7: gpio@5d0f0000 {
+			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
+			reg = <0x5d0f0000 0x10000>;
+			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			power-domains = <&pd_lsio_gpio7>;
+		};
+	};
+
+	hsio_subsys: bus@5f000000 {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x5f000000 0x0 0x5f000000 0x1000000>;
+	};
+};
-- 
2.7.4

Re: [PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[Rob Herring]

On Thu, Oct 18, 2018 at 06:19:39PM +0000, A.s. Dong wrote:
> i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
> graphic and multimedia features. This patch adds the core SoC dtsi
> file support.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> v2->v3:
>  * add more SoC specific compatible string to IP nodes
>  * move memory node into board dts
>  * change pd reg value into hex
>  * add more explanation about SoC in commit message
>  * add external clocks
>  * remove pmu compatible string which is not supported
> v1->v2:
>  * mu binding usage update
>  * no define for node address
>  * do not use '_' for node name
>  * drop 'fsl-' prefix for imx dtsi
>  * no defines for unit address
>  * generic node names
>  * range map for 32bit register
>  * separate board dts
> ---
>  Documentation/devicetree/bindings/arm/fsl.txt |   4 +
>  arch/arm64/boot/dts/freescale/imx8-ca35.dtsi  |  61 ++
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi    | 870 ++++++++++++++++++++++++++
>  3 files changed, 935 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
> index 968f238..baeb1fc 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.txt
> +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> @@ -119,6 +119,10 @@ i.MX6q generic board
>  Required root node properties:
>      - compatible = "fsl,imx6q";
>  
> +i.MX8QXP generic board
> +Required root node properties:
> +    - compatible = "fsl,imx8qxp";
> +
>  Freescale Vybrid Platform Device Tree Bindings
>  ----------------------------------------------
>  
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> new file mode 100644
> index 0000000..c79e97a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> @@ -0,0 +1,61 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> + * Copyright 2017~2018 NXP
> + */
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/{
> +	cpus {
> +		#address-cells = <2>;
> +		#size-cells = <0>;
> +
> +		/* We have 1 clusters with 4 Cortex-A35 cores */
> +		A35_0: cpu@0 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a35";
> +			reg = <0x0 0x0>;
> +			enable-method = "psci";
> +			next-level-cache = <&A35_L2>;
> +		};
> +
> +		A35_1: cpu@1 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a35";
> +			reg = <0x0 0x1>;
> +			enable-method = "psci";
> +			next-level-cache = <&A35_L2>;
> +		};
> +
> +		A35_2: cpu@2 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a35";
> +			reg = <0x0 0x2>;
> +			enable-method = "psci";
> +			next-level-cache = <&A35_L2>;
> +		};
> +
> +		A35_3: cpu@3 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a35";
> +			reg = <0x0 0x3>;
> +			enable-method = "psci";
> +			next-level-cache = <&A35_L2>;
> +		};
> +
> +		A35_L2: l2-cache0 {
> +			compatible = "cache";
> +		};
> +	};
> +
> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +	};
> +
> +	psci {
> +		compatible = "arm,psci-1.0";
> +		method = "smc";
> +	};
> +};
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> new file mode 100644
> index 0000000..acb4770
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -0,0 +1,870 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> + * Copyright 2017-2018 NXP
> + *	Dong Aisheng <aisheng.dong@nxp.com>
> + */
> +
> +#include <dt-bindings/clock/imx8qxp-clock.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/pads-imx8qxp.h>
> +
> +#include "imx8-ca35.dtsi"
> +
> +/ {
> +	interrupt-parent = <&gic>;
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		serial0 = &dma_lpuart0;
> +		mmc0 = &usdhc1;
> +		mmc1 = &usdhc2;
> +		mmc2 = &usdhc3;
> +	};
> +
> +	gic: interrupt-controller@51a00000 {
> +		compatible = "arm,gic-v3";
> +		reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
> +		      <0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base + SGI_base) */
> +		#interrupt-cells = <3>;
> +		interrupt-controller;
> +		interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> +	};
> +
> +	timer {
> +		compatible = "arm,armv8-timer";
> +		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /* Physical Secure */
> +			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, /* Physical Non-Secure */
> +			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, /* Virtual */
> +			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /* Hypervisor */
> +	};
> +
> +	xtal32k: clock-xtal32k {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <32768>;
> +		clock-output-names = "xtal_32KHz";
> +	};
> +
> +	xtal24m: clock-xtal24m {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal_24MHz";
> +	};
> +
> +	scu {
> +		compatible = "fsl,imx-scu";
> +		mbox-names = "tx0", "tx1", "tx2", "tx3",
> +			     "rx0", "rx1", "rx2", "rx3";
> +		mboxes = <&lsio_mu1 0 0
> +			  &lsio_mu1 0 1
> +			  &lsio_mu1 0 2
> +			  &lsio_mu1 0 3
> +			  &lsio_mu1 1 0
> +			  &lsio_mu1 1 1
> +			  &lsio_mu1 1 2
> +			  &lsio_mu1 1 3>;
> +
> +		clk: clock-controller {
> +			compatible = "fsl,imx8qxp-clk";
> +			#clock-cells = <1>;
> +			clocks = <&xtal32k &xtal24m>;
> +			clock-names = "xtal_32KHz", "xtal_24Mhz";
> +		};
> +
> +		iomuxc: pinctrl {
> +			compatible = "fsl,imx8qxp-iomuxc";
> +		};
> +
> +		imx8qx-pm {
> +			compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			pd_lsio: lsio-power-domain {
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_lsio_pwm0: lsio-pwm0@bf {
> +					reg = <0xbf>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;

Power domains are supposed to be a block that can be power gated. No 
chip design is going to put tiny PWM, GPIO, etc. blocks each in their 
own domain.

If you really want to maintain these sub domains, just use 2 
#power-domain-cells. The first cell can be the power domain and the 2nd 
cell the device ID. 

> +				};
> +
> +				pd_lsio_pwm1: lsio-pwm1@c0 {
> +					reg = <0xc0>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_pwm2: lsio-pwm2@c1 {
> +					reg = <0xc1>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_pwm3: lsio-pwm3@c2 {
> +					reg = <0xc2>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_pwm4: lsio-pwm4@c3 {
> +					reg = <0xc3>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_pwm5: lsio-pwm5@c4 {
> +					reg = <0xc4>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_pwm6: lsio-pwm6@c5 {
> +					reg = <0xc5>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_pwm7: lsio-pwm7@c6 {
> +					reg = <0xc6>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpio0: lsio-gpio0@c7 {
> +					reg = <0xc7>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpio1: lsio-gpio1@c8 {
> +					reg = <0xc8>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpio2: lsio-gpio2@c9 {
> +					reg = <0xc9>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpio3: lsio-gpio3@ca {
> +					reg = <0xca>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpio4: lsio-gpio4@cb {
> +					reg = <0xcb>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpio5: lsio-gpio5@cc {
> +					reg = <0xcc>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpio6: lsio-gpio6@cd {
> +					reg = <0xcd>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpio7: lsio-gpio7@ce {
> +					reg = <0xce>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpt0: lsio-gpt0@cf {
> +					reg = <0xcf>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpt1: lsio-gpt1@d0 {
> +					reg = <0xd0>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpt2: lsio-gpt2@d1 {
> +					reg = <0xd1>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpt3: lsio-gpt3@d2 {
> +					reg = <0xd2>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_gpt4: lsio-gpt4@d3 {
> +					reg = <0xd3>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_kpp: lsio-kpp@d4 {
> +					reg = <0xd4>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_flexspi0: lsio-fspi0@ed {
> +					reg = <0xed>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +
> +				pd_lsio_flexspi1: lsio-fspi1@ee {
> +					reg = <0xee>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_lsio>;
> +				};
> +			};
> +
> +			pd_conn: connectivity-power-domain {
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_conn_sdhc0: conn-sdhc0@f8 {
> +					reg = <0xf8>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_sdhc1: conn-sdhc1@f9 {
> +					reg = <0xf9>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_sdhc2: conn-sdhc2@fa {
> +					reg = <0xfa>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_enet0: conn-enet0@fb {
> +					reg = <0xfb>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_enet1: conn-enet1@fc {
> +					reg = <0xfc>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_mlb0: conn-mlb0@fd {
> +					reg = <0xfd>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_usbotg0: conn-usb0@103 {
> +					reg = <0x103>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_usbotg1: conn-usb1@104 {
> +					reg = <0x104>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_usbotg0_phy: conn-usb0-phy@105 {
> +					reg = <0x105>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_usb2: conn-usb2@106 {
> +					reg = <0x106>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_usb2_phy: conn-usb2-phy@107 {
> +					reg = <0x107>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_nand: conn-nand@109 {
> +					reg = <0x109>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_conn>;
> +				};
> +
> +				pd_conn_edma_ch0: conn-dma4-ch0@174 {
> +					reg = <0x174>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_conn>;
> +				};
> +
> +				pd_conn_edma_ch1: conn-dma4-ch1@175 {
> +					reg = <0x175>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_conn>;
> +				};
> +
> +				pd_conn_edma_ch2: conn-dma4-ch2@176 {
> +					reg = <0x176>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_conn>;
> +				};
> +
> +				pd_conn_edma_ch3: conn-dma4-ch3@177 {
> +					reg = <0x177>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_conn>;
> +				};
> +
> +				pd_conn_edma_ch4: conn-dma4-ch4@178 {
> +					reg = <0x178>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_conn>;
> +				};
> +			};
> +
> +			pd_dma: dma-power-domain {
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_dma_lpspi0: dma-spi0@35 {
> +					reg = <0x35>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpspi1: dma-spi1@36 {
> +					reg = <0x36>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpspi2: dma-spi2@37 {
> +					reg = <0x37>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpspi3: dma-spi3@38 {
> +					reg = <0x38>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpuart0: dma-lpuart0@39 {
> +					reg = <0x39>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpuart1: dma-lpuart1@3a {
> +					reg = <0x3a>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpuart2: dma-lpuart2@3b {
> +					reg = <0x3b>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpuart3: dma-lpuart3@3c {
> +					reg = <0x3c>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpi2c0: dma-lpi2c0@60 {
> +					reg = <0x60>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpi2c1: dma-lpi2c1@61 {
> +					reg = <0x61>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpi2c2: dma-lpi2c2@62 {
> +					reg = <0x62>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lpi2c3: dma-lpi2c3@63 {
> +					reg = <0x63>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_adc0: dma-adc0@65 {
> +					reg = <0x65>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_ftm0: dma-ftm0@67 {
> +					reg = <0x67>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_ftm1: dma-ftm1@68 {
> +					reg = <0x68>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_flexcan0: dma-flexcan0@69 {
> +					reg = <0x69>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_flexcan1: dma-flexcan1@6a {
> +					reg = <0x6a>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_flexcan2: dma-flexcan2@6b {
> +					reg = <0x6b>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_lcd0: dma-lcd0@bb {
> +					reg = <0xbb>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +
> +				pd_dma_pwm0: dma-pwm0@bc {
> +					reg = <0xbc>;
> +					#power-domain-cells = <0>;
> +					power-domains = <&pd_dma>;
> +				};
> +			};
> +
> +			pd_gpu: gpu-power-domain {
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_gpu0: gpu0@90 {
> +					reg = <0x90>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_gpu>;
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +				};
> +			};
> +
> +			pd_vpu: vpu-power-domain@166 {
> +				reg = <0x166>;
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_vpu_core: vpu-core@16f {
> +					reg = <0x16f>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_vpu>;
> +				};
> +			};
> +
> +			pd_hsio: hsio-power-domain {
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_pcie: hsio-pcie-pd@98 {
> +					reg = <0x98>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_hsio>;
> +				};
> +			};
> +
> +			pd_dc: dc-power-domain {
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_dc0: dc0-power-domain@20 {
> +					reg = <0x20>;
> +					#power-domain-cells = <0>;
> +					power-domains =<&pd_dc>;
> +				};
> +			};
> +
> +			pd_mipi_dsi: mipi0-dsi-power-domain@189 {
> +				reg = <0x189>;
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_mipi_pwm0: mipi0-dsi-pwm0@18a {
> +					reg = <0x18a>;
> +					power-domains =<&pd_mipi_dsi>;
> +				};
> +
> +				pd_mipi_dsi_i2c0: mipi0-dsi-i2c0@18b {
> +					reg = <0x18b>;
> +					power-domains =<&pd_mipi_dsi>;
> +				};
> +
> +				pd_mipi_dsi_i2c1: mipi0-dsi-i2c1@18c {
> +					reg = <0x18c>;
> +					power-domains =<&pd_mipi_dsi>;
> +				};
> +			};
> +
> +			pd_mipi_csi: mipi-csi0-power-domain@191 {
> +				reg = <0x191>;
> +				#power-domain-cells = <0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				pd_mipi_csi0_pwm0: mipi-csi0-pwm@192 {
> +					reg = <0x192>;
> +					power-domains =<&pd_mipi_csi>;
> +				};
> +
> +				pd_mipi_csi0_i2c0: mipi-csi0-i2c@193 {
> +					reg = <0x193>;
> +					power-domains =<&pd_mipi_csi>;
> +				};
> +			};
> +		};
> +	};
> +
> +	audio_subsys: bus@59000000 {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x59000000 0x0 0x59000000 0x1000000>;
> +	};
> +
> +	dma_subsys: bus@5a000000 {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x5a000000 0x0 0x5a000000 0x1000000>;

Can't you do some actual translation here.
> +
> +		dma_lpuart0: serial@5a060000 {
> +			compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> +			reg = <0x5a060000 0x1000>;
> +			interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-parent = <&gic>;
> +			clocks = <&clk IMX8QXP_UART0_CLK>;
> +			clock-names = "ipg";
> +			status = "disabled";
> +		};
> +
> +		dma_i2c0: i2c@5a800000 {
> +			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> +			reg = <0x5a800000 0x4000>;
> +			interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-parent = <&gic>;
> +			clocks = <&clk IMX8QXP_I2C0_CLK>;
> +			clock-names = "per";
> +			assigned-clocks = <&clk IMX8QXP_I2C0_CLK>;
> +			assigned-clock-rates = <24000000>;
> +			power-domains = <&pd_dma_lpi2c0>;
> +			status = "disabled";
> +		};
> +
> +		dma_i2c1: i2c@5a810000 {
> +			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> +			reg = <0x5a810000 0x4000>;
> +			interrupts = <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-parent = <&gic>;
> +			clocks = <&clk IMX8QXP_I2C1_CLK>;
> +			clock-names = "per";
> +			assigned-clocks = <&clk IMX8QXP_I2C1_CLK>;
> +			assigned-clock-rates = <24000000>;
> +			status = "disabled";
> +		};
> +
> +		dma_i2c2: i2c@5a820000 {
> +			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> +			reg = <0x5a820000 0x4000>;
> +			interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-parent = <&gic>;
> +			clocks = <&clk IMX8QXP_I2C2_CLK>;
> +			clock-names = "per";
> +			assigned-clocks = <&clk IMX8QXP_I2C2_CLK>;
> +			assigned-clock-rates = <24000000>;
> +			power-domains = <&pd_dma_lpi2c2>;
> +			status = "disabled";
> +		};
> +
> +		dma_i2c3: i2c@5a830000 {
> +			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> +			reg = <0x5a830000 0x4000>;
> +			interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-parent = <&gic>;
> +			clocks = <&clk IMX8QXP_I2C3_CLK>;
> +			clock-names = "per";
> +			assigned-clocks = <&clk IMX8QXP_I2C3_CLK>;
> +			assigned-clock-rates = <24000000>;
> +			power-domains = <&pd_dma_lpi2c3>;
> +			status = "disabled";
> +		};
> +	};
> +
> +	conn_subsys: bus@5b000000 {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x5b000000 0x0 0x5b000000 0x1000000>;
> +
> +		usdhc1: mmc@5b010000 {
> +			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> +			interrupt-parent = <&gic>;
> +			interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
> +			reg = <0x5b010000 0x10000>;
> +			clocks = <&clk IMX8QXP_SDHC0_IPG_CLK>,
> +				 <&clk IMX8QXP_SDHC0_CLK>,
> +				 <&clk IMX8QXP_CLK_DUMMY>;
> +			clock-names = "ipg", "per", "ahb";
> +			assigned-clocks = <&clk IMX8QXP_SDHC0_DIV>;
> +			assigned-clock-rates = <200000000>;
> +			power-domains = <&pd_conn_sdhc0>;
> +			status = "disabled";
> +		};
> +
> +		usdhc2: mmc@5b020000 {
> +			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> +			interrupt-parent = <&gic>;
> +			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
> +			reg = <0x5b020000 0x10000>;
> +			clocks = <&clk IMX8QXP_SDHC1_IPG_CLK>,
> +				 <&clk IMX8QXP_SDHC1_CLK>,
> +				 <&clk IMX8QXP_CLK_DUMMY>;
> +			clock-names = "ipg", "per", "ahb";
> +			assigned-clocks = <&clk IMX8QXP_SDHC1_DIV>;
> +			assigned-clock-rates = <200000000>;
> +			power-domains = <&pd_conn_sdhc1>;
> +			fsl,tuning-start-tap = <20>;
> +			fsl,tuning-step= <2>;
> +			status = "disabled";
> +		};
> +
> +		usdhc3: mmc@5b030000 {
> +			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> +			interrupt-parent = <&gic>;
> +			interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
> +			reg = <0x5b030000 0x10000>;
> +			clocks = <&clk IMX8QXP_SDHC2_IPG_CLK>,
> +				 <&clk IMX8QXP_SDHC2_CLK>,
> +				 <&clk IMX8QXP_CLK_DUMMY>;
> +			clock-names = "ipg", "per", "ahb";
> +			assigned-clocks = <&clk IMX8QXP_SDHC2_DIV>;
> +			assigned-clock-rates = <200000000>;
> +			power-domains = <&pd_conn_sdhc2>;
> +			status = "disabled";
> +		};
> +
> +		fec1: ethernet@5b040000 {
> +			compatible = "fsl,imx8qxp-fec", "fsl,imx6sx-fec";
> +			reg = <0x5b040000 0x10000>;
> +			interrupts = <GIC_SPI 258 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 257 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 259 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk IMX8QXP_ENET0_IPG_CLK>, <&clk IMX8QXP_ENET0_AHB_CLK>, <&clk IMX8QXP_ENET0_TX_CLK>,
> +				<&clk IMX8QXP_ENET0_PTP_CLK>;
> +			clock-names = "ipg", "ahb", "enet_clk_ref", "ptp";
> +			assigned-clocks = <&clk IMX8QXP_ENET0_REF_DIV>, <&clk IMX8QXP_ENET0_PTP_CLK>;
> +			assigned-clock-rates = <125000000>, <125000000>;
> +			fsl,num-tx-queues=<3>;
> +			fsl,num-rx-queues=<3>;
> +			power-domains = <&pd_conn_enet0>;
> +			status = "disabled";
> +		};
> +
> +		fec2: ethernet@5b050000 {
> +			compatible = "fsl,imx8qxp-fec", "fsl,imx6sx-fec";
> +			reg = <0x5b050000 0x10000>;
> +			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 260 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 261 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk IMX8QXP_ENET1_IPG_CLK>, <&clk IMX8QXP_ENET1_AHB_CLK>, <&clk IMX8QXP_ENET1_TX_CLK>,
> +				<&clk IMX8QXP_ENET1_PTP_CLK>;
> +			clock-names = "ipg", "ahb", "enet_clk_ref", "ptp";
> +			assigned-clocks = <&clk IMX8QXP_ENET1_REF_DIV>, <&clk IMX8QXP_ENET1_PTP_CLK>;
> +			assigned-clock-rates = <125000000>, <125000000>;
> +			fsl,num-tx-queues=<3>;
> +			fsl,num-rx-queues=<3>;
> +			power-domains = <&pd_conn_enet1>;
> +			status = "disabled";
> +		};
> +	};
> +
> +	db_subsys: bus@5c000000 {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x5c000000 0x0 0x5c000000 0x1000000>;
> +
> +		ddr_pmu0: pmu@5c020000 {
> +			reg = <0x5c020000 0x10000>;
> +		};
> +	};
> +
> +	lsio_subsys: bus@5d000000 {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x5d000000 0x0 0x5d000000 0x1000000>;
> +
> +		lsio_mu0: mailbox@5d1b0000 {
> +			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> +			reg = <0x5d1b0000 0x10000>;
> +			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> +			#mbox-cells = <0>;
> +			status = "disabled";
> +		};
> +
> +		lsio_mu1: mailbox@5d1c0000 {
> +			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> +			reg = <0x5d1c0000 0x10000>;
> +			interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
> +			#mbox-cells = <2>;
> +		};
> +
> +		lsio_mu3: mailbox@5d1e0000 {
> +			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> +			reg = <0x5d1e0000 0x10000>;
> +			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> +			#mbox-cells = <0>;
> +			status = "disabled";
> +		};
> +
> +		lsio_mu4: mailbox@5d1f0000 {
> +			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> +			reg = <0x5d1f0000 0x10000>;
> +			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> +			#mbox-cells = <0>;
> +			status = "disabled";
> +		};
> +
> +		lsio_gpio0: gpio@5d080000 {
> +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> +			reg = <0x5d080000 0x10000>;
> +			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			power-domains = <&pd_lsio_gpio0>;
> +		};
> +
> +		lsio_gpio1: gpio@5d090000 {
> +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> +			reg = <0x5d090000 0x10000>;
> +			interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			power-domains = <&pd_lsio_gpio1>;
> +		};
> +
> +		lsio_gpio2: gpio@5d0a0000 {
> +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> +			reg = <0x5d0a0000 0x10000>;
> +			interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			power-domains = <&pd_lsio_gpio2>;
> +		};
> +
> +		lsio_gpio3: gpio@5d0b0000 {
> +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> +			reg = <0x5d0b0000 0x10000>;
> +			interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			power-domains = <&pd_lsio_gpio3>;
> +		};
> +
> +		lsio_gpio4: gpio@5d0c0000 {
> +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> +			reg = <0x5d0c0000 0x10000>;
> +			interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			power-domains = <&pd_lsio_gpio4>;
> +		};
> +
> +		lsio_gpio5: gpio@5d0d0000 {
> +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> +			reg = <0x5d0d0000 0x10000>;
> +			interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			power-domains = <&pd_lsio_gpio5>;
> +		};
> +
> +		lsio_gpio6: gpio@5d0e0000 {
> +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> +			reg = <0x5d0e0000 0x10000>;
> +			interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			power-domains = <&pd_lsio_gpio6>;
> +		};
> +
> +		lsio_gpio7: gpio@5d0f0000 {
> +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> +			reg = <0x5d0f0000 0x10000>;
> +			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			power-domains = <&pd_lsio_gpio7>;
> +		};
> +	};
> +
> +	hsio_subsys: bus@5f000000 {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x5f000000 0x0 0x5f000000 0x1000000>;
> +	};
> +};
> -- 
> 2.7.4
> 

RE: [PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[A.s. Dong]

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Friday, October 19, 2018 4:25 AM
> To: A.s. Dong <aisheng.dong@nxp.com>
[...]
> On Thu, Oct 18, 2018 at 06:19:39PM +0000, A.s. Dong wrote:
> > i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
> > graphic and multimedia features. This patch adds the core SoC dtsi
> > file support.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: devicetree@vger.kernel.org
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Sascha Hauer <kernel@pengutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> > v2->v3:
> >  * add more SoC specific compatible string to IP nodes
> >  * move memory node into board dts
> >  * change pd reg value into hex
> >  * add more explanation about SoC in commit message
> >  * add external clocks
> >  * remove pmu compatible string which is not supported
> > v1->v2:
> >  * mu binding usage update
> >  * no define for node address
> >  * do not use '_' for node name
> >  * drop 'fsl-' prefix for imx dtsi
> >  * no defines for unit address
> >  * generic node names
> >  * range map for 32bit register
> >  * separate board dts
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.txt |   4 +
> >  arch/arm64/boot/dts/freescale/imx8-ca35.dtsi  |  61 ++
> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi    | 870
> ++++++++++++++++++++++++++
> >  3 files changed, 935 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.txt
> > b/Documentation/devicetree/bindings/arm/fsl.txt
> > index 968f238..baeb1fc 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.txt
> > +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> > @@ -119,6 +119,10 @@ i.MX6q generic board  Required root node
> > properties:
> >      - compatible = "fsl,imx6q";
> >
> > +i.MX8QXP generic board
> > +Required root node properties:
> > +    - compatible = "fsl,imx8qxp";
> > +
> >  Freescale Vybrid Platform Device Tree Bindings
> >  ----------------------------------------------
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> > new file mode 100644
> > index 0000000..c79e97a
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> > @@ -0,0 +1,61 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> > + * Copyright 2017~2018 NXP
> > + */
> > +
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +/{
> > +	cpus {
> > +		#address-cells = <2>;
> > +		#size-cells = <0>;
> > +
> > +		/* We have 1 clusters with 4 Cortex-A35 cores */
> > +		A35_0: cpu@0 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a35";
> > +			reg = <0x0 0x0>;
> > +			enable-method = "psci";
> > +			next-level-cache = <&A35_L2>;
> > +		};
> > +
> > +		A35_1: cpu@1 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a35";
> > +			reg = <0x0 0x1>;
> > +			enable-method = "psci";
> > +			next-level-cache = <&A35_L2>;
> > +		};
> > +
> > +		A35_2: cpu@2 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a35";
> > +			reg = <0x0 0x2>;
> > +			enable-method = "psci";
> > +			next-level-cache = <&A35_L2>;
> > +		};
> > +
> > +		A35_3: cpu@3 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a35";
> > +			reg = <0x0 0x3>;
> > +			enable-method = "psci";
> > +			next-level-cache = <&A35_L2>;
> > +		};
> > +
> > +		A35_L2: l2-cache0 {
> > +			compatible = "cache";
> > +		};
> > +	};
> > +
> > +	pmu {
> > +		compatible = "arm,armv8-pmuv3";
> > +		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > +	};
> > +
> > +	psci {
> > +		compatible = "arm,psci-1.0";
> > +		method = "smc";
> > +	};
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > new file mode 100644
> > index 0000000..acb4770
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -0,0 +1,870 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> > + * Copyright 2017-2018 NXP
> > + *	Dong Aisheng <aisheng.dong@nxp.com>
> > + */
> > +
> > +#include <dt-bindings/clock/imx8qxp-clock.h>
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/pinctrl/pads-imx8qxp.h>
> > +
> > +#include "imx8-ca35.dtsi"
> > +
> > +/ {
> > +	interrupt-parent = <&gic>;
> > +	#address-cells = <2>;
> > +	#size-cells = <2>;
> > +
> > +	aliases {
> > +		serial0 = &dma_lpuart0;
> > +		mmc0 = &usdhc1;
> > +		mmc1 = &usdhc2;
> > +		mmc2 = &usdhc3;
> > +	};
> > +
> > +	gic: interrupt-controller@51a00000 {
> > +		compatible = "arm,gic-v3";
> > +		reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
> > +		      <0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base + SGI_base)
> */
> > +		#interrupt-cells = <3>;
> > +		interrupt-controller;
> > +		interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> > +	};
> > +
> > +	timer {
> > +		compatible = "arm,armv8-timer";
> > +		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /* Physical Secure
> */
> > +			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, /* Physical
> Non-Secure */
> > +			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, /* Virtual */
> > +			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /* Hypervisor */
> > +	};
> > +
> > +	xtal32k: clock-xtal32k {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <32768>;
> > +		clock-output-names = "xtal_32KHz";
> > +	};
> > +
> > +	xtal24m: clock-xtal24m {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <24000000>;
> > +		clock-output-names = "xtal_24MHz";
> > +	};
> > +
> > +	scu {
> > +		compatible = "fsl,imx-scu";
> > +		mbox-names = "tx0", "tx1", "tx2", "tx3",
> > +			     "rx0", "rx1", "rx2", "rx3";
> > +		mboxes = <&lsio_mu1 0 0
> > +			  &lsio_mu1 0 1
> > +			  &lsio_mu1 0 2
> > +			  &lsio_mu1 0 3
> > +			  &lsio_mu1 1 0
> > +			  &lsio_mu1 1 1
> > +			  &lsio_mu1 1 2
> > +			  &lsio_mu1 1 3>;
> > +
> > +		clk: clock-controller {
> > +			compatible = "fsl,imx8qxp-clk";
> > +			#clock-cells = <1>;
> > +			clocks = <&xtal32k &xtal24m>;
> > +			clock-names = "xtal_32KHz", "xtal_24Mhz";
> > +		};
> > +
> > +		iomuxc: pinctrl {
> > +			compatible = "fsl,imx8qxp-iomuxc";
> > +		};
> > +
> > +		imx8qx-pm {
> > +			compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			pd_lsio: lsio-power-domain {
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_lsio_pwm0: lsio-pwm0@bf {
> > +					reg = <0xbf>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> 
> Power domains are supposed to be a block that can be power gated. No chip
> design is going to put tiny PWM, GPIO, etc. blocks each in their own domain.
> 
> If you really want to maintain these sub domains, just use 2
> #power-domain-cells. The first cell can be the power domain and the 2nd cell
> the device ID.
> 

Unfortunately the SCU firmware is designed like that each device has a power domain
ID which is specified in reg property in device tree.
Each driver should enable that power domain before being able to access the HW,
otherwise, xRDC (security and access control HW) may report bus errors.
And there could be different multi-level domains, how to do 2cells presentation for this case?
E.g.
Domain_A: {
	Domain_B {
		Domain_C {
			...
		}
	}
}
So make them separate power domain seems a suitable way to get things working well.
I'm not sure whether 2 cells could be suitable for our case.
Just wondering if you think this way could be accepted due to this special case?

> > +				};
> > +
> > +				pd_lsio_pwm1: lsio-pwm1@c0 {
> > +					reg = <0xc0>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_pwm2: lsio-pwm2@c1 {
> > +					reg = <0xc1>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_pwm3: lsio-pwm3@c2 {
> > +					reg = <0xc2>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_pwm4: lsio-pwm4@c3 {
> > +					reg = <0xc3>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_pwm5: lsio-pwm5@c4 {
> > +					reg = <0xc4>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_pwm6: lsio-pwm6@c5 {
> > +					reg = <0xc5>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_pwm7: lsio-pwm7@c6 {
> > +					reg = <0xc6>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpio0: lsio-gpio0@c7 {
> > +					reg = <0xc7>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpio1: lsio-gpio1@c8 {
> > +					reg = <0xc8>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpio2: lsio-gpio2@c9 {
> > +					reg = <0xc9>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpio3: lsio-gpio3@ca {
> > +					reg = <0xca>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpio4: lsio-gpio4@cb {
> > +					reg = <0xcb>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpio5: lsio-gpio5@cc {
> > +					reg = <0xcc>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpio6: lsio-gpio6@cd {
> > +					reg = <0xcd>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpio7: lsio-gpio7@ce {
> > +					reg = <0xce>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpt0: lsio-gpt0@cf {
> > +					reg = <0xcf>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpt1: lsio-gpt1@d0 {
> > +					reg = <0xd0>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpt2: lsio-gpt2@d1 {
> > +					reg = <0xd1>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpt3: lsio-gpt3@d2 {
> > +					reg = <0xd2>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_gpt4: lsio-gpt4@d3 {
> > +					reg = <0xd3>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_kpp: lsio-kpp@d4 {
> > +					reg = <0xd4>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_flexspi0: lsio-fspi0@ed {
> > +					reg = <0xed>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +
> > +				pd_lsio_flexspi1: lsio-fspi1@ee {
> > +					reg = <0xee>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_lsio>;
> > +				};
> > +			};
> > +
> > +			pd_conn: connectivity-power-domain {
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_conn_sdhc0: conn-sdhc0@f8 {
> > +					reg = <0xf8>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_sdhc1: conn-sdhc1@f9 {
> > +					reg = <0xf9>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_sdhc2: conn-sdhc2@fa {
> > +					reg = <0xfa>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_enet0: conn-enet0@fb {
> > +					reg = <0xfb>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_enet1: conn-enet1@fc {
> > +					reg = <0xfc>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_mlb0: conn-mlb0@fd {
> > +					reg = <0xfd>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_usbotg0: conn-usb0@103 {
> > +					reg = <0x103>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_usbotg1: conn-usb1@104 {
> > +					reg = <0x104>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_usbotg0_phy: conn-usb0-phy@105 {
> > +					reg = <0x105>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_usb2: conn-usb2@106 {
> > +					reg = <0x106>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_usb2_phy: conn-usb2-phy@107 {
> > +					reg = <0x107>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_nand: conn-nand@109 {
> > +					reg = <0x109>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_conn>;
> > +				};
> > +
> > +				pd_conn_edma_ch0: conn-dma4-ch0@174 {
> > +					reg = <0x174>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_conn>;
> > +				};
> > +
> > +				pd_conn_edma_ch1: conn-dma4-ch1@175 {
> > +					reg = <0x175>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_conn>;
> > +				};
> > +
> > +				pd_conn_edma_ch2: conn-dma4-ch2@176 {
> > +					reg = <0x176>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_conn>;
> > +				};
> > +
> > +				pd_conn_edma_ch3: conn-dma4-ch3@177 {
> > +					reg = <0x177>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_conn>;
> > +				};
> > +
> > +				pd_conn_edma_ch4: conn-dma4-ch4@178 {
> > +					reg = <0x178>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_conn>;
> > +				};
> > +			};
> > +
> > +			pd_dma: dma-power-domain {
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_dma_lpspi0: dma-spi0@35 {
> > +					reg = <0x35>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpspi1: dma-spi1@36 {
> > +					reg = <0x36>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpspi2: dma-spi2@37 {
> > +					reg = <0x37>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpspi3: dma-spi3@38 {
> > +					reg = <0x38>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpuart0: dma-lpuart0@39 {
> > +					reg = <0x39>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpuart1: dma-lpuart1@3a {
> > +					reg = <0x3a>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpuart2: dma-lpuart2@3b {
> > +					reg = <0x3b>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpuart3: dma-lpuart3@3c {
> > +					reg = <0x3c>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpi2c0: dma-lpi2c0@60 {
> > +					reg = <0x60>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpi2c1: dma-lpi2c1@61 {
> > +					reg = <0x61>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpi2c2: dma-lpi2c2@62 {
> > +					reg = <0x62>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lpi2c3: dma-lpi2c3@63 {
> > +					reg = <0x63>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_adc0: dma-adc0@65 {
> > +					reg = <0x65>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_ftm0: dma-ftm0@67 {
> > +					reg = <0x67>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_ftm1: dma-ftm1@68 {
> > +					reg = <0x68>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_flexcan0: dma-flexcan0@69 {
> > +					reg = <0x69>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_flexcan1: dma-flexcan1@6a {
> > +					reg = <0x6a>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_flexcan2: dma-flexcan2@6b {
> > +					reg = <0x6b>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_lcd0: dma-lcd0@bb {
> > +					reg = <0xbb>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +
> > +				pd_dma_pwm0: dma-pwm0@bc {
> > +					reg = <0xbc>;
> > +					#power-domain-cells = <0>;
> > +					power-domains = <&pd_dma>;
> > +				};
> > +			};
> > +
> > +			pd_gpu: gpu-power-domain {
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_gpu0: gpu0@90 {
> > +					reg = <0x90>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_gpu>;
> > +					#address-cells = <1>;
> > +					#size-cells = <0>;
> > +				};
> > +			};
> > +
> > +			pd_vpu: vpu-power-domain@166 {
> > +				reg = <0x166>;
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_vpu_core: vpu-core@16f {
> > +					reg = <0x16f>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_vpu>;
> > +				};
> > +			};
> > +
> > +			pd_hsio: hsio-power-domain {
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_pcie: hsio-pcie-pd@98 {
> > +					reg = <0x98>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_hsio>;
> > +				};
> > +			};
> > +
> > +			pd_dc: dc-power-domain {
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_dc0: dc0-power-domain@20 {
> > +					reg = <0x20>;
> > +					#power-domain-cells = <0>;
> > +					power-domains =<&pd_dc>;
> > +				};
> > +			};
> > +
> > +			pd_mipi_dsi: mipi0-dsi-power-domain@189 {
> > +				reg = <0x189>;
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_mipi_pwm0: mipi0-dsi-pwm0@18a {
> > +					reg = <0x18a>;
> > +					power-domains =<&pd_mipi_dsi>;
> > +				};
> > +
> > +				pd_mipi_dsi_i2c0: mipi0-dsi-i2c0@18b {
> > +					reg = <0x18b>;
> > +					power-domains =<&pd_mipi_dsi>;
> > +				};
> > +
> > +				pd_mipi_dsi_i2c1: mipi0-dsi-i2c1@18c {
> > +					reg = <0x18c>;
> > +					power-domains =<&pd_mipi_dsi>;
> > +				};
> > +			};
> > +
> > +			pd_mipi_csi: mipi-csi0-power-domain@191 {
> > +				reg = <0x191>;
> > +				#power-domain-cells = <0>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				pd_mipi_csi0_pwm0: mipi-csi0-pwm@192 {
> > +					reg = <0x192>;
> > +					power-domains =<&pd_mipi_csi>;
> > +				};
> > +
> > +				pd_mipi_csi0_i2c0: mipi-csi0-i2c@193 {
> > +					reg = <0x193>;
> > +					power-domains =<&pd_mipi_csi>;
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> > +	audio_subsys: bus@59000000 {
> > +		compatible = "simple-bus";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x59000000 0x0 0x59000000 0x1000000>;
> > +	};
> > +
> > +	dma_subsys: bus@5a000000 {
> > +		compatible = "simple-bus";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x5a000000 0x0 0x5a000000 0x1000000>;
> 
> Can't you do some actual translation here.

Can you help give an example as I'm not quite get the point?

Thanks

Regards
Dong Aisheng

> > +
> > +		dma_lpuart0: serial@5a060000 {
> > +			compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> > +			reg = <0x5a060000 0x1000>;
> > +			interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
> > +			interrupt-parent = <&gic>;
> > +			clocks = <&clk IMX8QXP_UART0_CLK>;
> > +			clock-names = "ipg";
> > +			status = "disabled";
> > +		};
> > +
> > +		dma_i2c0: i2c@5a800000 {
> > +			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> > +			reg = <0x5a800000 0x4000>;
> > +			interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
> > +			interrupt-parent = <&gic>;
> > +			clocks = <&clk IMX8QXP_I2C0_CLK>;
> > +			clock-names = "per";
> > +			assigned-clocks = <&clk IMX8QXP_I2C0_CLK>;
> > +			assigned-clock-rates = <24000000>;
> > +			power-domains = <&pd_dma_lpi2c0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		dma_i2c1: i2c@5a810000 {
> > +			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> > +			reg = <0x5a810000 0x4000>;
> > +			interrupts = <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> > +			interrupt-parent = <&gic>;
> > +			clocks = <&clk IMX8QXP_I2C1_CLK>;
> > +			clock-names = "per";
> > +			assigned-clocks = <&clk IMX8QXP_I2C1_CLK>;
> > +			assigned-clock-rates = <24000000>;
> > +			status = "disabled";
> > +		};
> > +
> > +		dma_i2c2: i2c@5a820000 {
> > +			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> > +			reg = <0x5a820000 0x4000>;
> > +			interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
> > +			interrupt-parent = <&gic>;
> > +			clocks = <&clk IMX8QXP_I2C2_CLK>;
> > +			clock-names = "per";
> > +			assigned-clocks = <&clk IMX8QXP_I2C2_CLK>;
> > +			assigned-clock-rates = <24000000>;
> > +			power-domains = <&pd_dma_lpi2c2>;
> > +			status = "disabled";
> > +		};
> > +
> > +		dma_i2c3: i2c@5a830000 {
> > +			compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> > +			reg = <0x5a830000 0x4000>;
> > +			interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
> > +			interrupt-parent = <&gic>;
> > +			clocks = <&clk IMX8QXP_I2C3_CLK>;
> > +			clock-names = "per";
> > +			assigned-clocks = <&clk IMX8QXP_I2C3_CLK>;
> > +			assigned-clock-rates = <24000000>;
> > +			power-domains = <&pd_dma_lpi2c3>;
> > +			status = "disabled";
> > +		};
> > +	};
> > +
> > +	conn_subsys: bus@5b000000 {
> > +		compatible = "simple-bus";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x5b000000 0x0 0x5b000000 0x1000000>;
> > +
> > +		usdhc1: mmc@5b010000 {
> > +			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > +			interrupt-parent = <&gic>;
> > +			interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
> > +			reg = <0x5b010000 0x10000>;
> > +			clocks = <&clk IMX8QXP_SDHC0_IPG_CLK>,
> > +				 <&clk IMX8QXP_SDHC0_CLK>,
> > +				 <&clk IMX8QXP_CLK_DUMMY>;
> > +			clock-names = "ipg", "per", "ahb";
> > +			assigned-clocks = <&clk IMX8QXP_SDHC0_DIV>;
> > +			assigned-clock-rates = <200000000>;
> > +			power-domains = <&pd_conn_sdhc0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		usdhc2: mmc@5b020000 {
> > +			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > +			interrupt-parent = <&gic>;
> > +			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
> > +			reg = <0x5b020000 0x10000>;
> > +			clocks = <&clk IMX8QXP_SDHC1_IPG_CLK>,
> > +				 <&clk IMX8QXP_SDHC1_CLK>,
> > +				 <&clk IMX8QXP_CLK_DUMMY>;
> > +			clock-names = "ipg", "per", "ahb";
> > +			assigned-clocks = <&clk IMX8QXP_SDHC1_DIV>;
> > +			assigned-clock-rates = <200000000>;
> > +			power-domains = <&pd_conn_sdhc1>;
> > +			fsl,tuning-start-tap = <20>;
> > +			fsl,tuning-step= <2>;
> > +			status = "disabled";
> > +		};
> > +
> > +		usdhc3: mmc@5b030000 {
> > +			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > +			interrupt-parent = <&gic>;
> > +			interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
> > +			reg = <0x5b030000 0x10000>;
> > +			clocks = <&clk IMX8QXP_SDHC2_IPG_CLK>,
> > +				 <&clk IMX8QXP_SDHC2_CLK>,
> > +				 <&clk IMX8QXP_CLK_DUMMY>;
> > +			clock-names = "ipg", "per", "ahb";
> > +			assigned-clocks = <&clk IMX8QXP_SDHC2_DIV>;
> > +			assigned-clock-rates = <200000000>;
> > +			power-domains = <&pd_conn_sdhc2>;
> > +			status = "disabled";
> > +		};
> > +
> > +		fec1: ethernet@5b040000 {
> > +			compatible = "fsl,imx8qxp-fec", "fsl,imx6sx-fec";
> > +			reg = <0x5b040000 0x10000>;
> > +			interrupts = <GIC_SPI 258 IRQ_TYPE_LEVEL_HIGH>,
> > +					<GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> > +					<GIC_SPI 257 IRQ_TYPE_LEVEL_HIGH>,
> > +					<GIC_SPI 259 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&clk IMX8QXP_ENET0_IPG_CLK>, <&clk
> IMX8QXP_ENET0_AHB_CLK>, <&clk IMX8QXP_ENET0_TX_CLK>,
> > +				<&clk IMX8QXP_ENET0_PTP_CLK>;
> > +			clock-names = "ipg", "ahb", "enet_clk_ref", "ptp";
> > +			assigned-clocks = <&clk IMX8QXP_ENET0_REF_DIV>, <&clk
> IMX8QXP_ENET0_PTP_CLK>;
> > +			assigned-clock-rates = <125000000>, <125000000>;
> > +			fsl,num-tx-queues=<3>;
> > +			fsl,num-rx-queues=<3>;
> > +			power-domains = <&pd_conn_enet0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		fec2: ethernet@5b050000 {
> > +			compatible = "fsl,imx8qxp-fec", "fsl,imx6sx-fec";
> > +			reg = <0x5b050000 0x10000>;
> > +			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>,
> > +					<GIC_SPI 260 IRQ_TYPE_LEVEL_HIGH>,
> > +					<GIC_SPI 261 IRQ_TYPE_LEVEL_HIGH>,
> > +					<GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&clk IMX8QXP_ENET1_IPG_CLK>, <&clk
> IMX8QXP_ENET1_AHB_CLK>, <&clk IMX8QXP_ENET1_TX_CLK>,
> > +				<&clk IMX8QXP_ENET1_PTP_CLK>;
> > +			clock-names = "ipg", "ahb", "enet_clk_ref", "ptp";
> > +			assigned-clocks = <&clk IMX8QXP_ENET1_REF_DIV>, <&clk
> IMX8QXP_ENET1_PTP_CLK>;
> > +			assigned-clock-rates = <125000000>, <125000000>;
> > +			fsl,num-tx-queues=<3>;
> > +			fsl,num-rx-queues=<3>;
> > +			power-domains = <&pd_conn_enet1>;
> > +			status = "disabled";
> > +		};
> > +	};
> > +
> > +	db_subsys: bus@5c000000 {
> > +		compatible = "simple-bus";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x5c000000 0x0 0x5c000000 0x1000000>;
> > +
> > +		ddr_pmu0: pmu@5c020000 {
> > +			reg = <0x5c020000 0x10000>;
> > +		};
> > +	};
> > +
> > +	lsio_subsys: bus@5d000000 {
> > +		compatible = "simple-bus";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x5d000000 0x0 0x5d000000 0x1000000>;
> > +
> > +		lsio_mu0: mailbox@5d1b0000 {
> > +			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> > +			reg = <0x5d1b0000 0x10000>;
> > +			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> > +			#mbox-cells = <0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		lsio_mu1: mailbox@5d1c0000 {
> > +			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> > +			reg = <0x5d1c0000 0x10000>;
> > +			interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
> > +			#mbox-cells = <2>;
> > +		};
> > +
> > +		lsio_mu3: mailbox@5d1e0000 {
> > +			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> > +			reg = <0x5d1e0000 0x10000>;
> > +			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> > +			#mbox-cells = <0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		lsio_mu4: mailbox@5d1f0000 {
> > +			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> > +			reg = <0x5d1f0000 0x10000>;
> > +			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> > +			#mbox-cells = <0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		lsio_gpio0: gpio@5d080000 {
> > +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> > +			reg = <0x5d080000 0x10000>;
> > +			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +			power-domains = <&pd_lsio_gpio0>;
> > +		};
> > +
> > +		lsio_gpio1: gpio@5d090000 {
> > +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> > +			reg = <0x5d090000 0x10000>;
> > +			interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +			power-domains = <&pd_lsio_gpio1>;
> > +		};
> > +
> > +		lsio_gpio2: gpio@5d0a0000 {
> > +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> > +			reg = <0x5d0a0000 0x10000>;
> > +			interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +			power-domains = <&pd_lsio_gpio2>;
> > +		};
> > +
> > +		lsio_gpio3: gpio@5d0b0000 {
> > +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> > +			reg = <0x5d0b0000 0x10000>;
> > +			interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +			power-domains = <&pd_lsio_gpio3>;
> > +		};
> > +
> > +		lsio_gpio4: gpio@5d0c0000 {
> > +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> > +			reg = <0x5d0c0000 0x10000>;
> > +			interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +			power-domains = <&pd_lsio_gpio4>;
> > +		};
> > +
> > +		lsio_gpio5: gpio@5d0d0000 {
> > +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> > +			reg = <0x5d0d0000 0x10000>;
> > +			interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +			power-domains = <&pd_lsio_gpio5>;
> > +		};
> > +
> > +		lsio_gpio6: gpio@5d0e0000 {
> > +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> > +			reg = <0x5d0e0000 0x10000>;
> > +			interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +			power-domains = <&pd_lsio_gpio6>;
> > +		};
> > +
> > +		lsio_gpio7: gpio@5d0f0000 {
> > +			compatible = "fsl,imx8qxp-gpio", "fsl,imx35-gpio";
> > +			reg = <0x5d0f0000 0x10000>;
> > +			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +			power-domains = <&pd_lsio_gpio7>;
> > +		};
> > +	};
> > +
> > +	hsio_subsys: bus@5f000000 {
> > +		compatible = "simple-bus";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x5f000000 0x0 0x5f000000 0x1000000>;
> > +	};
> > +};
> > --
> > 2.7.4
> >

Re: [PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[Ulf Hansson]

On 19 October 2018 at 10:02, A.s. Dong <aisheng.dong@nxp.com> wrote:
>> -----Original Message-----
>> From: Rob Herring [mailto:robh@kernel.org]
>> Sent: Friday, October 19, 2018 4:25 AM
>> To: A.s. Dong <aisheng.dong@nxp.com>
> [...]
>> On Thu, Oct 18, 2018 at 06:19:39PM +0000, A.s. Dong wrote:
>> > i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
>> > graphic and multimedia features. This patch adds the core SoC dtsi
>> > file support.
>> >
>> > Cc: Rob Herring <robh+dt@kernel.org>
>> > Cc: Mark Rutland <mark.rutland@arm.com>
>> > Cc: devicetree@vger.kernel.org
>> > Cc: Shawn Guo <shawnguo@kernel.org>
>> > Cc: Sascha Hauer <kernel@pengutronix.de>
>> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
>> > ---
>> > v2->v3:
>> >  * add more SoC specific compatible string to IP nodes
>> >  * move memory node into board dts
>> >  * change pd reg value into hex
>> >  * add more explanation about SoC in commit message
>> >  * add external clocks
>> >  * remove pmu compatible string which is not supported
>> > v1->v2:
>> >  * mu binding usage update
>> >  * no define for node address
>> >  * do not use '_' for node name
>> >  * drop 'fsl-' prefix for imx dtsi
>> >  * no defines for unit address
>> >  * generic node names
>> >  * range map for 32bit register
>> >  * separate board dts
>> > ---
>> >  Documentation/devicetree/bindings/arm/fsl.txt |   4 +
>> >  arch/arm64/boot/dts/freescale/imx8-ca35.dtsi  |  61 ++
>> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi    | 870
>> ++++++++++++++++++++++++++
>> >  3 files changed, 935 insertions(+)
>> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>> >
>> > diff --git a/Documentation/devicetree/bindings/arm/fsl.txt
>> > b/Documentation/devicetree/bindings/arm/fsl.txt
>> > index 968f238..baeb1fc 100644
>> > --- a/Documentation/devicetree/bindings/arm/fsl.txt
>> > +++ b/Documentation/devicetree/bindings/arm/fsl.txt
>> > @@ -119,6 +119,10 @@ i.MX6q generic board  Required root node
>> > properties:
>> >      - compatible = "fsl,imx6q";
>> >
>> > +i.MX8QXP generic board
>> > +Required root node properties:
>> > +    - compatible = "fsl,imx8qxp";
>> > +
>> >  Freescale Vybrid Platform Device Tree Bindings
>> >  ----------------------------------------------
>> >
>> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>> > b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>> > new file mode 100644
>> > index 0000000..c79e97a
>> > --- /dev/null
>> > +++ b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>> > @@ -0,0 +1,61 @@
>> > +// SPDX-License-Identifier: GPL-2.0+
>> > +/*
>> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
>> > + * Copyright 2017~2018 NXP
>> > + */
>> > +
>> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> > +
>> > +/{
>> > +   cpus {
>> > +           #address-cells = <2>;
>> > +           #size-cells = <0>;
>> > +
>> > +           /* We have 1 clusters with 4 Cortex-A35 cores */
>> > +           A35_0: cpu@0 {
>> > +                   device_type = "cpu";
>> > +                   compatible = "arm,cortex-a35";
>> > +                   reg = <0x0 0x0>;
>> > +                   enable-method = "psci";
>> > +                   next-level-cache = <&A35_L2>;
>> > +           };
>> > +
>> > +           A35_1: cpu@1 {
>> > +                   device_type = "cpu";
>> > +                   compatible = "arm,cortex-a35";
>> > +                   reg = <0x0 0x1>;
>> > +                   enable-method = "psci";
>> > +                   next-level-cache = <&A35_L2>;
>> > +           };
>> > +
>> > +           A35_2: cpu@2 {
>> > +                   device_type = "cpu";
>> > +                   compatible = "arm,cortex-a35";
>> > +                   reg = <0x0 0x2>;
>> > +                   enable-method = "psci";
>> > +                   next-level-cache = <&A35_L2>;
>> > +           };
>> > +
>> > +           A35_3: cpu@3 {
>> > +                   device_type = "cpu";
>> > +                   compatible = "arm,cortex-a35";
>> > +                   reg = <0x0 0x3>;
>> > +                   enable-method = "psci";
>> > +                   next-level-cache = <&A35_L2>;
>> > +           };
>> > +
>> > +           A35_L2: l2-cache0 {
>> > +                   compatible = "cache";
>> > +           };
>> > +   };
>> > +
>> > +   pmu {
>> > +           compatible = "arm,armv8-pmuv3";
>> > +           interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
>> > +   };
>> > +
>> > +   psci {
>> > +           compatible = "arm,psci-1.0";
>> > +           method = "smc";
>> > +   };
>> > +};
>> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>> > new file mode 100644
>> > index 0000000..acb4770
>> > --- /dev/null
>> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>> > @@ -0,0 +1,870 @@
>> > +// SPDX-License-Identifier: GPL-2.0+
>> > +/*
>> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
>> > + * Copyright 2017-2018 NXP
>> > + * Dong Aisheng <aisheng.dong@nxp.com>
>> > + */
>> > +
>> > +#include <dt-bindings/clock/imx8qxp-clock.h>
>> > +#include <dt-bindings/gpio/gpio.h>
>> > +#include <dt-bindings/pinctrl/pads-imx8qxp.h>
>> > +
>> > +#include "imx8-ca35.dtsi"
>> > +
>> > +/ {
>> > +   interrupt-parent = <&gic>;
>> > +   #address-cells = <2>;
>> > +   #size-cells = <2>;
>> > +
>> > +   aliases {
>> > +           serial0 = &dma_lpuart0;
>> > +           mmc0 = &usdhc1;
>> > +           mmc1 = &usdhc2;
>> > +           mmc2 = &usdhc3;
>> > +   };
>> > +
>> > +   gic: interrupt-controller@51a00000 {
>> > +           compatible = "arm,gic-v3";
>> > +           reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
>> > +                 <0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base + SGI_base)
>> */
>> > +           #interrupt-cells = <3>;
>> > +           interrupt-controller;
>> > +           interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>> > +   };
>> > +
>> > +   timer {
>> > +           compatible = "arm,armv8-timer";
>> > +           interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /* Physical Secure
>> */
>> > +                        <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, /* Physical
>> Non-Secure */
>> > +                        <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, /* Virtual */
>> > +                        <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /* Hypervisor */
>> > +   };
>> > +
>> > +   xtal32k: clock-xtal32k {
>> > +           compatible = "fixed-clock";
>> > +           #clock-cells = <0>;
>> > +           clock-frequency = <32768>;
>> > +           clock-output-names = "xtal_32KHz";
>> > +   };
>> > +
>> > +   xtal24m: clock-xtal24m {
>> > +           compatible = "fixed-clock";
>> > +           #clock-cells = <0>;
>> > +           clock-frequency = <24000000>;
>> > +           clock-output-names = "xtal_24MHz";
>> > +   };
>> > +
>> > +   scu {
>> > +           compatible = "fsl,imx-scu";
>> > +           mbox-names = "tx0", "tx1", "tx2", "tx3",
>> > +                        "rx0", "rx1", "rx2", "rx3";
>> > +           mboxes = <&lsio_mu1 0 0
>> > +                     &lsio_mu1 0 1
>> > +                     &lsio_mu1 0 2
>> > +                     &lsio_mu1 0 3
>> > +                     &lsio_mu1 1 0
>> > +                     &lsio_mu1 1 1
>> > +                     &lsio_mu1 1 2
>> > +                     &lsio_mu1 1 3>;
>> > +
>> > +           clk: clock-controller {
>> > +                   compatible = "fsl,imx8qxp-clk";
>> > +                   #clock-cells = <1>;
>> > +                   clocks = <&xtal32k &xtal24m>;
>> > +                   clock-names = "xtal_32KHz", "xtal_24Mhz";
>> > +           };
>> > +
>> > +           iomuxc: pinctrl {
>> > +                   compatible = "fsl,imx8qxp-iomuxc";
>> > +           };
>> > +
>> > +           imx8qx-pm {
>> > +                   compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
>> > +                   #address-cells = <1>;
>> > +                   #size-cells = <0>;
>> > +
>> > +                   pd_lsio: lsio-power-domain {
>> > +                           #power-domain-cells = <0>;
>> > +                           #address-cells = <1>;
>> > +                           #size-cells = <0>;
>> > +
>> > +                           pd_lsio_pwm0: lsio-pwm0@bf {
>> > +                                   reg = <0xbf>;
>> > +                                   #power-domain-cells = <0>;
>> > +                                   power-domains = <&pd_lsio>;
>>
>> Power domains are supposed to be a block that can be power gated. No chip
>> design is going to put tiny PWM, GPIO, etc. blocks each in their own domain.
>>
>> If you really want to maintain these sub domains, just use 2
>> #power-domain-cells. The first cell can be the power domain and the 2nd cell
>> the device ID.
>>
>
> Unfortunately the SCU firmware is designed like that each device has a power domain
> ID which is specified in reg property in device tree.
> Each driver should enable that power domain before being able to access the HW,
> otherwise, xRDC (security and access control HW) may report bus errors.

This is what Rob is suggesting:

pd_lsio: lsio-power-domain {
       compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
       #power-domain-cells = <2>;
}

pd_lsio_pwm0: lsio-pwm0@bf {
       power-domains = <&pd_lsio 0 0xbf>;
}

Perhaps it's even sufficient for you to use one cell, if your
power-domain provider models only one PM domain. In such case, the
below works as well:

pd_lsio: lsio-power-domain {
       compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
       #power-domain-cells = <1>;
}

pd_lsio_pwm0: lsio-pwm0@bf {
       power-domains = <&pd_lsio 0xbf>;
}

In other words, you don't need "reg".

To make this work, you also need to implement your own genpd xlate
provider function. Do notice that, of_genpd_add_provider_onecell()
already supports provider specific xlate functions. Just set it,
before calling of_genpd_add_provider_onecell().

If you would like to look at an example, see drivers/soc/tegra/powergate-bpmp.c.

> And there could be different multi-level domains, how to do 2cells presentation for this case?
> E.g.
> Domain_A: {
>         Domain_B {
>                 Domain_C {
>                         ...
>                 }
>         }
> }

To specify a master domain, we use the power-domains specifier from
within a power domain provider node. Of course it needs to use the
correct number of cells as specified by the master provider, which may
be something different that what it self uses.

Something like this:

pd_lsio_master: lsio-power-domain-master {
       compatible = "fsl,imx8qxp-scu-pd-master", "fsl,scu-pd0-master";
       #power-domain-cells = <0>;
}

pd_lsio: lsio-power-domain {
       compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
       #power-domain-cells = <1>;
       power-domains = <&pd_lsio_master>;
}

pd_lsio_pwm0: lsio-pwm0@bf {
       power-domains = <&pd_lsio 0xbf>;
}

[...]

Hope this helps!

Kind regards
Uffe

RE: [PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[A.s. Dong]

> -----Original Message-----
> From: Ulf Hansson [mailto:ulf.hansson@linaro.org]
> Sent: Tuesday, October 23, 2018 10:55 PM
[...]
> On 19 October 2018 at 10:02, A.s. Dong <aisheng.dong@nxp.com> wrote:
> >> -----Original Message-----
> >> From: Rob Herring [mailto:robh@kernel.org]
> >> Sent: Friday, October 19, 2018 4:25 AM
> >> To: A.s. Dong <aisheng.dong@nxp.com>
> > [...]
> >> On Thu, Oct 18, 2018 at 06:19:39PM +0000, A.s. Dong wrote:
> >> > i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
> >> > graphic and multimedia features. This patch adds the core SoC dtsi
> >> > file support.
> >> >
> >> > Cc: Rob Herring <robh+dt@kernel.org>
> >> > Cc: Mark Rutland <mark.rutland@arm.com>
> >> > Cc: devicetree@vger.kernel.org
> >> > Cc: Shawn Guo <shawnguo@kernel.org>
> >> > Cc: Sascha Hauer <kernel@pengutronix.de>
> >> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> >> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> >> > ---
> >> > v2->v3:
> >> >  * add more SoC specific compatible string to IP nodes
> >> >  * move memory node into board dts
> >> >  * change pd reg value into hex
> >> >  * add more explanation about SoC in commit message
> >> >  * add external clocks
> >> >  * remove pmu compatible string which is not supported
> >> > v1->v2:
> >> >  * mu binding usage update
> >> >  * no define for node address
> >> >  * do not use '_' for node name
> >> >  * drop 'fsl-' prefix for imx dtsi
> >> >  * no defines for unit address
> >> >  * generic node names
> >> >  * range map for 32bit register
> >> >  * separate board dts
> >> > ---
> >> >  Documentation/devicetree/bindings/arm/fsl.txt |   4 +
> >> >  arch/arm64/boot/dts/freescale/imx8-ca35.dtsi  |  61 ++
> >> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi    | 870
> >> ++++++++++++++++++++++++++
> >> >  3 files changed, 935 insertions(+)  create mode 100644
> >> > arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >> >
> >> > diff --git a/Documentation/devicetree/bindings/arm/fsl.txt
> >> > b/Documentation/devicetree/bindings/arm/fsl.txt
> >> > index 968f238..baeb1fc 100644
> >> > --- a/Documentation/devicetree/bindings/arm/fsl.txt
> >> > +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> >> > @@ -119,6 +119,10 @@ i.MX6q generic board  Required root node
> >> > properties:
> >> >      - compatible = "fsl,imx6q";
> >> >
> >> > +i.MX8QXP generic board
> >> > +Required root node properties:
> >> > +    - compatible = "fsl,imx8qxp";
> >> > +
> >> >  Freescale Vybrid Platform Device Tree Bindings
> >> >  ----------------------------------------------
> >> >
> >> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >> > b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >> > new file mode 100644
> >> > index 0000000..c79e97a
> >> > --- /dev/null
> >> > +++ b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >> > @@ -0,0 +1,61 @@
> >> > +// SPDX-License-Identifier: GPL-2.0+
> >> > +/*
> >> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> >> > + * Copyright 2017~2018 NXP
> >> > + */
> >> > +
> >> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> >> > +
> >> > +/{
> >> > +   cpus {
> >> > +           #address-cells = <2>;
> >> > +           #size-cells = <0>;
> >> > +
> >> > +           /* We have 1 clusters with 4 Cortex-A35 cores */
> >> > +           A35_0: cpu@0 {
> >> > +                   device_type = "cpu";
> >> > +                   compatible = "arm,cortex-a35";
> >> > +                   reg = <0x0 0x0>;
> >> > +                   enable-method = "psci";
> >> > +                   next-level-cache = <&A35_L2>;
> >> > +           };
> >> > +
> >> > +           A35_1: cpu@1 {
> >> > +                   device_type = "cpu";
> >> > +                   compatible = "arm,cortex-a35";
> >> > +                   reg = <0x0 0x1>;
> >> > +                   enable-method = "psci";
> >> > +                   next-level-cache = <&A35_L2>;
> >> > +           };
> >> > +
> >> > +           A35_2: cpu@2 {
> >> > +                   device_type = "cpu";
> >> > +                   compatible = "arm,cortex-a35";
> >> > +                   reg = <0x0 0x2>;
> >> > +                   enable-method = "psci";
> >> > +                   next-level-cache = <&A35_L2>;
> >> > +           };
> >> > +
> >> > +           A35_3: cpu@3 {
> >> > +                   device_type = "cpu";
> >> > +                   compatible = "arm,cortex-a35";
> >> > +                   reg = <0x0 0x3>;
> >> > +                   enable-method = "psci";
> >> > +                   next-level-cache = <&A35_L2>;
> >> > +           };
> >> > +
> >> > +           A35_L2: l2-cache0 {
> >> > +                   compatible = "cache";
> >> > +           };
> >> > +   };
> >> > +
> >> > +   pmu {
> >> > +           compatible = "arm,armv8-pmuv3";
> >> > +           interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> >> > +   };
> >> > +
> >> > +   psci {
> >> > +           compatible = "arm,psci-1.0";
> >> > +           method = "smc";
> >> > +   };
> >> > +};
> >> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >> > new file mode 100644
> >> > index 0000000..acb4770
> >> > --- /dev/null
> >> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >> > @@ -0,0 +1,870 @@
> >> > +// SPDX-License-Identifier: GPL-2.0+
> >> > +/*
> >> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> >> > + * Copyright 2017-2018 NXP
> >> > + * Dong Aisheng <aisheng.dong@nxp.com>  */
> >> > +
> >> > +#include <dt-bindings/clock/imx8qxp-clock.h>
> >> > +#include <dt-bindings/gpio/gpio.h> #include
> >> > +<dt-bindings/pinctrl/pads-imx8qxp.h>
> >> > +
> >> > +#include "imx8-ca35.dtsi"
> >> > +
> >> > +/ {
> >> > +   interrupt-parent = <&gic>;
> >> > +   #address-cells = <2>;
> >> > +   #size-cells = <2>;
> >> > +
> >> > +   aliases {
> >> > +           serial0 = &dma_lpuart0;
> >> > +           mmc0 = &usdhc1;
> >> > +           mmc1 = &usdhc2;
> >> > +           mmc2 = &usdhc3;
> >> > +   };
> >> > +
> >> > +   gic: interrupt-controller@51a00000 {
> >> > +           compatible = "arm,gic-v3";
> >> > +           reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
> >> > +                 <0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base +
> >> > + SGI_base)
> >> */
> >> > +           #interrupt-cells = <3>;
> >> > +           interrupt-controller;
> >> > +           interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> >> > +   };
> >> > +
> >> > +   timer {
> >> > +           compatible = "arm,armv8-timer";
> >> > +           interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /*
> >> > + Physical Secure
> >> */
> >> > +                        <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, /*
> >> > + Physical
> >> Non-Secure */
> >> > +                        <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, /*
> Virtual */
> >> > +                        <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /*
> Hypervisor */
> >> > +   };
> >> > +
> >> > +   xtal32k: clock-xtal32k {
> >> > +           compatible = "fixed-clock";
> >> > +           #clock-cells = <0>;
> >> > +           clock-frequency = <32768>;
> >> > +           clock-output-names = "xtal_32KHz";
> >> > +   };
> >> > +
> >> > +   xtal24m: clock-xtal24m {
> >> > +           compatible = "fixed-clock";
> >> > +           #clock-cells = <0>;
> >> > +           clock-frequency = <24000000>;
> >> > +           clock-output-names = "xtal_24MHz";
> >> > +   };
> >> > +
> >> > +   scu {
> >> > +           compatible = "fsl,imx-scu";
> >> > +           mbox-names = "tx0", "tx1", "tx2", "tx3",
> >> > +                        "rx0", "rx1", "rx2", "rx3";
> >> > +           mboxes = <&lsio_mu1 0 0
> >> > +                     &lsio_mu1 0 1
> >> > +                     &lsio_mu1 0 2
> >> > +                     &lsio_mu1 0 3
> >> > +                     &lsio_mu1 1 0
> >> > +                     &lsio_mu1 1 1
> >> > +                     &lsio_mu1 1 2
> >> > +                     &lsio_mu1 1 3>;
> >> > +
> >> > +           clk: clock-controller {
> >> > +                   compatible = "fsl,imx8qxp-clk";
> >> > +                   #clock-cells = <1>;
> >> > +                   clocks = <&xtal32k &xtal24m>;
> >> > +                   clock-names = "xtal_32KHz", "xtal_24Mhz";
> >> > +           };
> >> > +
> >> > +           iomuxc: pinctrl {
> >> > +                   compatible = "fsl,imx8qxp-iomuxc";
> >> > +           };
> >> > +
> >> > +           imx8qx-pm {
> >> > +                   compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
> >> > +                   #address-cells = <1>;
> >> > +                   #size-cells = <0>;
> >> > +
> >> > +                   pd_lsio: lsio-power-domain {
> >> > +                           #power-domain-cells = <0>;
> >> > +                           #address-cells = <1>;
> >> > +                           #size-cells = <0>;
> >> > +
> >> > +                           pd_lsio_pwm0: lsio-pwm0@bf {
> >> > +                                   reg = <0xbf>;
> >> > +                                   #power-domain-cells = <0>;
> >> > +                                   power-domains = <&pd_lsio>;
> >>
> >> Power domains are supposed to be a block that can be power gated. No
> >> chip design is going to put tiny PWM, GPIO, etc. blocks each in their own
> domain.
> >>
> >> If you really want to maintain these sub domains, just use 2
> >> #power-domain-cells. The first cell can be the power domain and the
> >> 2nd cell the device ID.
> >>
> >
> > Unfortunately the SCU firmware is designed like that each device has a
> > power domain ID which is specified in reg property in device tree.
> > Each driver should enable that power domain before being able to
> > access the HW, otherwise, xRDC (security and access control HW) may report
> bus errors.
> 
> This is what Rob is suggesting:
> 

Thanks for the example

> pd_lsio: lsio-power-domain {
>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
>        #power-domain-cells = <2>;
> }
> 
> pd_lsio_pwm0: lsio-pwm0@bf {
>        power-domains = <&pd_lsio 0 0xbf>; }
> 

What does 0 (cell 1) represent?

> Perhaps it's even sufficient for you to use one cell, if your power-domain
> provider models only one PM domain. In such case, the below works as well:
> 
> pd_lsio: lsio-power-domain {
>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
>        #power-domain-cells = <1>;
> }
> 
> pd_lsio_pwm0: lsio-pwm0@bf {
>        power-domains = <&pd_lsio 0xbf>;
> }
> 
> In other words, you don't need "reg".

Will compiler complain a warning if missing "reg" property as we already have
the unit-address?

> 
> To make this work, you also need to implement your own genpd xlate provider
> function. Do notice that, of_genpd_add_provider_onecell() already supports
> provider specific xlate functions. Just set it, before calling
> of_genpd_add_provider_onecell().
> 
> If you would like to look at an example, see
> drivers/soc/tegra/powergate-bpmp.c.
>

Will study. Thanks for the sharing.
 
> > And there could be different multi-level domains, how to do 2cells
> presentation for this case?
> > E.g.
> > Domain_A: {
> >         Domain_B {
> >                 Domain_C {
> >                         ...
> >                 }
> >         }
> > }
> 
> To specify a master domain, we use the power-domains specifier from within a
> power domain provider node. Of course it needs to use the correct number of
> cells as specified by the master provider, which may be something different
> that what it self uses.
> 
> Something like this:
> 
> pd_lsio_master: lsio-power-domain-master {
>        compatible = "fsl,imx8qxp-scu-pd-master", "fsl,scu-pd0-master";

Introduced two new compatible string?

>        #power-domain-cells = <0>;
> }
> 
> pd_lsio: lsio-power-domain {
>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
>        #power-domain-cells = <1>;
>        power-domains = <&pd_lsio_master>; }
> 
> pd_lsio_pwm0: lsio-pwm0@bf {
>        power-domains = <&pd_lsio 0xbf>;
> }
> 

Overally I'm still not quite understand this new approach, may need some more
time to digest.

A simple question is: Do we lose the power domain tree hierarchy?
The original tree view seems like more straightforward. Not sure why need
to do like that.

And overally this new approach seems much more complicated than the old one
due to we have to handle the special multilevel power domains.

I'm a bit confusing whether it's worthy to switch to this new complicated
one and what's real advantage we can get comparing to the old simple way?
I will spend more time to research.
Hopefully Rob and You can help clarify a bit more to help the understanding.

Regards
Dong Aisheng

> [...]
> 
> Hope this helps!
> 
> Kind regards
> Uffe

Re: [PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[Ulf Hansson]

On 23 October 2018 at 18:09, A.s. Dong <aisheng.dong@nxp.com> wrote:
>> -----Original Message-----
>> From: Ulf Hansson [mailto:ulf.hansson@linaro.org]
>> Sent: Tuesday, October 23, 2018 10:55 PM
> [...]
>> On 19 October 2018 at 10:02, A.s. Dong <aisheng.dong@nxp.com> wrote:
>> >> -----Original Message-----
>> >> From: Rob Herring [mailto:robh@kernel.org]
>> >> Sent: Friday, October 19, 2018 4:25 AM
>> >> To: A.s. Dong <aisheng.dong@nxp.com>
>> > [...]
>> >> On Thu, Oct 18, 2018 at 06:19:39PM +0000, A.s. Dong wrote:
>> >> > i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
>> >> > graphic and multimedia features. This patch adds the core SoC dtsi
>> >> > file support.
>> >> >
>> >> > Cc: Rob Herring <robh+dt@kernel.org>
>> >> > Cc: Mark Rutland <mark.rutland@arm.com>
>> >> > Cc: devicetree@vger.kernel.org
>> >> > Cc: Shawn Guo <shawnguo@kernel.org>
>> >> > Cc: Sascha Hauer <kernel@pengutronix.de>
>> >> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> >> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
>> >> > ---
>> >> > v2->v3:
>> >> >  * add more SoC specific compatible string to IP nodes
>> >> >  * move memory node into board dts
>> >> >  * change pd reg value into hex
>> >> >  * add more explanation about SoC in commit message
>> >> >  * add external clocks
>> >> >  * remove pmu compatible string which is not supported
>> >> > v1->v2:
>> >> >  * mu binding usage update
>> >> >  * no define for node address
>> >> >  * do not use '_' for node name
>> >> >  * drop 'fsl-' prefix for imx dtsi
>> >> >  * no defines for unit address
>> >> >  * generic node names
>> >> >  * range map for 32bit register
>> >> >  * separate board dts
>> >> > ---
>> >> >  Documentation/devicetree/bindings/arm/fsl.txt |   4 +
>> >> >  arch/arm64/boot/dts/freescale/imx8-ca35.dtsi  |  61 ++
>> >> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi    | 870
>> >> ++++++++++++++++++++++++++
>> >> >  3 files changed, 935 insertions(+)  create mode 100644
>> >> > arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>> >> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>> >> >
>> >> > diff --git a/Documentation/devicetree/bindings/arm/fsl.txt
>> >> > b/Documentation/devicetree/bindings/arm/fsl.txt
>> >> > index 968f238..baeb1fc 100644
>> >> > --- a/Documentation/devicetree/bindings/arm/fsl.txt
>> >> > +++ b/Documentation/devicetree/bindings/arm/fsl.txt
>> >> > @@ -119,6 +119,10 @@ i.MX6q generic board  Required root node
>> >> > properties:
>> >> >      - compatible = "fsl,imx6q";
>> >> >
>> >> > +i.MX8QXP generic board
>> >> > +Required root node properties:
>> >> > +    - compatible = "fsl,imx8qxp";
>> >> > +
>> >> >  Freescale Vybrid Platform Device Tree Bindings
>> >> >  ----------------------------------------------
>> >> >
>> >> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>> >> > b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>> >> > new file mode 100644
>> >> > index 0000000..c79e97a
>> >> > --- /dev/null
>> >> > +++ b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
>> >> > @@ -0,0 +1,61 @@
>> >> > +// SPDX-License-Identifier: GPL-2.0+
>> >> > +/*
>> >> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
>> >> > + * Copyright 2017~2018 NXP
>> >> > + */
>> >> > +
>> >> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> >> > +
>> >> > +/{
>> >> > +   cpus {
>> >> > +           #address-cells = <2>;
>> >> > +           #size-cells = <0>;
>> >> > +
>> >> > +           /* We have 1 clusters with 4 Cortex-A35 cores */
>> >> > +           A35_0: cpu@0 {
>> >> > +                   device_type = "cpu";
>> >> > +                   compatible = "arm,cortex-a35";
>> >> > +                   reg = <0x0 0x0>;
>> >> > +                   enable-method = "psci";
>> >> > +                   next-level-cache = <&A35_L2>;
>> >> > +           };
>> >> > +
>> >> > +           A35_1: cpu@1 {
>> >> > +                   device_type = "cpu";
>> >> > +                   compatible = "arm,cortex-a35";
>> >> > +                   reg = <0x0 0x1>;
>> >> > +                   enable-method = "psci";
>> >> > +                   next-level-cache = <&A35_L2>;
>> >> > +           };
>> >> > +
>> >> > +           A35_2: cpu@2 {
>> >> > +                   device_type = "cpu";
>> >> > +                   compatible = "arm,cortex-a35";
>> >> > +                   reg = <0x0 0x2>;
>> >> > +                   enable-method = "psci";
>> >> > +                   next-level-cache = <&A35_L2>;
>> >> > +           };
>> >> > +
>> >> > +           A35_3: cpu@3 {
>> >> > +                   device_type = "cpu";
>> >> > +                   compatible = "arm,cortex-a35";
>> >> > +                   reg = <0x0 0x3>;
>> >> > +                   enable-method = "psci";
>> >> > +                   next-level-cache = <&A35_L2>;
>> >> > +           };
>> >> > +
>> >> > +           A35_L2: l2-cache0 {
>> >> > +                   compatible = "cache";
>> >> > +           };
>> >> > +   };
>> >> > +
>> >> > +   pmu {
>> >> > +           compatible = "arm,armv8-pmuv3";
>> >> > +           interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
>> >> > +   };
>> >> > +
>> >> > +   psci {
>> >> > +           compatible = "arm,psci-1.0";
>> >> > +           method = "smc";
>> >> > +   };
>> >> > +};
>> >> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>> >> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>> >> > new file mode 100644
>> >> > index 0000000..acb4770
>> >> > --- /dev/null
>> >> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>> >> > @@ -0,0 +1,870 @@
>> >> > +// SPDX-License-Identifier: GPL-2.0+
>> >> > +/*
>> >> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
>> >> > + * Copyright 2017-2018 NXP
>> >> > + * Dong Aisheng <aisheng.dong@nxp.com>  */
>> >> > +
>> >> > +#include <dt-bindings/clock/imx8qxp-clock.h>
>> >> > +#include <dt-bindings/gpio/gpio.h> #include
>> >> > +<dt-bindings/pinctrl/pads-imx8qxp.h>
>> >> > +
>> >> > +#include "imx8-ca35.dtsi"
>> >> > +
>> >> > +/ {
>> >> > +   interrupt-parent = <&gic>;
>> >> > +   #address-cells = <2>;
>> >> > +   #size-cells = <2>;
>> >> > +
>> >> > +   aliases {
>> >> > +           serial0 = &dma_lpuart0;
>> >> > +           mmc0 = &usdhc1;
>> >> > +           mmc1 = &usdhc2;
>> >> > +           mmc2 = &usdhc3;
>> >> > +   };
>> >> > +
>> >> > +   gic: interrupt-controller@51a00000 {
>> >> > +           compatible = "arm,gic-v3";
>> >> > +           reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
>> >> > +                 <0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base +
>> >> > + SGI_base)
>> >> */
>> >> > +           #interrupt-cells = <3>;
>> >> > +           interrupt-controller;
>> >> > +           interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>> >> > +   };
>> >> > +
>> >> > +   timer {
>> >> > +           compatible = "arm,armv8-timer";
>> >> > +           interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /*
>> >> > + Physical Secure
>> >> */
>> >> > +                        <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, /*
>> >> > + Physical
>> >> Non-Secure */
>> >> > +                        <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, /*
>> Virtual */
>> >> > +                        <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /*
>> Hypervisor */
>> >> > +   };
>> >> > +
>> >> > +   xtal32k: clock-xtal32k {
>> >> > +           compatible = "fixed-clock";
>> >> > +           #clock-cells = <0>;
>> >> > +           clock-frequency = <32768>;
>> >> > +           clock-output-names = "xtal_32KHz";
>> >> > +   };
>> >> > +
>> >> > +   xtal24m: clock-xtal24m {
>> >> > +           compatible = "fixed-clock";
>> >> > +           #clock-cells = <0>;
>> >> > +           clock-frequency = <24000000>;
>> >> > +           clock-output-names = "xtal_24MHz";
>> >> > +   };
>> >> > +
>> >> > +   scu {
>> >> > +           compatible = "fsl,imx-scu";
>> >> > +           mbox-names = "tx0", "tx1", "tx2", "tx3",
>> >> > +                        "rx0", "rx1", "rx2", "rx3";
>> >> > +           mboxes = <&lsio_mu1 0 0
>> >> > +                     &lsio_mu1 0 1
>> >> > +                     &lsio_mu1 0 2
>> >> > +                     &lsio_mu1 0 3
>> >> > +                     &lsio_mu1 1 0
>> >> > +                     &lsio_mu1 1 1
>> >> > +                     &lsio_mu1 1 2
>> >> > +                     &lsio_mu1 1 3>;
>> >> > +
>> >> > +           clk: clock-controller {
>> >> > +                   compatible = "fsl,imx8qxp-clk";
>> >> > +                   #clock-cells = <1>;
>> >> > +                   clocks = <&xtal32k &xtal24m>;
>> >> > +                   clock-names = "xtal_32KHz", "xtal_24Mhz";
>> >> > +           };
>> >> > +
>> >> > +           iomuxc: pinctrl {
>> >> > +                   compatible = "fsl,imx8qxp-iomuxc";
>> >> > +           };
>> >> > +
>> >> > +           imx8qx-pm {
>> >> > +                   compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
>> >> > +                   #address-cells = <1>;
>> >> > +                   #size-cells = <0>;
>> >> > +
>> >> > +                   pd_lsio: lsio-power-domain {
>> >> > +                           #power-domain-cells = <0>;
>> >> > +                           #address-cells = <1>;
>> >> > +                           #size-cells = <0>;
>> >> > +
>> >> > +                           pd_lsio_pwm0: lsio-pwm0@bf {
>> >> > +                                   reg = <0xbf>;
>> >> > +                                   #power-domain-cells = <0>;
>> >> > +                                   power-domains = <&pd_lsio>;
>> >>
>> >> Power domains are supposed to be a block that can be power gated. No
>> >> chip design is going to put tiny PWM, GPIO, etc. blocks each in their own
>> domain.
>> >>
>> >> If you really want to maintain these sub domains, just use 2
>> >> #power-domain-cells. The first cell can be the power domain and the
>> >> 2nd cell the device ID.
>> >>
>> >
>> > Unfortunately the SCU firmware is designed like that each device has a
>> > power domain ID which is specified in reg property in device tree.
>> > Each driver should enable that power domain before being able to
>> > access the HW, otherwise, xRDC (security and access control HW) may report
>> bus errors.
>>
>> This is what Rob is suggesting:
>>
>
> Thanks for the example
>
>> pd_lsio: lsio-power-domain {
>>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
>>        #power-domain-cells = <2>;
>> }
>>
>> pd_lsio_pwm0: lsio-pwm0@bf {
>>        power-domains = <&pd_lsio 0 0xbf>; }
>>
>
> What does 0 (cell 1) represent?

The index to the power domain, which is useful in case your power
domain provider manages multiple PM domains.

>
>> Perhaps it's even sufficient for you to use one cell, if your power-domain
>> provider models only one PM domain. In such case, the below works as well:
>>
>> pd_lsio: lsio-power-domain {
>>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
>>        #power-domain-cells = <1>;
>> }
>>
>> pd_lsio_pwm0: lsio-pwm0@bf {
>>        power-domains = <&pd_lsio 0xbf>;
>> }
>>
>> In other words, you don't need "reg".
>
> Will compiler complain a warning if missing "reg" property as we already have
> the unit-address?

Not sure.

The above was more meant as an example, in principle any device node
that is part of the pd_lsio PM domain, should be able to specify the
"id" through one of the power-domain cells, rather than making itself
being a power domain provider and thus using "reg". That is my main
point.

>
>>
>> To make this work, you also need to implement your own genpd xlate provider
>> function. Do notice that, of_genpd_add_provider_onecell() already supports
>> provider specific xlate functions. Just set it, before calling
>> of_genpd_add_provider_onecell().
>>
>> If you would like to look at an example, see
>> drivers/soc/tegra/powergate-bpmp.c.
>>
>
> Will study. Thanks for the sharing.
>
>> > And there could be different multi-level domains, how to do 2cells
>> presentation for this case?
>> > E.g.
>> > Domain_A: {
>> >         Domain_B {
>> >                 Domain_C {
>> >                         ...
>> >                 }
>> >         }
>> > }
>>
>> To specify a master domain, we use the power-domains specifier from within a
>> power domain provider node. Of course it needs to use the correct number of
>> cells as specified by the master provider, which may be something different
>> that what it self uses.
>>
>> Something like this:
>>
>> pd_lsio_master: lsio-power-domain-master {
>>        compatible = "fsl,imx8qxp-scu-pd-master", "fsl,scu-pd0-master";
>
> Introduced two new compatible string?

Because I considered this a completely separate power-domain provider.
Again, it was just an example.

>
>>        #power-domain-cells = <0>;
>> }
>>
>> pd_lsio: lsio-power-domain {
>>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
>>        #power-domain-cells = <1>;
>>        power-domains = <&pd_lsio_master>; }
>>
>> pd_lsio_pwm0: lsio-pwm0@bf {
>>        power-domains = <&pd_lsio 0xbf>;
>> }
>>
>
> Overally I'm still not quite understand this new approach, may need some more
> time to digest.
>
> A simple question is: Do we lose the power domain tree hierarchy?

Nope, at least not to my understanding.

> The original tree view seems like more straightforward. Not sure why need
> to do like that.
>
> And overally this new approach seems much more complicated than the old one
> due to we have to handle the special multilevel power domains.
>
> I'm a bit confusing whether it's worthy to switch to this new complicated
> one and what's real advantage we can get comparing to the old simple way?

The old simple way? :-) I think you are misinterpreting it, to me it's
the other way around.

The representation that Rob suggested, does not only model the HW more
accurately, but should also becomes more simple.

In regards to model the HW correctly. I don't believe your HW topology
have each PWM block, GPIO block, etc, in their own gate-able power
domain, right? Or is it so?

Kind regards
Uffe

RE: [PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[A.s. Dong]

> -----Original Message-----
> From: Ulf Hansson [mailto:ulf.hansson@linaro.org]
> Sent: Wednesday, October 24, 2018 6:04 PM
[...]
> On 23 October 2018 at 18:09, A.s. Dong <aisheng.dong@nxp.com> wrote:
> >> -----Original Message-----
> >> From: Ulf Hansson [mailto:ulf.hansson@linaro.org]
> >> Sent: Tuesday, October 23, 2018 10:55 PM
> > [...]
> >> On 19 October 2018 at 10:02, A.s. Dong <aisheng.dong@nxp.com> wrote:
> >> >> -----Original Message-----
> >> >> From: Rob Herring [mailto:robh@kernel.org]
> >> >> Sent: Friday, October 19, 2018 4:25 AM
> >> >> To: A.s. Dong <aisheng.dong@nxp.com>
> >> > [...]
> >> >> On Thu, Oct 18, 2018 at 06:19:39PM +0000, A.s. Dong wrote:
> >> >> > i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with
> >> >> > powerful graphic and multimedia features. This patch adds the
> >> >> > core SoC dtsi file support.
> >> >> >
> >> >> > Cc: Rob Herring <robh+dt@kernel.org>
> >> >> > Cc: Mark Rutland <mark.rutland@arm.com>
> >> >> > Cc: devicetree@vger.kernel.org
> >> >> > Cc: Shawn Guo <shawnguo@kernel.org>
> >> >> > Cc: Sascha Hauer <kernel@pengutronix.de>
> >> >> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> >> >> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> >> >> > ---
> >> >> > v2->v3:
> >> >> >  * add more SoC specific compatible string to IP nodes
> >> >> >  * move memory node into board dts
> >> >> >  * change pd reg value into hex
> >> >> >  * add more explanation about SoC in commit message
> >> >> >  * add external clocks
> >> >> >  * remove pmu compatible string which is not supported
> >> >> > v1->v2:
> >> >> >  * mu binding usage update
> >> >> >  * no define for node address
> >> >> >  * do not use '_' for node name
> >> >> >  * drop 'fsl-' prefix for imx dtsi
> >> >> >  * no defines for unit address
> >> >> >  * generic node names
> >> >> >  * range map for 32bit register
> >> >> >  * separate board dts
> >> >> > ---
> >> >> >  Documentation/devicetree/bindings/arm/fsl.txt |   4 +
> >> >> >  arch/arm64/boot/dts/freescale/imx8-ca35.dtsi  |  61 ++
> >> >> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi    | 870
> >> >> ++++++++++++++++++++++++++
> >> >> >  3 files changed, 935 insertions(+)  create mode 100644
> >> >> > arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >> >> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >> >> >
> >> >> > diff --git a/Documentation/devicetree/bindings/arm/fsl.txt
> >> >> > b/Documentation/devicetree/bindings/arm/fsl.txt
> >> >> > index 968f238..baeb1fc 100644
> >> >> > --- a/Documentation/devicetree/bindings/arm/fsl.txt
> >> >> > +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> >> >> > @@ -119,6 +119,10 @@ i.MX6q generic board  Required root node
> >> >> > properties:
> >> >> >      - compatible = "fsl,imx6q";
> >> >> >
> >> >> > +i.MX8QXP generic board
> >> >> > +Required root node properties:
> >> >> > +    - compatible = "fsl,imx8qxp";
> >> >> > +
> >> >> >  Freescale Vybrid Platform Device Tree Bindings
> >> >> >  ----------------------------------------------
> >> >> >
> >> >> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >> >> > b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >> >> > new file mode 100644
> >> >> > index 0000000..c79e97a
> >> >> > --- /dev/null
> >> >> > +++ b/arch/arm64/boot/dts/freescale/imx8-ca35.dtsi
> >> >> > @@ -0,0 +1,61 @@
> >> >> > +// SPDX-License-Identifier: GPL-2.0+
> >> >> > +/*
> >> >> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> >> >> > + * Copyright 2017~2018 NXP
> >> >> > + */
> >> >> > +
> >> >> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> >> >> > +
> >> >> > +/{
> >> >> > +   cpus {
> >> >> > +           #address-cells = <2>;
> >> >> > +           #size-cells = <0>;
> >> >> > +
> >> >> > +           /* We have 1 clusters with 4 Cortex-A35 cores */
> >> >> > +           A35_0: cpu@0 {
> >> >> > +                   device_type = "cpu";
> >> >> > +                   compatible = "arm,cortex-a35";
> >> >> > +                   reg = <0x0 0x0>;
> >> >> > +                   enable-method = "psci";
> >> >> > +                   next-level-cache = <&A35_L2>;
> >> >> > +           };
> >> >> > +
> >> >> > +           A35_1: cpu@1 {
> >> >> > +                   device_type = "cpu";
> >> >> > +                   compatible = "arm,cortex-a35";
> >> >> > +                   reg = <0x0 0x1>;
> >> >> > +                   enable-method = "psci";
> >> >> > +                   next-level-cache = <&A35_L2>;
> >> >> > +           };
> >> >> > +
> >> >> > +           A35_2: cpu@2 {
> >> >> > +                   device_type = "cpu";
> >> >> > +                   compatible = "arm,cortex-a35";
> >> >> > +                   reg = <0x0 0x2>;
> >> >> > +                   enable-method = "psci";
> >> >> > +                   next-level-cache = <&A35_L2>;
> >> >> > +           };
> >> >> > +
> >> >> > +           A35_3: cpu@3 {
> >> >> > +                   device_type = "cpu";
> >> >> > +                   compatible = "arm,cortex-a35";
> >> >> > +                   reg = <0x0 0x3>;
> >> >> > +                   enable-method = "psci";
> >> >> > +                   next-level-cache = <&A35_L2>;
> >> >> > +           };
> >> >> > +
> >> >> > +           A35_L2: l2-cache0 {
> >> >> > +                   compatible = "cache";
> >> >> > +           };
> >> >> > +   };
> >> >> > +
> >> >> > +   pmu {
> >> >> > +           compatible = "arm,armv8-pmuv3";
> >> >> > +           interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> >> >> > +   };
> >> >> > +
> >> >> > +   psci {
> >> >> > +           compatible = "arm,psci-1.0";
> >> >> > +           method = "smc";
> >> >> > +   };
> >> >> > +};
> >> >> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >> >> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >> >> > new file mode 100644
> >> >> > index 0000000..acb4770
> >> >> > --- /dev/null
> >> >> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> >> >> > @@ -0,0 +1,870 @@
> >> >> > +// SPDX-License-Identifier: GPL-2.0+
> >> >> > +/*
> >> >> > + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> >> >> > + * Copyright 2017-2018 NXP
> >> >> > + * Dong Aisheng <aisheng.dong@nxp.com>  */
> >> >> > +
> >> >> > +#include <dt-bindings/clock/imx8qxp-clock.h>
> >> >> > +#include <dt-bindings/gpio/gpio.h> #include
> >> >> > +<dt-bindings/pinctrl/pads-imx8qxp.h>
> >> >> > +
> >> >> > +#include "imx8-ca35.dtsi"
> >> >> > +
> >> >> > +/ {
> >> >> > +   interrupt-parent = <&gic>;
> >> >> > +   #address-cells = <2>;
> >> >> > +   #size-cells = <2>;
> >> >> > +
> >> >> > +   aliases {
> >> >> > +           serial0 = &dma_lpuart0;
> >> >> > +           mmc0 = &usdhc1;
> >> >> > +           mmc1 = &usdhc2;
> >> >> > +           mmc2 = &usdhc3;
> >> >> > +   };
> >> >> > +
> >> >> > +   gic: interrupt-controller@51a00000 {
> >> >> > +           compatible = "arm,gic-v3";
> >> >> > +           reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
> >> >> > +                 <0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base
> +
> >> >> > + SGI_base)
> >> >> */
> >> >> > +           #interrupt-cells = <3>;
> >> >> > +           interrupt-controller;
> >> >> > +           interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> >> >> > +   };
> >> >> > +
> >> >> > +   timer {
> >> >> > +           compatible = "arm,armv8-timer";
> >> >> > +           interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /*
> >> >> > + Physical Secure
> >> >> */
> >> >> > +                        <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, /*
> >> >> > + Physical
> >> >> Non-Secure */
> >> >> > +                        <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, /*
> >> Virtual */
> >> >> > +                        <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /*
> >> Hypervisor */
> >> >> > +   };
> >> >> > +
> >> >> > +   xtal32k: clock-xtal32k {
> >> >> > +           compatible = "fixed-clock";
> >> >> > +           #clock-cells = <0>;
> >> >> > +           clock-frequency = <32768>;
> >> >> > +           clock-output-names = "xtal_32KHz";
> >> >> > +   };
> >> >> > +
> >> >> > +   xtal24m: clock-xtal24m {
> >> >> > +           compatible = "fixed-clock";
> >> >> > +           #clock-cells = <0>;
> >> >> > +           clock-frequency = <24000000>;
> >> >> > +           clock-output-names = "xtal_24MHz";
> >> >> > +   };
> >> >> > +
> >> >> > +   scu {
> >> >> > +           compatible = "fsl,imx-scu";
> >> >> > +           mbox-names = "tx0", "tx1", "tx2", "tx3",
> >> >> > +                        "rx0", "rx1", "rx2", "rx3";
> >> >> > +           mboxes = <&lsio_mu1 0 0
> >> >> > +                     &lsio_mu1 0 1
> >> >> > +                     &lsio_mu1 0 2
> >> >> > +                     &lsio_mu1 0 3
> >> >> > +                     &lsio_mu1 1 0
> >> >> > +                     &lsio_mu1 1 1
> >> >> > +                     &lsio_mu1 1 2
> >> >> > +                     &lsio_mu1 1 3>;
> >> >> > +
> >> >> > +           clk: clock-controller {
> >> >> > +                   compatible = "fsl,imx8qxp-clk";
> >> >> > +                   #clock-cells = <1>;
> >> >> > +                   clocks = <&xtal32k &xtal24m>;
> >> >> > +                   clock-names = "xtal_32KHz", "xtal_24Mhz";
> >> >> > +           };
> >> >> > +
> >> >> > +           iomuxc: pinctrl {
> >> >> > +                   compatible = "fsl,imx8qxp-iomuxc";
> >> >> > +           };
> >> >> > +
> >> >> > +           imx8qx-pm {
> >> >> > +                   compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
> >> >> > +                   #address-cells = <1>;
> >> >> > +                   #size-cells = <0>;
> >> >> > +
> >> >> > +                   pd_lsio: lsio-power-domain {
> >> >> > +                           #power-domain-cells = <0>;
> >> >> > +                           #address-cells = <1>;
> >> >> > +                           #size-cells = <0>;
> >> >> > +
> >> >> > +                           pd_lsio_pwm0: lsio-pwm0@bf {
> >> >> > +                                   reg = <0xbf>;
> >> >> > +                                   #power-domain-cells = <0>;
> >> >> > +                                   power-domains =
> <&pd_lsio>;
> >> >>
> >> >> Power domains are supposed to be a block that can be power gated.
> >> >> No chip design is going to put tiny PWM, GPIO, etc. blocks each in
> >> >> their own
> >> domain.
> >> >>
> >> >> If you really want to maintain these sub domains, just use 2
> >> >> #power-domain-cells. The first cell can be the power domain and
> >> >> the 2nd cell the device ID.
> >> >>
> >> >
> >> > Unfortunately the SCU firmware is designed like that each device
> >> > has a power domain ID which is specified in reg property in device tree.
> >> > Each driver should enable that power domain before being able to
> >> > access the HW, otherwise, xRDC (security and access control HW) may
> >> > report
> >> bus errors.
> >>
> >> This is what Rob is suggesting:
> >>
> >
> > Thanks for the example
> >
> >> pd_lsio: lsio-power-domain {
> >>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
> >>        #power-domain-cells = <2>;
> >> }
> >>
> >> pd_lsio_pwm0: lsio-pwm0@bf {
> >>        power-domains = <&pd_lsio 0 0xbf>; }
> >>
> >
> > What does 0 (cell 1) represent?
> 
> The index to the power domain, which is useful in case your power domain
> provider manages multiple PM domains.
> 
> >
> >> Perhaps it's even sufficient for you to use one cell, if your
> >> power-domain provider models only one PM domain. In such case, the
> below works as well:
> >>
> >> pd_lsio: lsio-power-domain {
> >>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
> >>        #power-domain-cells = <1>;
> >> }
> >>
> >> pd_lsio_pwm0: lsio-pwm0@bf {
> >>        power-domains = <&pd_lsio 0xbf>; }
> >>
> >> In other words, you don't need "reg".
> >
> > Will compiler complain a warning if missing "reg" property as we
> > already have the unit-address?
> 
> Not sure.
> 
> The above was more meant as an example, in principle any device node that is
> part of the pd_lsio PM domain, should be able to specify the "id" through one
> of the power-domain cells, rather than making itself being a power domain
> provider and thus using "reg". That is my main point.
> 

Yes, understand now.

> >
> >>
> >> To make this work, you also need to implement your own genpd xlate
> >> provider function. Do notice that, of_genpd_add_provider_onecell()
> >> already supports provider specific xlate functions. Just set it,
> >> before calling of_genpd_add_provider_onecell().
> >>
> >> If you would like to look at an example, see
> >> drivers/soc/tegra/powergate-bpmp.c.
> >>
> >
> > Will study. Thanks for the sharing.
> >
> >> > And there could be different multi-level domains, how to do 2cells
> >> presentation for this case?
> >> > E.g.
> >> > Domain_A: {
> >> >         Domain_B {
> >> >                 Domain_C {
> >> >                         ...
> >> >                 }
> >> >         }
> >> > }
> >>
> >> To specify a master domain, we use the power-domains specifier from
> >> within a power domain provider node. Of course it needs to use the
> >> correct number of cells as specified by the master provider, which
> >> may be something different that what it self uses.
> >>
> >> Something like this:
> >>
> >> pd_lsio_master: lsio-power-domain-master {
> >>        compatible = "fsl,imx8qxp-scu-pd-master",
> >> "fsl,scu-pd0-master";
> >
> > Introduced two new compatible string?
> 
> Because I considered this a completely separate power-domain provider.
> Again, it was just an example.
> 

Got it

> >
> >>        #power-domain-cells = <0>;
> >> }
> >>
> >> pd_lsio: lsio-power-domain {
> >>        compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd";
> >>        #power-domain-cells = <1>;
> >>        power-domains = <&pd_lsio_master>; }
> >>
> >> pd_lsio_pwm0: lsio-pwm0@bf {
> >>        power-domains = <&pd_lsio 0xbf>; }
> >>
> >
> > Overally I'm still not quite understand this new approach, may need
> > some more time to digest.
> >
> > A simple question is: Do we lose the power domain tree hierarchy?
> 
> Nope, at least not to my understanding.
> 
> > The original tree view seems like more straightforward. Not sure why
> > need to do like that.
> >
> > And overally this new approach seems much more complicated than the
> > old one due to we have to handle the special multilevel power domains.
> >
> > I'm a bit confusing whether it's worthy to switch to this new
> > complicated one and what's real advantage we can get comparing to the old
> simple way?
> 
> The old simple way? :-) I think you are misinterpreting it, to me it's the other
> way around.
> 
> The representation that Rob suggested, does not only model the HW more
> accurately, but should also becomes more simple.
> 
> In regards to model the HW correctly. I don't believe your HW topology have
> each PWM block, GPIO block, etc, in their own gate-able power domain, right?
> Or is it so?
> 

First of all, thanks for your and Rob's good suggestions.
I spent a lot more time to do research to try to make it better according to your
suggestions. Some of your ideas absolutely helped me a lot and gave me some
inspirations.

Some new findings are that some of our power domains are organized in a tree
was because the kernel does not support multi-power domains for one device.
but from HW point of view, they're identical. 
You can more serious situation from local tree at here:
https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm64/boot/dts/freescale/fsl-imx8dx.dtsi?h=imx_4.9.88_imx8qxp_beta2#n195

I just found your following patch perfectly addressed our issue as we do have many
Devices requires to handle multi power domains.
3c095f32a92b PM / Domains: Add support for multi PM domains per device to genpd
e.g. For LVDS devices, it need both LVDS and DC(Display controller) PD to work.

Now i was trying to understand all of our current user case with the team, If all of them
do not need a tree to address dependency issue, I may remove them all from device tree.
Then it would be much more clearer than before and be something like what Tegra does.
include/dt-bindings/power/tegra186-powergate.h
drivers/soc/tegra/powergate-bpmp.c

For example, 1 #power-domain-cells will be enough. The first cell can be a global SCU
power domain and the 2nd cell the device ID.
Hopefully this can be what you and Rob want.

If any good suggestions please let me know.

Thanks

Regards
Dong Aisheng

> Kind regards
> Uffe

Re: [PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[Ulf Hansson]

+ Jon

[...]

>>
>> In regards to model the HW correctly. I don't believe your HW topology have
>> each PWM block, GPIO block, etc, in their own gate-able power domain, right?
>> Or is it so?
>>
>
> First of all, thanks for your and Rob's good suggestions.
> I spent a lot more time to do research to try to make it better according to your
> suggestions. Some of your ideas absolutely helped me a lot and gave me some
> inspirations.
>
> Some new findings are that some of our power domains are organized in a tree
> was because the kernel does not support multi-power domains for one device.
> but from HW point of view, they're identical.
> You can more serious situation from local tree at here:
> https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm64/boot/dts/freescale/fsl-imx8dx.dtsi?h=imx_4.9.88_imx8qxp_beta2#n195
>
> I just found your following patch perfectly addressed our issue as we do have many
> Devices requires to handle multi power domains.
> 3c095f32a92b PM / Domains: Add support for multi PM domains per device to genpd
> e.g. For LVDS devices, it need both LVDS and DC(Display controller) PD to work.

Thanks for letting me know about further use cases about multiple PM
domain per device. Very interesting.

>
> Now i was trying to understand all of our current user case with the team, If all of them
> do not need a tree to address dependency issue, I may remove them all from device tree.
> Then it would be much more clearer than before and be something like what Tegra does.
> include/dt-bindings/power/tegra186-powergate.h
> drivers/soc/tegra/powergate-bpmp.c

Yes!

>
> For example, 1 #power-domain-cells will be enough. The first cell can be a global SCU
> power domain and the 2nd cell the device ID.
> Hopefully this can be what you and Rob want.
>
> If any good suggestions please let me know.

It makes perfect sense!

In regards to deploy support for multiple PM domains per device, you
may have a look at the recent work done Jon Hunter for the Tegra xHCI
genpd support [1].

[...]

Kind regards
Uffe

[1]
https://patchwork.ozlabs.org/cover/976328/

RE: [PATCH V3 6/8] arm64: dts: imx: add imx8qxp support

[A.s. Dong]

> -----Original Message-----
> From: Ulf Hansson [mailto:ulf.hansson@linaro.org]
> Sent: Thursday, October 25, 2018 7:31 PM
[...]
> + Jon
> 
> [...]
> 
> >>
> >> In regards to model the HW correctly. I don't believe your HW
> >> topology have each PWM block, GPIO block, etc, in their own gate-able
> power domain, right?
> >> Or is it so?
> >>
> >
> > First of all, thanks for your and Rob's good suggestions.
> > I spent a lot more time to do research to try to make it better
> > according to your suggestions. Some of your ideas absolutely helped me
> > a lot and gave me some inspirations.
> >
> > Some new findings are that some of our power domains are organized in
> > a tree was because the kernel does not support multi-power domains for one
> device.
> > but from HW point of view, they're identical.
> > You can more serious situation from local tree at here:

[...]

> >
> > I just found your following patch perfectly addressed our issue as we
> > do have many Devices requires to handle multi power domains.
> > 3c095f32a92b PM / Domains: Add support for multi PM domains per device
> > to genpd e.g. For LVDS devices, it need both LVDS and DC(Display controller)
> PD to work.
> 
> Thanks for letting me know about further use cases about multiple PM domain
> per device. Very interesting.
> 
> >
> > Now i was trying to understand all of our current user case with the
> > team, If all of them do not need a tree to address dependency issue, I may
> remove them all from device tree.
> > Then it would be much more clearer than before and be something like what
> Tegra does.
> > include/dt-bindings/power/tegra186-powergate.h
> > drivers/soc/tegra/powergate-bpmp.c
> 
> Yes!
> 
> >
> > For example, 1 #power-domain-cells will be enough. The first cell can
> > be a global SCU power domain and the 2nd cell the device ID.
> > Hopefully this can be what you and Rob want.
> >
> > If any good suggestions please let me know.
> 
> It makes perfect sense!
> 
> In regards to deploy support for multiple PM domains per device, you may
> have a look at the recent work done Jon Hunter for the Tegra xHCI genpd
> support [1].
> 

Thanks for sharing this info.
Will investigate it.

Regards
Dong Aisheng

> [...]
> 
> Kind regards
> Uffe

[PATCH V3 7/8] arm64: dts: imx: add imx8qxp mek support

[A.s. Dong]

i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
graphic and multimedia features. This patch adds imx8qxp mek board
support.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
v2->v3:
 * Pad names update
 * move memory node to here
 * add no-sd and no-sdio under emmc node
---
 Documentation/devicetree/bindings/arm/fsl.txt |   4 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 141 ++++++++++++++++++++++++++
 3 files changed, 146 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts

diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
index baeb1fc..704472b 100644
--- a/Documentation/devicetree/bindings/arm/fsl.txt
+++ b/Documentation/devicetree/bindings/arm/fsl.txt
@@ -97,6 +97,10 @@ i.MX7 SabreSD Board
 Required root node properties:
     - compatible = "fsl,imx7d-sdb", "fsl,imx7d";
 
+i.MX8QXP MEK Board
+Required root node properties:
+    - compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
+
 Generic i.MX boards
 -------------------
 
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 86e18ad..cff87f3 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -13,3 +13,4 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
+dtb-$(CONFIG_SOC_IMX8QXP) += imx8qxp-mek.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
new file mode 100644
index 0000000..6087ead
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -0,0 +1,141 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2017~2018 NXP
+ */
+
+/dts-v1/;
+
+#include "imx8qxp.dtsi"
+
+/ {
+	model = "Freescale i.MX8QXP MEK";
+	compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
+
+	chosen {
+		stdout-path = &dma_lpuart0;
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x00000000 0x80000000 0 0x40000000>;
+	};
+
+	reg_usdhc2_vmmc: usdhc2-vmmc {
+		compatible = "regulator-fixed";
+		regulator-name = "SD1_SPWR";
+		regulator-min-microvolt = <3000000>;
+		regulator-max-microvolt = <3000000>;
+		gpio = <&lsio_gpio4 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&dma_lpuart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lpuart0>;
+	status = "okay";
+};
+
+&fec1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fec1>;
+	phy-mode = "rgmii-id";
+	phy-handle = <&ethphy0>;
+	fsl,magic-packet;
+	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy@0 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			at803x,eee-disabled;
+			at803x,vddio-1p8v;
+			reg = <0>;
+		};
+
+		ethphy1: ethernet-phy@1 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			at803x,eee-disabled;
+			at803x,vddio-1p8v;
+			reg = <1>;
+		};
+	};
+};
+
+&usdhc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usdhc1>;
+	bus-width = <8>;
+	no-sd;
+	no-sdio;
+	non-removable;
+	status = "okay";
+};
+
+&usdhc2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usdhc2>;
+	bus-width = <4>;
+	vmmc-supply = <&reg_usdhc2_vmmc>;
+	cd-gpios = <&lsio_gpio4 22 GPIO_ACTIVE_LOW>;
+	wp-gpios = <&lsio_gpio4 21 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl_fec1: fec1grp {
+		fsl,pins = <
+			IMX8QXP_ENET0_MDC_CONN_ENET0_MDC			0x06000020
+			IMX8QXP_ENET0_MDIO_CONN_ENET0_MDIO			0x06000020
+			IMX8QXP_ENET0_RGMII_TX_CTL_CONN_ENET0_RGMII_TX_CTL	0x06000020
+			IMX8QXP_ENET0_RGMII_TXC_CONN_ENET0_RGMII_TXC		0x06000020
+			IMX8QXP_ENET0_RGMII_TXD0_CONN_ENET0_RGMII_TXD0		0x06000020
+			IMX8QXP_ENET0_RGMII_TXD1_CONN_ENET0_RGMII_TXD1		0x06000020
+			IMX8QXP_ENET0_RGMII_TXD2_CONN_ENET0_RGMII_TXD2		0x06000020
+			IMX8QXP_ENET0_RGMII_TXD3_CONN_ENET0_RGMII_TXD3		0x06000020
+			IMX8QXP_ENET0_RGMII_RXC_CONN_ENET0_RGMII_RXC		0x06000020
+			IMX8QXP_ENET0_RGMII_RX_CTL_CONN_ENET0_RGMII_RX_CTL	0x06000020
+			IMX8QXP_ENET0_RGMII_RXD0_CONN_ENET0_RGMII_RXD0		0x06000020
+			IMX8QXP_ENET0_RGMII_RXD1_CONN_ENET0_RGMII_RXD1		0x06000020
+			IMX8QXP_ENET0_RGMII_RXD2_CONN_ENET0_RGMII_RXD2		0x06000020
+			IMX8QXP_ENET0_RGMII_RXD3_CONN_ENET0_RGMII_RXD3		0x06000020
+		>;
+	};
+
+	pinctrl_lpuart0: lpuart0grp {
+		fsl,pins = <
+			IMX8QXP_UART0_RX_ADMA_UART0_RX				0x06000020
+			IMX8QXP_UART0_TX_ADMA_UART0_TX				0x06000020
+		>;
+	};
+
+	pinctrl_usdhc1: usdhc1grp {
+		fsl,pins = <
+			IMX8QXP_EMMC0_CLK_CONN_EMMC0_CLK			0x06000041
+			IMX8QXP_EMMC0_CMD_CONN_EMMC0_CMD			0x00000021
+			IMX8QXP_EMMC0_DATA0_CONN_EMMC0_DATA0			0x00000021
+			IMX8QXP_EMMC0_DATA1_CONN_EMMC0_DATA1			0x00000021
+			IMX8QXP_EMMC0_DATA2_CONN_EMMC0_DATA2			0x00000021
+			IMX8QXP_EMMC0_DATA3_CONN_EMMC0_DATA3			0x00000021
+			IMX8QXP_EMMC0_DATA4_CONN_EMMC0_DATA4			0x00000021
+			IMX8QXP_EMMC0_DATA5_CONN_EMMC0_DATA5			0x00000021
+			IMX8QXP_EMMC0_DATA6_CONN_EMMC0_DATA6			0x00000021
+			IMX8QXP_EMMC0_DATA7_CONN_EMMC0_DATA7			0x00000021
+			IMX8QXP_EMMC0_STROBE_CONN_EMMC0_STROBE			0x00000041
+		>;
+	};
+
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			IMX8QXP_USDHC1_CLK_CONN_USDHC1_CLK			0x06000041
+			IMX8QXP_USDHC1_CMD_CONN_USDHC1_CMD			0x00000021
+			IMX8QXP_USDHC1_DATA0_CONN_USDHC1_DATA0			0x00000021
+			IMX8QXP_USDHC1_DATA1_CONN_USDHC1_DATA1			0x00000021
+			IMX8QXP_USDHC1_DATA2_CONN_USDHC1_DATA2			0x00000021
+			IMX8QXP_USDHC1_DATA3_CONN_USDHC1_DATA3			0x00000021
+			IMX8QXP_USDHC1_VSELECT_CONN_USDHC1_VSELECT		0x00000021
+		>;
+	};
+};
-- 
2.7.4

Re: [PATCH V3 7/8] arm64: dts: imx: add imx8qxp mek support

[Rob Herring]

On Thu, Oct 18, 2018 at 06:19:43PM +0000, A.s. Dong wrote:
> i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
> graphic and multimedia features. This patch adds imx8qxp mek board
> support.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> v2->v3:
>  * Pad names update
>  * move memory node to here
>  * add no-sd and no-sdio under emmc node
> ---
>  Documentation/devicetree/bindings/arm/fsl.txt |   4 +
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 141 ++++++++++++++++++++++++++
>  3 files changed, 146 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
> index baeb1fc..704472b 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.txt
> +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> @@ -97,6 +97,10 @@ i.MX7 SabreSD Board
>  Required root node properties:
>      - compatible = "fsl,imx7d-sdb", "fsl,imx7d";
>  
> +i.MX8QXP MEK Board
> +Required root node properties:
> +    - compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
> +
>  Generic i.MX boards
>  -------------------
>  
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 86e18ad..cff87f3 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -13,3 +13,4 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
> +dtb-$(CONFIG_SOC_IMX8QXP) += imx8qxp-mek.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> new file mode 100644
> index 0000000..6087ead
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -0,0 +1,141 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright 2017~2018 NXP
> + */
> +
> +/dts-v1/;
> +
> +#include "imx8qxp.dtsi"
> +
> +/ {
> +	model = "Freescale i.MX8QXP MEK";
> +	compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
> +
> +	chosen {
> +		stdout-path = &dma_lpuart0;
> +	};
> +
> +	memory@80000000 {
> +		device_type = "memory";
> +		reg = <0x00000000 0x80000000 0 0x40000000>;
> +	};
> +
> +	reg_usdhc2_vmmc: usdhc2-vmmc {
> +		compatible = "regulator-fixed";
> +		regulator-name = "SD1_SPWR";
> +		regulator-min-microvolt = <3000000>;
> +		regulator-max-microvolt = <3000000>;
> +		gpio = <&lsio_gpio4 19 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +};
> +
> +&dma_lpuart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_lpuart0>;
> +	status = "okay";
> +};
> +
> +&fec1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_fec1>;
> +	phy-mode = "rgmii-id";
> +	phy-handle = <&ethphy0>;
> +	fsl,magic-packet;
> +	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@0 {
> +			compatible = "ethernet-phy-ieee802.3-c22";

> +			at803x,eee-disabled;
> +			at803x,vddio-1p8v;

These 2 are Not documented.

RE: [PATCH V3 7/8] arm64: dts: imx: add imx8qxp mek support

[A.s. Dong]

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Friday, October 19, 2018 4:28 AM
> To: A.s. Dong <aisheng.dong@nxp.com>
[...]
> On Thu, Oct 18, 2018 at 06:19:43PM +0000, A.s. Dong wrote:
> > i.MX 8QuadXPlus is a quad (4x) Cortex-A35 proccessor with powerful
> > graphic and multimedia features. This patch adds imx8qxp mek board
> > support.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: devicetree@vger.kernel.org
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Sascha Hauer <kernel@pengutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> > v2->v3:
> >  * Pad names update
> >  * move memory node to here
> >  * add no-sd and no-sdio under emmc node
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.txt |   4 +
> >  arch/arm64/boot/dts/freescale/Makefile        |   1 +
> >  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 141
> > ++++++++++++++++++++++++++
> >  3 files changed, 146 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.txt
> > b/Documentation/devicetree/bindings/arm/fsl.txt
> > index baeb1fc..704472b 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.txt
> > +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> > @@ -97,6 +97,10 @@ i.MX7 SabreSD Board  Required root node
> properties:
> >      - compatible = "fsl,imx7d-sdb", "fsl,imx7d";
> >
> > +i.MX8QXP MEK Board
> > +Required root node properties:
> > +    - compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
> > +
> >  Generic i.MX boards
> >  -------------------
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > b/arch/arm64/boot/dts/freescale/Makefile
> > index 86e18ad..cff87f3 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -13,3 +13,4 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) +=
> fsl-ls2080a-rdb.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
> > +dtb-$(CONFIG_SOC_IMX8QXP) += imx8qxp-mek.dtb
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > new file mode 100644
> > index 0000000..6087ead
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > @@ -0,0 +1,141 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2017~2018 NXP
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "imx8qxp.dtsi"
> > +
> > +/ {
> > +	model = "Freescale i.MX8QXP MEK";
> > +	compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
> > +
> > +	chosen {
> > +		stdout-path = &dma_lpuart0;
> > +	};
> > +
> > +	memory@80000000 {
> > +		device_type = "memory";
> > +		reg = <0x00000000 0x80000000 0 0x40000000>;
> > +	};
> > +
> > +	reg_usdhc2_vmmc: usdhc2-vmmc {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "SD1_SPWR";
> > +		regulator-min-microvolt = <3000000>;
> > +		regulator-max-microvolt = <3000000>;
> > +		gpio = <&lsio_gpio4 19 GPIO_ACTIVE_HIGH>;
> > +		enable-active-high;
> > +	};
> > +};
> > +
> > +&dma_lpuart0 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_lpuart0>;
> > +	status = "okay";
> > +};
> > +
> > +&fec1 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_fec1>;
> > +	phy-mode = "rgmii-id";
> > +	phy-handle = <&ethphy0>;
> > +	fsl,magic-packet;
> > +	status = "okay";
> > +
> > +	mdio {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		ethphy0: ethernet-phy@0 {
> > +			compatible = "ethernet-phy-ieee802.3-c22";
> 
> > +			at803x,eee-disabled;
> > +			at803x,vddio-1p8v;
> 
> These 2 are Not documented.

Sorry for missing these.
They're seemed to be introduce with original local code, as it does not
Affect the normal function, I will remove them in next patch set.

Thanks for the carefully review.

Regards
Dong Aisheng