From: Ulf Hansson <ulf.hansson@linaro.org>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Maulik Shah <quic_mkshah@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dt <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: qrb5165-rb5: Disable cpuidle states
Date: Wed, 19 Oct 2022 13:57:34 +0200 [thread overview]
Message-ID: <CAPDyKFoBMB9OMUrcoPCV0of1fj2dimEwPyHGW=ydjJ2M0ubM8Q@mail.gmail.com> (raw)
In-Reply-To: <20221018145348.4051809-1-amit.pundir@linaro.org>
On Tue, 18 Oct 2022 at 16:53, Amit Pundir <amit.pundir@linaro.org> wrote:
>
> Disable cpuidle states for RB5. These cpuidle states
> made the device highly unstable and it runs into the
> following crash frequently:
>
> [ T1] vreg_l11c_3p3: failed to enable: -ETIMEDOUT
> [ T1] qcom-rpmh-regulator 18200000.rsc:pm8150l-rpmh-regulators: ldo11: devm_regulator_register() failed, ret=-110
> [ T1] qcom-rpmh-regulator: probe of 18200000.rsc:pm8150l-rpmh-regulators failed with error -110
>
> Fixes: 32bc936d7321 ("arm64: dts: qcom: sm8250: Add cpuidle states")
> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index cc003535a3c5..f936c41bfbea 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -251,6 +251,14 @@ qca639x: qca639x {
>
> };
>
> +&LITTLE_CPU_SLEEP_0 {
> + status = "disabled";
> +};
> +
> +&BIG_CPU_SLEEP_0 {
> + status = "disabled";
> +};
> +
> &adsp {
> status = "okay";
> firmware-name = "qcom/sm8250/adsp.mbn";
> --
> 2.25.1
Disabling the CPU idlestates, will revert us back to using only the WFI state.
An option that probably works too is to just drop the idlestate for
the CPU cluster. Would you mind trying the below and see if that works
too?
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi
b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index c32227ea40f9..c707a49e8001 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -700,7 +700,6 @@ CPU_PD7: cpu7 {
CLUSTER_PD: cpu-cluster0 {
#power-domain-cells = <0>;
- domain-idle-states = <&CLUSTER_SLEEP_0>;
};
};
Kind regards
Uffe
next prev parent reply other threads:[~2022-10-19 12:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:53 [PATCH] arm64: dts: qcom: qrb5165-rb5: Disable cpuidle states Amit Pundir
2022-10-19 11:57 ` Ulf Hansson [this message]
2022-10-19 15:34 ` Amit Pundir
2022-10-20 9:30 ` Sudeep Holla
2022-10-20 14:08 ` Amit Pundir
2022-10-20 14:40 ` Ulf Hansson
2022-10-20 15:33 ` Amit Pundir
2022-10-20 16:16 ` Sudeep Holla
2022-10-21 13:02 ` Ulf Hansson
2022-10-25 11:23 ` Amit Pundir
2022-10-25 12:12 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFoBMB9OMUrcoPCV0of1fj2dimEwPyHGW=ydjJ2M0ubM8Q@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mkshah@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).