From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A477FC43219 for ; Wed, 19 Oct 2022 12:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbiJSMZV (ORCPT ); Wed, 19 Oct 2022 08:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233408AbiJSMYP (ORCPT ); Wed, 19 Oct 2022 08:24:15 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 288A783229 for ; Wed, 19 Oct 2022 04:59:52 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id i6so16989722pli.12 for ; Wed, 19 Oct 2022 04:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VMNFqQ1cKYZraeOUh2laCGjFrCge3hBVt6vY/kYdzro=; b=uCAZEUah1GXTO/Dhr3QPK4COCoFCeM8+Jjxsh4MLnKf1kiS4gCYn1tFEbS+Qx0GQZr lBKbx4uC7EboNj0hJmSxCxX7dYXYKZ6TMcAjDHAZvSUj8/wRjt9NaqPlLU1drz+/1cth A0SDNx2KUz3G2e5yuejO1SKwBWH0Xq/88Oo8IpcpmMYdLk8GLJcz8xf85uJDV+HoXfhs q0ctj00NM7PQDZemzH7QSJyup22Fz1Lh6PN2gCzIp+Gsu5+9wiKeEM7kiw2zYcFA5eAk bXoQip1KEgt9apacmG85i9WjsEXPBj1xloNylB25uCs0tHmqknYZuWAgfPq+lquO777l cKAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VMNFqQ1cKYZraeOUh2laCGjFrCge3hBVt6vY/kYdzro=; b=Mq25hF4tIUnfTEXKe+Hzr6BPILYSXE/dFfkFT/B+oy4SqEPfGG/r3v8i3DRkb+5tKK QZUnyZ5xxRzWcEpxwFx5YGPIwFmVt9s77h1+zlmEKJR6MhjPdOPsFdaoRmYaKd1HBfQf Z5GF768s03RLsCF7lItofBv8sAWOrSURxvL+FJ32RV8vqNBZ3earDQsVenOYzk/QxcPP 6d4fphFvGxo8h2nTKPQmaykKIKVwk8ULImzYvmtPv8+7NJOLXwnM6lVNbfbc4qihsgwc 9bSU3pgkEFRNd0SJT37O30HS7LabOI9iAQ8rdkiMneicgQyjB7lR5Xkc/3sG+Rw70rv/ 4Xmg== X-Gm-Message-State: ACrzQf1BScooi3U1YhYsg5U5eqEuLJJatE7uN4VqJJQaS5ZELlTM2mTj kQXIvANvK8+Ido614m5LZ/89c7ybqV932PhwLqk4ZA== X-Google-Smtp-Source: AMsMyM6WQNKXibXuVfWu8N49gAxdnh4vFghljtoHG++6NQujmf4jWPdnvyEXOs837QKkhfJvV65lOWL+4b+PAZmI4Cs= X-Received: by 2002:a17:903:246:b0:179:96b5:1ad2 with SMTP id j6-20020a170903024600b0017996b51ad2mr7993669plh.37.1666180690956; Wed, 19 Oct 2022 04:58:10 -0700 (PDT) MIME-Version: 1.0 References: <20221018145348.4051809-1-amit.pundir@linaro.org> In-Reply-To: <20221018145348.4051809-1-amit.pundir@linaro.org> From: Ulf Hansson Date: Wed, 19 Oct 2022 13:57:34 +0200 Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: qrb5165-rb5: Disable cpuidle states To: Amit Pundir Cc: Sudeep Holla , Bjorn Andersson , Andy Gross , Maulik Shah , Dmitry Baryshkov , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm , dt , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 18 Oct 2022 at 16:53, Amit Pundir wrote: > > Disable cpuidle states for RB5. These cpuidle states > made the device highly unstable and it runs into the > following crash frequently: > > [ T1] vreg_l11c_3p3: failed to enable: -ETIMEDOUT > [ T1] qcom-rpmh-regulator 18200000.rsc:pm8150l-rpmh-regulators: ldo11: devm_regulator_register() failed, ret=-110 > [ T1] qcom-rpmh-regulator: probe of 18200000.rsc:pm8150l-rpmh-regulators failed with error -110 > > Fixes: 32bc936d7321 ("arm64: dts: qcom: sm8250: Add cpuidle states") > Signed-off-by: Amit Pundir > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index cc003535a3c5..f936c41bfbea 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -251,6 +251,14 @@ qca639x: qca639x { > > }; > > +&LITTLE_CPU_SLEEP_0 { > + status = "disabled"; > +}; > + > +&BIG_CPU_SLEEP_0 { > + status = "disabled"; > +}; > + > &adsp { > status = "okay"; > firmware-name = "qcom/sm8250/adsp.mbn"; > -- > 2.25.1 Disabling the CPU idlestates, will revert us back to using only the WFI state. An option that probably works too is to just drop the idlestate for the CPU cluster. Would you mind trying the below and see if that works too? diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index c32227ea40f9..c707a49e8001 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -700,7 +700,6 @@ CPU_PD7: cpu7 { CLUSTER_PD: cpu-cluster0 { #power-domain-cells = <0>; - domain-idle-states = <&CLUSTER_SLEEP_0>; }; }; Kind regards Uffe