From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core Date: Tue, 6 May 2014 09:43:30 +0200 Message-ID: References: <1398334403-26181-1-git-send-email-geert+renesas@glider.be> <1398334403-26181-4-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Magnus Damm , Simon Horman , Laurent Pinchart , Ben Dooks , Felipe Balbi , Mike Turquette , "Rafael J. Wysocki" , Linux-sh list , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-omap , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 2 May 2014 16:35, Geert Uytterhoeven wrote: > Hi Ulf, > > On Fri, May 2, 2014 at 10:56 AM, Ulf Hansson wrote: >>> +static int of_clk_pm_runtime_suspend(struct device *dev) >>> +{ >>> + int ret; >>> + >>> + ret = pm_generic_runtime_suspend(dev); >>> + if (ret) >>> + return ret; >>> + >>> + ret = pm_clk_suspend(dev); >> >> What about slow clocks? Those aren't handled with pm_clk_suspend(). > > How are slow clocks handled? clk_prepare|unprepare - these functions may sleep. Kind regards Ulf Hansson > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds