From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5335454BD4 for ; Tue, 16 Jul 2024 14:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721141266; cv=none; b=faBHAcWbpDIKiSTdsmAHDkBezqLhpqOyOJBeitojnbeDOq0QvcIvNZrVsnd7MPiYhy91wZNtnSXuJxVxOjIura5w5GvCSMFYu2/GNlgxF8xDlp/jzO+3WCGXpij6Xs7Q54RXN+l4GCDUEYNEZ9frVFm2EDAAzEgHBrkcQCG6YM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721141266; c=relaxed/simple; bh=OLYU/zcE0HnlwiLapO7NYHmW4tXIDwLirTbJShxq8YY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Jqk0xJm2CRNECCVK4alWIs0MGFvhk9LpWYEfG0Bvl1SmDpO1ATEldrS3pNR+As55scujquYnZuNIXIE73zu+qGHfmR7opsCxTfwPv52IHmIbg3EQ6rTuXda85kEIynVbE6FK3ryoAa9sQilv0L4itzvGenx5+/MEozzigJpRH7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aRJwY2S8; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aRJwY2S8" Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e05a4d6e443so3148941276.0 for ; Tue, 16 Jul 2024 07:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721141264; x=1721746064; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lIUxRhCihkw5AdQD7a+Ru8B7j3Weiy/apMCIZLKG2WQ=; b=aRJwY2S8wfldWFfJLjRRimTIUWyi9//rJ+i22G5mNPF+12UJ0xJniYkLZoSdIyCqPT e3uefvqwqRuKevIs+u/CsTuGhXuuaWjhCMi9+pkbV4gq9Vao7GdVPGYSlqYNpsDyPO2e RtrVyVuklHKw9cX9RinubRh2rpWEWcYP9pCmjMAdRCRNn7CMrivVmeAfGoWqaKpjYhpV Thbnx6W4TjzejlFlJP8s7jXBE0aItCEY9KR8lC58bXdsNCHauMMeG/Jng7Zo7L0/0ynm /1TofQCvFuGWoz3oDbdazCjkEsXxjkVYjWtehfpIEUrFmFz3sSriCLyfu25RgfigswKq L3mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721141264; x=1721746064; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lIUxRhCihkw5AdQD7a+Ru8B7j3Weiy/apMCIZLKG2WQ=; b=Ylj5oaGx9PQdLT1mlo+BK02t8q8EzeBg/e7Ib4EYLwwsCqk9v7fnSPoiS+CD6dH5fN WxHtBJ3uN4xVRNXiXbSLHAdG6pAXAb9gd+QOanHKyZwBbuE+KzwWeHPT2g5QAJD/KgZx 16Ax3YJAOnxJlWCFvwdi4n8qWNZsruoBNyU1O7UOntriMeuCMArsehFUIm2PP53JQyDe nlrLsAmiMkTOtXEqvFy+7MJXr3vbLCgw7Sbc0RJeQvZ85o44bNPiwQqpcE78WOaHcA0K bMiw2Eu9Z09AvR5fucLNqYSVpQXtTM9455ePrRXnW6FZOAseqz299oHsDV+Q8pyed0FA cdGA== X-Forwarded-Encrypted: i=1; AJvYcCUxZC8L3yUdyFV6VjSPTnS0D7cL7+Uwnxz4NBm3A4qwTFBjTqTKhNsP9bU2jQJozaPR+Es9oXPLIfG2wZAxqznwpbKuFVsn+jVE6Q== X-Gm-Message-State: AOJu0Ywr5vleJxRhxx9k4VD1viioDyn1ruwSyG0UtpmQBN6taF3TF9Iv MbuYkBQAaBzY+vYKxDQ47J2BbBcKClQoAYRjnpqF3yk7kUkiT/ZG3MIk/zAaO6gd5RaHKkj7yWK 3aiYOFg2ijAUfuojM4w2CXnMQ4MQPmZPRqTJraA== X-Google-Smtp-Source: AGHT+IGLhLYhs15OnkuXXb6qctXWi3V58YENiqpNiizLQIzP3Jx59u+RYnM0FpRBItbtF/jNMz0BxWRkIf+zUjhYiBI= X-Received: by 2002:a05:6902:1543:b0:dff:47c7:ffb8 with SMTP id 3f1490d57ef6-e05d56670b9mr2737341276.12.1721141264185; Tue, 16 Jul 2024 07:47:44 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240708-topic-cpr3h-v15-0-5bc8b8936489@linaro.org> <20240708-topic-cpr3h-v15-1-5bc8b8936489@linaro.org> <94b2842b-6093-4c4d-a099-3e0a3198b753@linaro.org> In-Reply-To: From: Ulf Hansson Date: Tue, 16 Jul 2024 16:47:08 +0200 Message-ID: Subject: Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list To: Konrad Dybcio Cc: Krzysztof Kozlowski , AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Viresh Kumar , Nishanth Menon , Stephen Boyd , Niklas Cassel , Liam Girdwood , Mark Brown , Conor Dooley , "Rafael J. Wysocki" , Viresh Kumar , Rob Herring , Krzysztof Kozlowski , Robert Marko , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Jeffrey Hugo , Marijn Suijten , Konrad Dybcio , Varadarajan Narayanan Content-Type: text/plain; charset="UTF-8" On Tue, 16 Jul 2024 at 13:58, Konrad Dybcio wrote: > > On 15.07.2024 1:34 PM, Ulf Hansson wrote: > > On Tue, 9 Jul 2024 at 16:42, Krzysztof Kozlowski wrote: > >> > >> On 09/07/2024 11:49, Konrad Dybcio wrote: > >>> On 9.07.2024 11:04 AM, Krzysztof Kozlowski wrote: > >>>> On 08/07/2024 14:22, Konrad Dybcio wrote: > >>>>> Expand the Qualcomm Core Power Reduction section to include the files > >>>>> concerning CPR3+ support. > >>>>> > >>>>> Signed-off-by: Konrad Dybcio > >>>>> --- > >>>>> MAINTAINERS | 5 +++-- > >>>>> 1 file changed, 3 insertions(+), 2 deletions(-) > >>>>> > >>>>> diff --git a/MAINTAINERS b/MAINTAINERS > >>>>> index dcb37b635f2c..f3e013a52c16 100644 > >>>>> --- a/MAINTAINERS > >>>>> +++ b/MAINTAINERS > >>>>> @@ -18687,14 +18687,15 @@ F: Documentation/accel/qaic/ > >>>>> F: drivers/accel/qaic/ > >>>>> F: include/uapi/drm/qaic_accel.h > >>>>> > >>>>> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER > >>>>> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS > >>>>> M: Bjorn Andersson > >>>>> M: Konrad Dybcio > >>>>> L: linux-pm@vger.kernel.org > >>>>> L: linux-arm-msm@vger.kernel.org > >>>>> S: Maintained > >>>>> F: Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml > >>>>> -F: drivers/pmdomain/qcom/cpr.c > >>>>> +F: Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > >>>> > >>>> Maybe combine these two into: > >>>> Documentation/devicetree/bindings/power/avs/qcom,cpr* > >>> > >>> I think avs was proposed to be a subsystem/driver directory at some point > >>> and (adaptive voltage source? something like that) and this is the only file > >>> in that directory in bindings.. > >>> > >>> Should we continue with this "class" of devices, or should I move qcom,cpr.yaml > >>> to soc? > >> > >> Rather cpr3 should be moved to avs or some other power directory. "soc" > >> is fallback, junkyard for things without clear domain. > > > > In my opinion, I would suggest dropping the > > "Documentation/devicetree/bindings/power/avs/" directory. We already > > have similar bindings sprinkled across various directories, see below. > > One less seems better to me. > > > > Documentation/devicetree/bindings/arm/* > > Documentation/devicetree/bindings/firmware/* > > Documentation/devicetree/bindings/power/* > > Documentation/devicetree/bindings/soc/* > > So, should it go to bindings/power? Or should we get a new > bindings/pmdomain dir? No strong opinions from my side. Unless Krzysztof has better suggestions, using bindings/power/* works for me. Kind regards Uffe