From: Ulf Hansson <ulf.hansson@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>, Rob Herring <robh@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
David Collins <collinsd@codeaurora.org>,
Matthias Kaehlcke <mka@chromium.org>,
DTML <devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 09/10] soc: qcom: rpmpd: Use simple_opp_to_performance_state() helper
Date: Fri, 21 Dec 2018 11:32:34 +0100 [thread overview]
Message-ID: <CAPDyKFoZmJ22uswL4nkbhfqeeSpcz09mgQ6-tsrJRxE5EwTUsw@mail.gmail.com> (raw)
In-Reply-To: <20181221085622.25573-10-rnayak@codeaurora.org>
On Fri, 21 Dec 2018 at 09:57, Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
> Get rid of the duplicate code across rpmpd and rpmhpd to read the
> performance state value from Device tree and use the
> simple_opp_to_performance_state() helper instead.
>
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/soc/qcom/rpmhpd.c | 11 +----------
> drivers/soc/qcom/rpmpd.c | 11 +----------
> 2 files changed, 2 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index e37976e87370..f7fbe57f31ae 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -276,16 +276,7 @@ static int rpmhpd_set_performance_state(struct generic_pm_domain *domain,
> static unsigned int rpmhpd_get_performance_state(struct generic_pm_domain *genpd,
> struct dev_pm_opp *opp)
> {
> - struct device_node *np;
> - unsigned int level = 0;
> -
> - np = dev_pm_opp_get_of_node(opp);
> - if (of_property_read_u32(np, "qcom,level", &level))
> - pr_err("%s: missing 'qcom,level' property\n", __func__);
> -
> - of_node_put(np);
> -
> - return level;
> + return simple_opp_to_performance_state(genpd, opp, "qcom,level");
> }
>
> static int rpmhpd_update_level_mapping(struct rpmhpd *rpmhpd)
> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
> index 59e21c88a144..29288af502b0 100644
> --- a/drivers/soc/qcom/rpmpd.c
> +++ b/drivers/soc/qcom/rpmpd.c
> @@ -248,16 +248,7 @@ static int rpmpd_set_performance(struct generic_pm_domain *domain,
> static unsigned int rpmpd_get_performance(struct generic_pm_domain *genpd,
> struct dev_pm_opp *opp)
> {
> - struct device_node *np;
> - unsigned int corner = 0;
> -
> - np = dev_pm_opp_get_of_node(opp);
> - if (of_property_read_u32(np, "qcom,level", &corner))
> - pr_err("%s: missing 'qcom,level' property\n", __func__);
> -
> - of_node_put(np);
> -
> - return corner;
> + return simple_opp_to_performance_state(genpd, opp, "qcom,level");
> }
>
> static int rpmpd_probe(struct platform_device *pdev)
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2018-12-21 10:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 8:56 [PATCH v8 00/10] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-12-21 8:56 ` [PATCH v8 01/10] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2019-01-03 18:43 ` Rob Herring
2019-01-04 5:33 ` Rajendra Nayak
2018-12-21 8:56 ` [PATCH v8 02/10] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2018-12-21 8:56 ` [PATCH v8 03/10] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2018-12-21 8:56 ` [PATCH v8 04/10] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-12-21 8:56 ` [PATCH v8 05/10] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-12-21 8:56 ` [PATCH v8 06/10] soc: qcom: rpmhpd: Add RPMh power domain driver Rajendra Nayak
2018-12-21 8:56 ` [PATCH v8 07/10] arm64: dts: sdm845: Add rpmh powercontroller node Rajendra Nayak
2018-12-21 8:56 ` [PATCH v8 08/10] PM / Domains: Add a simple_opp_to_performance_state() helper Rajendra Nayak
2018-12-21 10:31 ` Ulf Hansson
2019-01-02 9:00 ` Viresh Kumar
2018-12-21 8:56 ` [PATCH v8 09/10] soc: qcom: rpmpd: Use " Rajendra Nayak
2018-12-21 10:32 ` Ulf Hansson [this message]
2018-12-21 8:56 ` [PATCH v8 10/10] soc: qcom: rpmhpd: Mark mx as a parent for cx Rajendra Nayak
2018-12-21 10:33 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFoZmJ22uswL4nkbhfqeeSpcz09mgQ6-tsrJRxE5EwTUsw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).