From: Ulf Hansson <ulf.hansson@linaro.org>
To: Manish Narani <manish.narani@xilinx.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
git@xilinx.com
Subject: Re: [PATCH] dt-bindings: mmc: Correct the type of the clk phase properties
Date: Fri, 22 Nov 2019 08:44:36 +0100 [thread overview]
Message-ID: <CAPDyKFokY52H4WO7TZHqfUu46U85dOV6FMp1QeY_ivUpfgS2sw@mail.gmail.com> (raw)
In-Reply-To: <1574406957-85248-1-git-send-email-manish.narani@xilinx.com>
On Fri, 22 Nov 2019 at 08:16, Manish Narani <manish.narani@xilinx.com> wrote:
>
> The clock phase properties are having two uint32 values. The minItems
> and maxItems are set to 2 for the same. So the property type should be
> 'uint32-array' and not 'uint32'. Modify it to correct the same.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> .../devicetree/bindings/mmc/mmc-controller.yaml | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 305b2016bc17..b130450c3b34 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -334,16 +334,17 @@ patternProperties:
> - reg
>
> "^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-(sdr(12|25|50|104)|ddr50))$":
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32-array
> minItems: 2
> maxItems: 2
> - allOf:
> - - $ref: /schemas/types.yaml#/definitions/uint32
> - - minimum: 0
> - maximum: 359
> - description:
> - Set the clock (phase) delays which are to be configured in the
> - controller while switching to particular speed mode. These values
> - are in pair of degrees.
> + items:
> + minimum: 0
> + maximum: 359
> + description:
> + Set the clock (phase) delays which are to be configured in the
> + controller while switching to particular speed mode. These values
> + are in pair of degrees.
>
> dependencies:
> cd-debounce-delay-ms: [ cd-gpios ]
> --
> 2.17.1
>
prev parent reply other threads:[~2019-11-22 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 7:15 [PATCH] dt-bindings: mmc: Correct the type of the clk phase properties Manish Narani
2019-11-22 7:44 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFokY52H4WO7TZHqfUu46U85dOV6FMp1QeY_ivUpfgS2sw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).