From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4156FC10F27 for ; Mon, 9 Mar 2020 07:11:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14E9720665 for ; Mon, 9 Mar 2020 07:11:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jj49n68Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726217AbgCIHLR (ORCPT ); Mon, 9 Mar 2020 03:11:17 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:39291 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbgCIHLR (ORCPT ); Mon, 9 Mar 2020 03:11:17 -0400 Received: by mail-vs1-f67.google.com with SMTP id a19so5346923vsp.6 for ; Mon, 09 Mar 2020 00:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nT8kP5pUwnT4nLnCd8ohNGxA8f6jkOWq+CENXf41rN8=; b=jj49n68ZLbr5lau47GKrIFokW76BtswCcAJCGBsgoecDZxBXC7RBhaaxC75E9kEVMK boVSXSOmjfCPd0S6cyfbmLR8l+N+rvfvVEbE4VkjF3R6cpS2o38EBXPECGQ2zh65Noaa BmsUwn+ZIRcDgQEdlYy0HL4rRGcy9/4ILQ2IYGFsi2i+8D3R0+OX68UeqwOZJb9xmjrs pfMUBDKBvspsJye1IA0q5yeeQIGd/qj2IRUAzPO93gPLILGU2SwzpmC9puBi8PrM4oS+ 4oBRi4nJYI6i3cGG97FLPMY3fom4TkgwGFuoyfHhrxAzzrl96J3YFjWMiNnXANAHm4MU vimQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nT8kP5pUwnT4nLnCd8ohNGxA8f6jkOWq+CENXf41rN8=; b=HIt+KhsESPEnqHoFrW8coLXMJW3HvgvHj6PkKT3YKPCotOPI4bbrbJeZ1fPiX/zTBP 3Ce4Q2C6bQtxu4j5lCyEps7iSjkfMkpYOV/E3duPOc3ucm65hm9BpQ2IWBITzmZLk2Qv RJopvQ9dOU2sX1hEQYd/eWRJEVBmu/NPUBuWptAEP3MU8WrB2e9vcVsec04VkjGljH/t um2yCJRe84lmL95yUhpQWJ3Ix+1khk8nKPR1VTxDdDbQlATgil3+8H6z3dQ7eOiYlJzZ aemIXo9q1Xv/Vt350raQxCsEN3Ne72tYN6gyhDG09VBOD4k3R9TDMaFY7UV4YXr77uAc 6XxQ== X-Gm-Message-State: ANhLgQ3jqQtwT/a2RdtCb8azbpue9fhR/rvhmWkcBU/RHEWzXlGEByVX 9IG3iyodBKk7BbJFFI++ev/Hx1aYAbF9T5hngt0iXw== X-Google-Smtp-Source: ADFU+vvEhKux28Afq7w3NtZUf1yVyALWzvmJdIOTefttBR+Xx/o1VutfGFN9NkAuko1vZs76wUuclul8MlPkP81jstI= X-Received: by 2002:a67:2ec6:: with SMTP id u189mr4702645vsu.200.1583737876126; Mon, 09 Mar 2020 00:11:16 -0700 (PDT) MIME-Version: 1.0 References: <20200303150749.30566-1-ulf.hansson@linaro.org> <20200303150749.30566-6-ulf.hansson@linaro.org> <20200303170641.GC26191@bogus> <20200304145313.GA5144@bogus> In-Reply-To: From: Ulf Hansson Date: Mon, 9 Mar 2020 08:10:40 +0100 Message-ID: Subject: Re: [PATCH 5/7] dt-bindings: arm: Fixup the DT bindings for hierarchical PSCI states To: Rob Herring Cc: Sudeep Holla , Lorenzo Pieralisi , DTML , "Rafael J . Wysocki" , Daniel Lezcano , Lina Iyer , Stephen Boyd , Bjorn Andersson , Benjamin Gaignard , Linux ARM , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 6 Mar 2020 at 19:29, Rob Herring wrote: > > On Wed, Mar 4, 2020 at 8:53 AM Rob Herring wrote: > > > > On Tue, Mar 03, 2020 at 09:50:08PM +0100, Ulf Hansson wrote: > > > On Tue, 3 Mar 2020 at 18:06, Rob Herring wrote: > > > > > > > > On Tue, Mar 03, 2020 at 04:07:47PM +0100, Ulf Hansson wrote: > > > > > The hierarchical topology with power-domain should be described through > > > > > child nodes, rather than as currently described in the PSCI root node. Fix > > > > > this by adding a patternProperties with a corresponding reference to the > > > > > power-domain DT binding. > > > > > > > > > > Additionally, update the example to conform to the new pattern, but also to > > > > > the adjusted domain-idle-state DT binding. > > > > > > > > > > Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") > > > > > Signed-off-by: Ulf Hansson > > > > > --- > > > > > .../devicetree/bindings/arm/psci.yaml | 33 +++++++++---------- > > > > > 1 file changed, 15 insertions(+), 18 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > > > > > index 0bc3c43a525a..cae668b61265 100644 > > > > > --- a/Documentation/devicetree/bindings/arm/psci.yaml > > > > > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > > > > > @@ -102,11 +102,15 @@ properties: > > > > > [1] Kernel documentation - ARM idle states bindings > > > > > Documentation/devicetree/bindings/arm/idle-states.yaml > > > > > > > > > > - "#power-domain-cells": > > > > > - description: > > > > > - The number of cells in a PM domain specifier as per binding in [3]. > > > > > - Must be 0 as to represent a single PM domain. > > > > > +required: > > > > > + - compatible > > > > > + - method > > > > > > > > No need to move this. > > > > > > Okay. > > > > > > > > > > > > > > > > > +patternProperties: > > > > > + "^(power-controller|power-domain)([@-].*)?$": > > > > > + $ref: "../power/power-domain.yaml#" > > > > > > > > This has to be under an 'allOf' or the rest of the properties are > > > > ignored. > > > > > > Sure, I had the feeling that something was missing. Thanks for reviewing! > > > > > > [...] > > > > > > Looks like I should a v2 of the series, or do you prefer to apply some > > > of the patches before I resend? > > > > Applied 1-3. I'll wait for v2 of 4 and 5. > > In order to fix all warnings by rc5, I fixed up and applied patches 4 and 5. Thanks a lot, looks good! Kind regards Uffe