devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Vincent Yang <vincent.cw.yang@gmail.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Vincent Yang <vincent.yang.fujitsu@gmail.com>,
	Vincent Yang <Vincent.Yang@tw.fujitsu.com>,
	Vincent Yang <vincent.yang@socionext.com>
Subject: Re: [PATCH] sdhci-fujitsu: add support for setting the CMD_DAT_DELAY attribute
Date: Mon, 6 Nov 2017 08:17:58 +0100	[thread overview]
Message-ID: <CAPDyKFp92YTqGNZ8s4mGQOpbmbEKxj9vpL0tj0rB-RbirWKCjw@mail.gmail.com> (raw)
In-Reply-To: <CAKR0VN+ATuiOdZ+n=t=h+Ru5WdzRfyq-41t0P8J=4LAUFGo+dA@mail.gmail.com>

[...]

>>>>
>>>> Do you mean set it unconditionally? That works for me, but I have no
>>>
>>> Yes.
>>>
>>>> way of testing whether it still works on other SoCs that use this IP.
>>>
>>> Me neither!
>>
>> Hi all, I can not yet get contact with IP owner because it is a
>> holiday in Japan.
>> Around two years ago, F_SDH30_CMD_DAT_DELAY was a new feature of this IP.
>> I will update the latest information as soon as I get it.
>>
> I got a response from IP owner.
> He explains F_SDH30_CMD_DAT_DELAY is intended to adjust signal timing of
> CMD/DAT lines, and it is necessary to change its value according to
> SoC/board design.
> So he advises us to make F_SDH30_CMD_DAT_DELAY adjustable by a DT binding.
>
> Kind regards
> Vincent
>
>>>
>>> Apparently there are no DTS in the kernel git that uses the
>>> "fujitsu,mb86s70-sdhci-3.0".
>>
>> Around two years ago, sdhci_f_sdh30_driver was a portion for mb86s70 SoC
>> patch series, but finally the patch series did not fully go upstream.
>>

Vincent, thanks for all the help in this!

Ard, one thing, could you please split the DT doc change into a
separate patch, preceding the change that actually do the parsing of
the new binding.

Kind regards
Uffe

  reply	other threads:[~2017-11-06  7:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01  0:21 [PATCH] sdhci-fujitsu: add support for setting the CMD_DAT_DELAY attribute Ard Biesheuvel
     [not found] ` <20171101002132.13500-1-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-11-02  0:08   ` Rob Herring
2017-11-02  0:12     ` Ard Biesheuvel
     [not found]       ` <CAKv+Gu8UPpsobJ_d4+OCdufSkLLhGdRFxPO92X3YKvnyBY5b7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-02 10:48         ` Ulf Hansson
2017-11-02 10:49           ` Ard Biesheuvel
     [not found]             ` <CAKv+Gu8nd7i+iaL-B55WbutGrOKaCsCdrQtFZgFs1TJaSqx-xw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-02 11:00               ` Ulf Hansson
     [not found]                 ` <CAPDyKFpKe-TaUeuWdenGf9tHV8+UkGkkdcp8Z+Yu9Q-haHsYsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-03  3:29                   ` Vincent Yang
     [not found]                     ` <CAKR0VNJ0xzRebUEZprRfQVp1LGjPG4khyumSYKsRtxCPTGkxYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-06  2:54                       ` Vincent Yang
2017-11-06  7:17                         ` Ulf Hansson [this message]
2017-11-06 10:46                           ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFp92YTqGNZ8s4mGQOpbmbEKxj9vpL0tj0rB-RbirWKCjw@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=Vincent.Yang@tw.fujitsu.com \
    --cc=adrian.hunter@intel.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=vincent.cw.yang@gmail.com \
    --cc=vincent.yang.fujitsu@gmail.com \
    --cc=vincent.yang@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).