Re: [PATCHv3 3/4] mmc: dw_mmc: remove the "supports-highspeed" property.

[Ulf Hansson <ulf.hansson@linaro.org>]

On 28 May 2014 07:35, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Removed the parser for "supports-highspeed".
> It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at
> mmc_of_parse().
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/mmc/host/dw_mmc.c |    3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 3285bdd..34b5210 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2281,9 +2281,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>                         return ERR_PTR(ret);
>         }
>
> -       if (of_find_property(np, "supports-highspeed", NULL))
> -               pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
> -

According to DT guys, normally we shouldn't remove DT bindings. Thus,
you need to keep this, unless you can get some of the DT guys to ack
it.

Though, you still want to move the DTs to use common mmc bindings. And
you could mark the documentation of the above binding as deprecated.

Kind regards
Ulf Hansson