From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCHv3 3/4] mmc: dw_mmc: remove the "supports-highspeed" property. Date: Fri, 30 May 2014 10:01:16 +0200 Message-ID: References: <1401255351-17653-1-git-send-email-jh80.chung@samsung.com> <1401255351-17653-4-git-send-email-jh80.chung@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1401255351-17653-4-git-send-email-jh80.chung@samsung.com> Sender: linux-mmc-owner@vger.kernel.org To: Jaehoon Chung Cc: linux-mmc , Chris Ball , Ludovic Desroches , "tgih.jun@samsung.com" , "devicetree@vger.kernel.org" , linux-samsung-soc List-Id: devicetree@vger.kernel.org On 28 May 2014 07:35, Jaehoon Chung wrote: > Removed the parser for "supports-highspeed". > It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at > mmc_of_parse(). > > Signed-off-by: Jaehoon Chung > --- > drivers/mmc/host/dw_mmc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 3285bdd..34b5210 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2281,9 +2281,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > return ERR_PTR(ret); > } > > - if (of_find_property(np, "supports-highspeed", NULL)) > - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; > - According to DT guys, normally we shouldn't remove DT bindings. Thus, you need to keep this, unless you can get some of the DT guys to ack it. Though, you still want to move the DTs to use common mmc bindings. And you could mark the documentation of the above binding as deprecated. Kind regards Ulf Hansson