From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15EA2C4167B for ; Tue, 29 Nov 2022 15:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235914AbiK2PbV (ORCPT ); Tue, 29 Nov 2022 10:31:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235698AbiK2PbS (ORCPT ); Tue, 29 Nov 2022 10:31:18 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4766E63CF3 for ; Tue, 29 Nov 2022 07:31:14 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id b11so13012844pjp.2 for ; Tue, 29 Nov 2022 07:31:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3fVszqxgQ016BSb5qNf+hCvyWQbfpRSMkXlPPrp4GVI=; b=bSoOisz9I9mHhMJiRBlqA98mcW26hkx7Xp/+fcTXZMmZBqyh1NAeNuhydDzv6eniZC UnhSBrDa3rOJUZ0VLUoEvXiSqNsAhcw3I5PiP8hpBWT6Pt33fbt+MTOr3911YUILLMsx X7d39KEEaQg0aOqHk6fOE6sy6Y5atjhFiv53VzRKof/3dSjO4BVCCWNCgZLcku1xFegj eNnGq+i7vNumxfZVraDv0AlhybJTPThiFPFGXaHDCFRAv3Q96CyDdeGMCILaRv82dd6z y3jPFZvGNVxeggjlx8KnjL0sl1novb60iZwlh0keCyMvHVdG11rFb6lmUFPdi/NOyK8K sLoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3fVszqxgQ016BSb5qNf+hCvyWQbfpRSMkXlPPrp4GVI=; b=ahej3EXijequ1xHZDoCq/a7PEXEppBDSSYq9z/sv7dVQIlz6sUF09NB/CwC0S1RCB9 8z+tqKWFrOrOcUNM0lPoCU+x2hgJmiETTf+2wLbFbrhiWPlKtWpdCQFenhnDgsMhdoLT UaejkYX+3tHREScRhw5+4APUAQU0vzpS8K0C9dmYVcnZT6n61xYNnjSQz37suytZchTw aiipyc3KW8CGQEnNqSBtmYIXHmofKVXoZ8rZnnpfi6fMVzT2eT9fr5UCjeuUNgepzYHD mvBlfiXTnzFCQWkjdXxolXylZKjI2RV58PdK6ygwnwOwUOaEZCtkHnS08rQC9fcbJeIm BhXA== X-Gm-Message-State: ANoB5pnH5Pm1WZqH1SkNDKzfoGSYDM2OA0v2xleuzl/URszN8J7BOJxD dCPKZ2IZnxzwNrif0G+sWE5NcrKw7yDRGAKOuvwkaw== X-Google-Smtp-Source: AA0mqf5ik5i4ChFnRvy/bmtuc8PRZp06XQinOIdUlzKVikOtmWsKfjSysf196kcbBAdsx08nJT52ptjgdMON40RNQ9k= X-Received: by 2002:a17:902:d68b:b0:188:cca8:df29 with SMTP id v11-20020a170902d68b00b00188cca8df29mr44499277ply.148.1669735873662; Tue, 29 Nov 2022 07:31:13 -0800 (PST) MIME-Version: 1.0 References: <20221122111124.6828-1-cniedermaier@dh-electronics.com> <20221122111124.6828-3-cniedermaier@dh-electronics.com> <55c29f92-4c6b-266f-2004-ae633a658963@linaro.org> In-Reply-To: <55c29f92-4c6b-266f-2004-ae633a658963@linaro.org> From: Ulf Hansson Date: Tue, 29 Nov 2022 16:30:37 +0100 Message-ID: Subject: Re: [PATCH] dt-bindings: mmc: Make comment on wakeup-source less confusing To: Krzysztof Kozlowski Cc: Christoph Niedermaier , linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Marek Vasut , kernel@dh-electronics.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 29 Nov 2022 at 13:36, Krzysztof Kozlowski wrote: > > On 22/11/2022 12:11, Christoph Niedermaier wrote: > > The current comment on wakeup-source is a bit confusing, because it isn't > > clear at first sight which property is actually deprecated. > > Change the comment to one that is less confusing. > > It's still confusing - you mention some non-existing property. I don't > think it's worth to touch it. If you insist, drop entire comment... Hmm, it doesn't look that easy to me. The "enable-sdio-wakeup" is indeed a deprecated wakeup property [1], but it seems like it's not really described somewhere. I wouldn't mind removing it (as it seems to add some confusions), but in that case it needs to be entirely removed from the DT docs, right? Another option, would be to add a proper description of the property and mark it with "deprecated: true". > > > > > Signed-off-by: Christoph Niedermaier > > --- > > Cc: Ulf Hansson > > Cc: Rob Herring > > Cc: Krzysztof Kozlowski > > Cc: Marek Vasut > > Cc: kernel@dh-electronics.com > > Cc: linux-mmc@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > To: linux-kernel@vger.kernel.org > > --- > > Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > index 802e3ca8be4d..a921442c6c1d 100644 > > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > > @@ -293,7 +293,7 @@ properties: > > description: > > SDIO only. Preserves card power during a suspend/resume cycle. > > > > - # Deprecated: enable-sdio-wakeup > > + # Use wakeup-source instead of the deprecated enable-sdio-wakeup > > wakeup-source: > > $ref: /schemas/types.yaml#/definitions/flag > > description: Kind regards Uffe [1] Documentation/devicetree/bindings/power/wakeup-source.txt