From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH V2 23/27] mmc: mmci: add variant property to request a reset Date: Mon, 1 Oct 2018 15:43:07 +0200 Message-ID: References: <1537523181-14578-1-git-send-email-ludovic.Barre@st.com> <1537523181-14578-24-git-send-email-ludovic.Barre@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ludovic BARRE Cc: Rob Herring , Maxime Coquelin , Alexandre Torgue , Benjamin Gaignard , Gerald Baeza , Loic Pallardy , Linux ARM , Linux Kernel Mailing List , DTML , "linux-mmc@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com List-Id: devicetree@vger.kernel.org [...] >>> @@ -1854,6 +1855,14 @@ static int mmci_probe(struct amba_device *dev, >>> >>> dev_dbg(mmc_dev(mmc), "clocking block at %u Hz\n", mmc->f_max); >>> >>> + if (variant->reset) { >>> + host->rst = devm_reset_control_get_exclusive(&dev->dev, >>> NULL); >> >> >> As suggested, let's make this optional and not depending on the variant. > > > I done like that because is required for my variant (if no reset, no power > cycle for sdmmc). The point is, I think don't think it's correct to ties this to the variant, but rather I think it depends on the behavior of the SoC. > > If you prefer, I could move to optional with > "devm_reset_control_get_optional_exclusive" > And I add a comment in mmci dt binding to specify that not optional > for sdmmc. (see above) Alright, fair enough. Let' do that. [...] Kind regards Uffe