devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] Documentation: mmc: add description for new no-sd* and no-mmc
@ 2016-07-14  8:26 Shawn Lin
  2016-07-14  8:26 ` [PATCH v2 2/2] mmc: core: expose MMC_CAP2_NO_* to dt Shawn Lin
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Shawn Lin @ 2016-07-14  8:26 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Adrian Hunter, Jaehoon Chung, Rob Herring, linux-mmc,
	linux-kernel, devicetree, Shawn Lin

This patch adds description for no-sd, no-sdio, no-mmc. We expose
these to DT as some of the controllers are unable to deal with
special cmd type due to hw limitation.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

---

Changes in v2:
- amend the description of these properties and the commit msg

 Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
index ecc007a..22d1e1f 100644
--- a/Documentation/devicetree/bindings/mmc/mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/mmc.txt
@@ -49,6 +49,9 @@ Optional properties:
 - mmc-hs400-enhanced-strobe: eMMC HS400 enhanced strobe mode is supported
 - dsr: Value the card's (optional) Driver Stage Register (DSR) should be
   programmed with. Valid range: [0 .. 0xffff].
+- no-sdio: controller is limited to send sdio cmd during initialization
+- no-sd: controller is limited to send sd cmd during initialization
+- no-mmc: controller is limited to send mmc cmd during initialization
 
 *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
 polarity properties, we have to fix the meaning of the "normal" and "inverted"
-- 
2.3.7

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] mmc: core: expose MMC_CAP2_NO_* to dt
  2016-07-14  8:26 [PATCH v2 1/2] Documentation: mmc: add description for new no-sd* and no-mmc Shawn Lin
@ 2016-07-14  8:26 ` Shawn Lin
  2016-07-18 11:20   ` Ulf Hansson
  2016-07-16 22:49 ` [PATCH v2 1/2] Documentation: mmc: add description for new no-sd* and no-mmc Rob Herring
       [not found] ` <1468484764-32353-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  2 siblings, 1 reply; 5+ messages in thread
From: Shawn Lin @ 2016-07-14  8:26 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Adrian Hunter, Jaehoon Chung, Rob Herring, linux-mmc,
	linux-kernel, devicetree, Shawn Lin

The reason for why we expose these to dt is that some of
the controller is unable to send special cmd type due to
the hw limitation.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

---

Changes in v2:
- amend the commit msg

 drivers/mmc/core/host.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index d7e86f9..98f25ff 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -315,6 +315,12 @@ int mmc_of_parse(struct mmc_host *host)
 		host->caps2 |= MMC_CAP2_HS400_1_2V | MMC_CAP2_HS200_1_2V_SDR;
 	if (of_property_read_bool(np, "mmc-hs400-enhanced-strobe"))
 		host->caps2 |= MMC_CAP2_HS400_ES;
+	if (of_property_read_bool(np, "no-sdio"))
+		host->caps2 |= MMC_CAP2_NO_SDIO;
+	if (of_property_read_bool(np, "no-sd"))
+		host->caps2 |= MMC_CAP2_NO_SD;
+	if (of_property_read_bool(np, "no-mmc"))
+		host->caps2 |= MMC_CAP2_NO_MMC;
 
 	host->dsr_req = !of_property_read_u32(np, "dsr", &host->dsr);
 	if (host->dsr_req && (host->dsr & ~0xffff)) {
-- 
2.3.7

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] Documentation: mmc: add description for new no-sd* and no-mmc
  2016-07-14  8:26 [PATCH v2 1/2] Documentation: mmc: add description for new no-sd* and no-mmc Shawn Lin
  2016-07-14  8:26 ` [PATCH v2 2/2] mmc: core: expose MMC_CAP2_NO_* to dt Shawn Lin
@ 2016-07-16 22:49 ` Rob Herring
       [not found] ` <1468484764-32353-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2016-07-16 22:49 UTC (permalink / raw)
  To: Shawn Lin
  Cc: Ulf Hansson, Adrian Hunter, Jaehoon Chung, linux-mmc,
	linux-kernel, devicetree

On Thu, Jul 14, 2016 at 04:26:03PM +0800, Shawn Lin wrote:
> This patch adds description for no-sd, no-sdio, no-mmc. We expose
> these to DT as some of the controllers are unable to deal with
> special cmd type due to hw limitation.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> 
> ---
> 
> Changes in v2:
> - amend the description of these properties and the commit msg
> 
>  Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++
>  1 file changed, 3 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] Documentation: mmc: add description for new no-sd* and no-mmc
       [not found] ` <1468484764-32353-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
@ 2016-07-18 11:20   ` Ulf Hansson
  0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2016-07-18 11:20 UTC (permalink / raw)
  To: Shawn Lin
  Cc: Adrian Hunter, Jaehoon Chung, Rob Herring, linux-mmc,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On 14 July 2016 at 10:26, Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote:
> This patch adds description for no-sd, no-sdio, no-mmc. We expose
> these to DT as some of the controllers are unable to deal with
> special cmd type due to hw limitation.
>
> Signed-off-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Thanks, applied for next!

Kind regards
Uffe

>
> ---
>
> Changes in v2:
> - amend the description of these properties and the commit msg
>
>  Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
> index ecc007a..22d1e1f 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> @@ -49,6 +49,9 @@ Optional properties:
>  - mmc-hs400-enhanced-strobe: eMMC HS400 enhanced strobe mode is supported
>  - dsr: Value the card's (optional) Driver Stage Register (DSR) should be
>    programmed with. Valid range: [0 .. 0xffff].
> +- no-sdio: controller is limited to send sdio cmd during initialization
> +- no-sd: controller is limited to send sd cmd during initialization
> +- no-mmc: controller is limited to send mmc cmd during initialization
>
>  *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
>  polarity properties, we have to fix the meaning of the "normal" and "inverted"
> --
> 2.3.7
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] mmc: core: expose MMC_CAP2_NO_* to dt
  2016-07-14  8:26 ` [PATCH v2 2/2] mmc: core: expose MMC_CAP2_NO_* to dt Shawn Lin
@ 2016-07-18 11:20   ` Ulf Hansson
  0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2016-07-18 11:20 UTC (permalink / raw)
  To: Shawn Lin
  Cc: Adrian Hunter, Jaehoon Chung, Rob Herring, linux-mmc,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org

On 14 July 2016 at 10:26, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> The reason for why we expose these to dt is that some of
> the controller is unable to send special cmd type due to
> the hw limitation.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks, applied for next!

Kind regards
Uffe

>
> ---
>
> Changes in v2:
> - amend the commit msg
>
>  drivers/mmc/core/host.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index d7e86f9..98f25ff 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -315,6 +315,12 @@ int mmc_of_parse(struct mmc_host *host)
>                 host->caps2 |= MMC_CAP2_HS400_1_2V | MMC_CAP2_HS200_1_2V_SDR;
>         if (of_property_read_bool(np, "mmc-hs400-enhanced-strobe"))
>                 host->caps2 |= MMC_CAP2_HS400_ES;
> +       if (of_property_read_bool(np, "no-sdio"))
> +               host->caps2 |= MMC_CAP2_NO_SDIO;
> +       if (of_property_read_bool(np, "no-sd"))
> +               host->caps2 |= MMC_CAP2_NO_SD;
> +       if (of_property_read_bool(np, "no-mmc"))
> +               host->caps2 |= MMC_CAP2_NO_MMC;
>
>         host->dsr_req = !of_property_read_u32(np, "dsr", &host->dsr);
>         if (host->dsr_req && (host->dsr & ~0xffff)) {
> --
> 2.3.7
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-07-18 11:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-14  8:26 [PATCH v2 1/2] Documentation: mmc: add description for new no-sd* and no-mmc Shawn Lin
2016-07-14  8:26 ` [PATCH v2 2/2] mmc: core: expose MMC_CAP2_NO_* to dt Shawn Lin
2016-07-18 11:20   ` Ulf Hansson
2016-07-16 22:49 ` [PATCH v2 1/2] Documentation: mmc: add description for new no-sd* and no-mmc Rob Herring
     [not found] ` <1468484764-32353-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-18 11:20   ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).