From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v4 1/7] mmc: dt-bindings: add Mediatek MMC bindings Date: Tue, 19 May 2015 11:41:46 +0200 Message-ID: References: <1432017411-2996-1-git-send-email-chaotian.jing@mediatek.com> <1432017411-2996-2-git-send-email-chaotian.jing@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1432017411-2996-2-git-send-email-chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chaotian Jing Cc: Rob Herring , Matthias Brugger , Chris Ball , Mark Rutland , James Liao , srv_heupstream , Arnd Bergmann , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Hongzhou Yang , Catalin Marinas , linux-mmc , Will Deacon , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sascha Hauer , "Joe.C" , Eddie Huang , =?UTF-8?B?QmluIFpoYW5nICjnq6Dmlowp?= , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-mediatek List-Id: devicetree@vger.kernel.org On 19 May 2015 at 08:36, Chaotian Jing wrote: > Document the device-tree binding of Mediatek MMC host > > Signed-off-by: Chaotian Jing > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 33 ++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/mtk-sd.txt > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > new file mode 100644 > index 0000000..ba6d668 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -0,0 +1,33 @@ > +* MTK MMC controller > + > +The MTK MSDC can act as a MMC controller > +to support MMC, SD, and SDIO types of memory cards. > + > +This file documents differences between the core properties in mmc.txt > +and the properties used by the msdc driver. > + > +Required properties: > +- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc". > +- interrupts: Should contain MSDC interrupt number > +- clocks: MSDC source clock, HCLK, HCLK is mandatory when it is not controlled by Infra This seems strange. Either it's mandatory since it's under the "Required properties" section or it should be moved to the "Optional properties" section. > +- clock-names: "source", "hclk" > +- pinctrl-names: should be "default", "state_uhs" > +- pinctrl-0: should contain default/high speed pin ctrl > +- pinctrl-1: should contain uhs mode pin ctrl > +- vmmc-supply: power to the Core > + > +Optional properties: > +- vqmmc-supply: power to the IO(for SD/SDIO) > + > +Examples: > +mmc0: mmc@11230000 { > + compatible = "mediatek,mt8173-mmc", "mediatek,mt8135-mmc"; > + reg = <0 0x11230000 0 0x108>; > + interrupts = ; > + vmmc-supply = <&mt6397_vemc_3v3_reg>; > + clocks = <&pericfg CLK_PERI_MSDC30_0>, <&topckgen CLK_TOP_MSDC50_0_H_SEL>; > + clock-names = "source", "hclk"; > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc0_pins_default>; > + pinctrl-1 = <&mmc0_pins_uhs>; > +}; > -- > 1.8.1.1.dirty > Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html