From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH 04/11] mmc: sunxi: Keep default timing phase settings for new timing mode Date: Mon, 17 Jul 2017 12:37:41 +0200 Message-ID: References: <20170714064302.20383-1-wens@csie.org> <20170714064302.20383-5-wens@csie.org> Reply-To: ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170714064302.20383-5-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Maxime Ripard , Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-clk , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi , "# 4.0+" List-Id: devicetree@vger.kernel.org +stable On 14 July 2017 at 08:42, Chen-Yu Tsai wrote: > The register for the "new timing mode" also has bit fields for setting > output and sample timing phases. According to comments in Allwinner's > BSP kernel, the default values are good enough. > > Keep the default values already in the hardware when setting new timing > mode, instead of overwriting the whole register. > > Fixes: 9a37e53e451e ("mmc: sunxi: Enable the new timings for the A64 MMC > controllers") > Signed-off-by: Chen-Yu Tsai Thanks, applied for fixes and added a stable tag. Kind regards Uffe > --- > drivers/mmc/host/sunxi-mmc.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c > index d6fa2214aaae..0fb4e4c119e1 100644 > --- a/drivers/mmc/host/sunxi-mmc.c > +++ b/drivers/mmc/host/sunxi-mmc.c > @@ -793,8 +793,12 @@ static int sunxi_mmc_clk_set_rate(struct sunxi_mmc_host *host, > } > mmc_writel(host, REG_CLKCR, rval); > > - if (host->cfg->needs_new_timings) > - mmc_writel(host, REG_SD_NTSR, SDXC_2X_TIMING_MODE); > + if (host->cfg->needs_new_timings) { > + /* Don't touch the delay bits */ > + rval = mmc_readl(host, REG_SD_NTSR); > + rval |= SDXC_2X_TIMING_MODE; > + mmc_writel(host, REG_SD_NTSR, rval); > + } > > ret = sunxi_mmc_clk_set_phase(host, ios, rate); > if (ret) > -- > 2.13.2 >