[PATCH v2 0/4] Add rpmhpd powerdomains support for QCS615/QCS8300

[PATCH v2 0/4] Add rpmhpd powerdomains support for QCS615/QCS8300

[Tingguo Cheng]

Document the qcom,qcs8300-rpmhpd compatible and add power domains in
rpmhpd driver to support QCS8300.
Document the qcom,qcs615-rpmhpd compatible and add power domains in
rpmhpd driver to support QCS615.

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
Changes in v2:
- Rebased patchsets on next-20240927.
- Combined 2 patchsets into one to resolve merge conflicts of touching
  the same part of code.
  - Current Patchset
  |
  |->Patchset 1:https://lore.kernel.org/r/20240920-add_qcs615_powerdomains_driver_support-v1-0-8846efaf9454@quicinc.com
  |->Patchset 2:https://lore.kernel.org/r/20240920-add_qcs8300_powerdomains_driver_support-v1-0-96a2a08841da@quicinc.com

- Link to v1: https://lore.kernel.org/r/20240920-add_qcs8300_powerdomains_driver_support-v1-0-96a2a08841da@quicinc.com

---
Tingguo Cheng (4):
      dt-bindings: power: qcom,rpmpd: document qcs8300 RPMh power domains
      pmdomain: qcom: rpmhpd: Add qcs8300 power domains
      dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains
      pmdomain: qcom: rpmhpd: Add qcs615 power domains

 .../devicetree/bindings/power/qcom,rpmpd.yaml      |  2 ++
 drivers/pmdomain/qcom/rpmhpd.c                     | 36 ++++++++++++++++++++++
 2 files changed, 38 insertions(+)
---
base-commit: 40e0c9d414f57d450e3ad03c12765e797fc3fede
change-id: 20240927-add_qcs615_qcs8300_powerdomains_driver_support-7cd487126340

Best regards,
-- 
Tingguo Cheng <quic_tingguoc@quicinc.com>

[PATCH v2 1/4] dt-bindings: power: qcom,rpmpd: document qcs8300 RPMh power domains

[Tingguo Cheng]

Add compatible string for the RPMh power domains on qcs8300 platform.

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index 929b7ef9c1bcdae8194adfdfd6114573ab4d59cd..be1a9cb71a9babf007bc43f230a04401cd26a6b6 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -32,6 +32,7 @@ properties:
           - qcom,msm8998-rpmpd
           - qcom,qcm2290-rpmpd
           - qcom,qcs404-rpmpd
+          - qcom,qcs8300-rpmhpd
           - qcom,qdu1000-rpmhpd
           - qcom,qm215-rpmpd
           - qcom,sa8155p-rpmhpd

-- 
2.34.1

[PATCH v2 2/4] pmdomain: qcom: rpmhpd: Add qcs8300 power domains

[Tingguo Cheng]

Add support for the power domains exposed by RPMh on the qcs8300
platform. MMCX depends on CX, so mark CX as the parent of MMCX.

Co-developed-by: Shazad Hussain <quic_shazhuss@quicinc.com>
Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com>
Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 drivers/pmdomain/qcom/rpmhpd.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
index 65505e1e221986ad20751b658374dd0e74719703..d256110225dc517187b2ac1bbbb781eae78b7d59 100644
--- a/drivers/pmdomain/qcom/rpmhpd.c
+++ b/drivers/pmdomain/qcom/rpmhpd.c
@@ -624,7 +624,31 @@ static const struct rpmhpd_desc x1e80100_desc = {
 	.num_pds = ARRAY_SIZE(x1e80100_rpmhpds),
 };
 
+/* QCS8300 RPMH power domains */
+static struct rpmhpd *qcs8300_rpmhpds[] = {
+	[RPMHPD_CX] = &cx,
+	[RPMHPD_CX_AO] = &cx_ao,
+	[RPMHPD_EBI] = &ebi,
+	[RPMHPD_GFX] = &gfx,
+	[RPMHPD_LCX] = &lcx,
+	[RPMHPD_LMX] = &lmx,
+	[RPMHPD_MMCX] = &mmcx_w_cx_parent,
+	[RPMHPD_MMCX_AO] = &mmcx_ao_w_cx_parent,
+	[RPMHPD_MXC] = &mxc,
+	[RPMHPD_MXC_AO] = &mxc_ao,
+	[RPMHPD_MX] = &mx,
+	[RPMHPD_MX_AO] = &mx_ao,
+	[RPMHPD_NSP0] = &nsp0,
+	[RPMHPD_NSP1] = &nsp1,
+};
+
+static const struct rpmhpd_desc qcs8300_desc = {
+	.rpmhpds = qcs8300_rpmhpds,
+	.num_pds = ARRAY_SIZE(qcs8300_rpmhpds),
+};
+
 static const struct of_device_id rpmhpd_match_table[] = {
+	{ .compatible = "qcom,qcs8300-rpmhpd", .data = &qcs8300_desc },
 	{ .compatible = "qcom,qdu1000-rpmhpd", .data = &qdu1000_desc },
 	{ .compatible = "qcom,sa8155p-rpmhpd", .data = &sa8155p_desc },
 	{ .compatible = "qcom,sa8540p-rpmhpd", .data = &sa8540p_desc },

-- 
2.34.1

[PATCH v2 3/4] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains

[Tingguo Cheng]

Add compatible string for the RPMh power domains on qcs615 platform.

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index be1a9cb71a9babf007bc43f230a04401cd26a6b6..17ad46e5552947f08b1be8691e225ed9ddaa736b 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -32,6 +32,7 @@ properties:
           - qcom,msm8998-rpmpd
           - qcom,qcm2290-rpmpd
           - qcom,qcs404-rpmpd
+          - qcom,qcs615-rpmhpd
           - qcom,qcs8300-rpmhpd
           - qcom,qdu1000-rpmhpd
           - qcom,qm215-rpmpd

-- 
2.34.1

[PATCH v2 4/4] pmdomain: qcom: rpmhpd: Add qcs615 power domains

[Tingguo Cheng]

Add support for power domains exposed by RPMh on the qcs615 platform.
Only CX/CX_AO are exposed by RPMh. Consumers such as VDD_MX, EBI, LPI_
MX and LPI_CX will share the power domains.

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 drivers/pmdomain/qcom/rpmhpd.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
index d256110225dc517187b2ac1bbbb781eae78b7d59..731feab9f17ddae699815332d193e9a298fff0e1 100644
--- a/drivers/pmdomain/qcom/rpmhpd.c
+++ b/drivers/pmdomain/qcom/rpmhpd.c
@@ -647,7 +647,19 @@ static const struct rpmhpd_desc qcs8300_desc = {
 	.num_pds = ARRAY_SIZE(qcs8300_rpmhpds),
 };
 
+/* QCS615 RPMH powerdomains */
+static struct rpmhpd *qcs615_rpmhpds[] = {
+	[RPMHPD_CX] = &cx,
+	[RPMHPD_CX_AO] = &cx_ao,
+};
+
+static const struct rpmhpd_desc qcs615_desc = {
+	.rpmhpds = qcs615_rpmhpds,
+	.num_pds = ARRAY_SIZE(qcs615_rpmhpds),
+};
+
 static const struct of_device_id rpmhpd_match_table[] = {
+	{ .compatible = "qcom,qcs615-rpmhpd", .data = &qcs615_desc },
 	{ .compatible = "qcom,qcs8300-rpmhpd", .data = &qcs8300_desc },
 	{ .compatible = "qcom,qdu1000-rpmhpd", .data = &qdu1000_desc },
 	{ .compatible = "qcom,sa8155p-rpmhpd", .data = &sa8155p_desc },

-- 
2.34.1

Re: [PATCH v2 1/4] dt-bindings: power: qcom,rpmpd: document qcs8300 RPMh power domains

[Krzysztof Kozlowski]

On 27/09/2024 13:59, Tingguo Cheng wrote:
> Add compatible string for the RPMh power domains on qcs8300 platform.
> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof

Re: [PATCH v2 3/4] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains

[Krzysztof Kozlowski]

On 27/09/2024 13:59, Tingguo Cheng wrote:
> Add compatible string for the RPMh power domains on qcs615 platform.
> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>

So you expect all of us to do the same work twice?

Best regards,
Krzysztof

Re: [PATCH v2 0/4] Add rpmhpd powerdomains support for QCS615/QCS8300

[Ulf Hansson]

On Fri, 27 Sept 2024 at 14:00, Tingguo Cheng <quic_tingguoc@quicinc.com> wrote:
>
> Document the qcom,qcs8300-rpmhpd compatible and add power domains in
> rpmhpd driver to support QCS8300.
> Document the qcom,qcs615-rpmhpd compatible and add power domains in
> rpmhpd driver to support QCS615.
>
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>

The series applied for next and by adding  Krzysztof's ack on the DT
patches (next time, please carry them forward when posting new
versions), thanks!

Note that the DT patch is also available on the immutable dt branch.

Kind regards
Uffe


> ---
> Changes in v2:
> - Rebased patchsets on next-20240927.
> - Combined 2 patchsets into one to resolve merge conflicts of touching
>   the same part of code.
>   - Current Patchset
>   |
>   |->Patchset 1:https://lore.kernel.org/r/20240920-add_qcs615_powerdomains_driver_support-v1-0-8846efaf9454@quicinc.com
>   |->Patchset 2:https://lore.kernel.org/r/20240920-add_qcs8300_powerdomains_driver_support-v1-0-96a2a08841da@quicinc.com
>
> - Link to v1: https://lore.kernel.org/r/20240920-add_qcs8300_powerdomains_driver_support-v1-0-96a2a08841da@quicinc.com
>
> ---
> Tingguo Cheng (4):
>       dt-bindings: power: qcom,rpmpd: document qcs8300 RPMh power domains
>       pmdomain: qcom: rpmhpd: Add qcs8300 power domains
>       dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains
>       pmdomain: qcom: rpmhpd: Add qcs615 power domains
>
>  .../devicetree/bindings/power/qcom,rpmpd.yaml      |  2 ++
>  drivers/pmdomain/qcom/rpmhpd.c                     | 36 ++++++++++++++++++++++
>  2 files changed, 38 insertions(+)
> ---
> base-commit: 40e0c9d414f57d450e3ad03c12765e797fc3fede
> change-id: 20240927-add_qcs615_qcs8300_powerdomains_driver_support-7cd487126340
>
> Best regards,
> --
> Tingguo Cheng <quic_tingguoc@quicinc.com>
>

Re: [PATCH v2 2/4] pmdomain: qcom: rpmhpd: Add qcs8300 power domains

[Dmitry Baryshkov]

On Fri, Sep 27, 2024 at 07:59:14PM GMT, Tingguo Cheng wrote:
> Add support for the power domains exposed by RPMh on the qcs8300
> platform. MMCX depends on CX, so mark CX as the parent of MMCX.
> 
> Co-developed-by: Shazad Hussain <quic_shazhuss@quicinc.com>
> Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com>
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---
>  drivers/pmdomain/qcom/rpmhpd.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 

-- 
With best wishes
Dmitry