From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v2 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding Date: Tue, 19 Apr 2016 11:43:05 +0200 Message-ID: References: <0376e04a938f459cee9e1f80e1447e060ba7e497.1460986983.git.larper@axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <0376e04a938f459cee9e1f80e1447e060ba7e497.1460986983.git.larper@axis.com> Sender: linux-mmc-owner@vger.kernel.org To: Lars Persson Cc: linux-mmc , "devicetree@vger.kernel.org" , Guennadi Liakhovetski , Rob Herring , =?UTF-8?Q?Pawe=C5=82_Moll?= , Mark Rutland , Ian Campbell , Kumar Gala , Lars Persson List-Id: devicetree@vger.kernel.org On 18 April 2016 at 15:44, Lars Persson wrote: > Add a pinctrl binding to specify different pin settings for high speed > modes and UHS modes. > > Signed-off-by: Lars Persson > --- > Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt > index 8babdaa..9dd9478 100644 > --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt > +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt > @@ -12,6 +12,10 @@ Optional properties: > > - vmmc-supply: a phandle of a regulator, supplying Vcc to the card > - vqmmc-supply: a phandle of a regulator, supplying VccQ to the card > +- pinctrl-names: Must contain a "default" entry and optionally a "pins_uhs" "state_uhs" is becoming more and more widely deployed, I suggest you use that as well. Moreover, I am reviewing patch 3/3 and I think some more clarification is needed here, on whether what is required and optional. See those comment on patch 3/3. > + entry for the UHS pin configuration. > +- pinctrl-N: One property for each name listed in pinctrl-names, see > + ../pinctrl/pinctrl-bindings.txt. > > Additionally any standard mmc bindings from mmc.txt can be used. > > -- > 2.1.4 > Kind regards Uffe