From: Ulf Hansson <ulf.hansson@linaro.org>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>,
linux-kernel@vger.kernel.org, Marek Vasut <marex@denx.de>,
kernel@dh-electronics.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: Make comment on wakeup-source less confusing
Date: Tue, 29 Nov 2022 13:06:38 +0100 [thread overview]
Message-ID: <CAPDyKFqc2kc4O55BAVikZFeZpAeRYo3AAfnHyxKPcsUujeGauA@mail.gmail.com> (raw)
In-Reply-To: <20221122111124.6828-3-cniedermaier@dh-electronics.com>
On Tue, 22 Nov 2022 at 12:43, Christoph Niedermaier
<cniedermaier@dh-electronics.com> wrote:
>
> The current comment on wakeup-source is a bit confusing, because it isn't
> clear at first sight which property is actually deprecated.
> Change the comment to one that is less confusing.
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Marek Vasut <marex@denx.de>
> Cc: kernel@dh-electronics.com
> Cc: linux-mmc@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> To: linux-kernel@vger.kernel.org
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 802e3ca8be4d..a921442c6c1d 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -293,7 +293,7 @@ properties:
> description:
> SDIO only. Preserves card power during a suspend/resume cycle.
>
> - # Deprecated: enable-sdio-wakeup
> + # Use wakeup-source instead of the deprecated enable-sdio-wakeup
> wakeup-source:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
Rob, Krzysztof - do we have a preferred pattern for how to express
deprecated bindings - or is the above okay to you?
Kind regards
Uffe
next prev parent reply other threads:[~2022-11-29 12:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 11:11 [PATCH] dt-bindings: leds: Mark label property as deprecated Christoph Niedermaier
2022-11-22 11:11 ` [PATCH] dt-bindings: mfd: da9062: Correct file name for watchdog Christoph Niedermaier
2022-11-29 12:33 ` Krzysztof Kozlowski
2022-11-30 10:10 ` Lee Jones
2022-11-30 10:13 ` kernel
2022-11-30 10:19 ` Krzysztof Kozlowski
2022-11-30 10:20 ` Lee Jones
2022-11-30 10:18 ` Christoph Niedermaier
2022-11-22 11:11 ` [PATCH] dt-bindings: mmc: Make comment on wakeup-source less confusing Christoph Niedermaier
2022-11-29 12:06 ` Ulf Hansson [this message]
2022-11-29 12:33 ` Krzysztof Kozlowski
2022-11-29 12:35 ` Krzysztof Kozlowski
2022-11-29 15:30 ` Ulf Hansson
2022-11-29 15:37 ` Marek Vasut
2022-11-29 15:59 ` Krzysztof Kozlowski
2022-11-22 12:23 ` [PATCH] dt-bindings: leds: Mark label property as deprecated Pavel Machek
2022-11-25 21:26 ` Marek Vasut
2022-11-29 9:03 ` Christoph Niedermaier
2022-11-30 19:19 ` Rob Herring
2022-11-30 19:26 ` Pavel Machek
2022-12-01 21:47 ` Rob Herring
2022-12-02 9:25 ` Pavel Machek
2022-12-01 23:44 ` Marek Vasut
2022-12-01 23:41 ` Marek Vasut
2022-12-05 18:44 ` Jacek Anaszewski
2022-12-22 9:36 ` Christoph Niedermaier
2022-12-22 13:50 ` Pavel Machek
2022-12-22 14:01 ` Marek Vasut
2022-12-22 14:56 ` Pavel Machek
2022-12-22 15:21 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqc2kc4O55BAVikZFeZpAeRYo3AAfnHyxKPcsUujeGauA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=cniedermaier@dh-electronics.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@dh-electronics.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).