* [PATCH 2/3] dt-bindings: mmc: sdhci-msm: add IPQ6018 compatible
2023-04-24 12:13 [PATCH 1/3] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks Mantas Pucka
@ 2023-04-24 12:13 ` Mantas Pucka
2023-04-25 18:54 ` Rob Herring
2023-05-09 10:09 ` Ulf Hansson
2023-04-24 12:13 ` [PATCH 3/3] arm64: dts: qcom: ipq6018: add SDHCI node Mantas Pucka
2023-04-25 1:30 ` [PATCH 1/3] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks Stephen Boyd
2 siblings, 2 replies; 7+ messages in thread
From: Mantas Pucka @ 2023-04-24 12:13 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Bhupesh Sharma
Cc: Abhishek Sahu, Anusha Canchi Ramachandra Rao, Sricharan R,
Sivaprakash Murugesan, linux-mmc, devicetree, linux-kernel,
linux-arm-msm, linux-clk, Mantas Pucka
IPQ6018 has a sdhci-msm compatible MMC controller. Add the appropriate
compatible to the documentation.
Signed-off-by: Mantas Pucka <mantas@8devices.com>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 4f2d9e8127dd..5ad846b724f3 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -36,6 +36,7 @@ properties:
- enum:
- qcom,ipq5018-sdhci
- qcom,ipq5332-sdhci
+ - qcom,ipq6018-sdhci
- qcom,ipq9574-sdhci
- qcom,qcm2290-sdhci
- qcom,qcs404-sdhci
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] dt-bindings: mmc: sdhci-msm: add IPQ6018 compatible
2023-04-24 12:13 ` [PATCH 2/3] dt-bindings: mmc: sdhci-msm: add IPQ6018 compatible Mantas Pucka
@ 2023-04-25 18:54 ` Rob Herring
2023-05-09 10:09 ` Ulf Hansson
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-04-25 18:54 UTC (permalink / raw)
To: Mantas Pucka
Cc: Sivaprakash Murugesan, Stephen Boyd, devicetree, Ulf Hansson,
Andy Gross, Sricharan R, Konrad Dybcio, Abhishek Sahu, linux-mmc,
Rob Herring, Bhupesh Sharma, Anusha Canchi Ramachandra Rao,
Michael Turquette, linux-kernel, linux-arm-msm, Bjorn Andersson,
Krzysztof Kozlowski, linux-clk
On Mon, 24 Apr 2023 15:13:31 +0300, Mantas Pucka wrote:
> IPQ6018 has a sdhci-msm compatible MMC controller. Add the appropriate
> compatible to the documentation.
>
> Signed-off-by: Mantas Pucka <mantas@8devices.com>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] dt-bindings: mmc: sdhci-msm: add IPQ6018 compatible
2023-04-24 12:13 ` [PATCH 2/3] dt-bindings: mmc: sdhci-msm: add IPQ6018 compatible Mantas Pucka
2023-04-25 18:54 ` Rob Herring
@ 2023-05-09 10:09 ` Ulf Hansson
1 sibling, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2023-05-09 10:09 UTC (permalink / raw)
To: Mantas Pucka
Cc: Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Michael Turquette, Stephen Boyd, Bhupesh Sharma,
Abhishek Sahu, Anusha Canchi Ramachandra Rao, Sricharan R,
Sivaprakash Murugesan, linux-mmc, devicetree, linux-kernel,
linux-arm-msm, linux-clk
On Mon, 24 Apr 2023 at 14:14, Mantas Pucka <mantas@8devices.com> wrote:
>
> IPQ6018 has a sdhci-msm compatible MMC controller. Add the appropriate
> compatible to the documentation.
>
> Signed-off-by: Mantas Pucka <mantas@8devices.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 4f2d9e8127dd..5ad846b724f3 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -36,6 +36,7 @@ properties:
> - enum:
> - qcom,ipq5018-sdhci
> - qcom,ipq5332-sdhci
> + - qcom,ipq6018-sdhci
> - qcom,ipq9574-sdhci
> - qcom,qcm2290-sdhci
> - qcom,qcs404-sdhci
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: ipq6018: add SDHCI node
2023-04-24 12:13 [PATCH 1/3] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks Mantas Pucka
2023-04-24 12:13 ` [PATCH 2/3] dt-bindings: mmc: sdhci-msm: add IPQ6018 compatible Mantas Pucka
@ 2023-04-24 12:13 ` Mantas Pucka
2023-10-31 19:46 ` Robert Marko
2023-04-25 1:30 ` [PATCH 1/3] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks Stephen Boyd
2 siblings, 1 reply; 7+ messages in thread
From: Mantas Pucka @ 2023-04-24 12:13 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Bhupesh Sharma
Cc: Abhishek Sahu, Anusha Canchi Ramachandra Rao, Sricharan R,
Sivaprakash Murugesan, linux-mmc, devicetree, linux-kernel,
linux-arm-msm, linux-clk, Mantas Pucka
IPQ6018 has one SD/eMMC controller, add node for it.
Signed-off-by: Mantas Pucka <mantas@8devices.com>
---
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 9ff4e9d45065..b129b23d68b1 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -414,6 +414,29 @@
};
};
+ sdhc_1: mmc@7804000 {
+ compatible = "qcom,ipq6018-sdhci", "qcom,sdhci-msm-v5";
+ reg = <0x0 0x07804000 0x0 0x1000>,
+ <0x0 0x07805000 0x0 0x1000>,
+ <0x0 0x07808000 0x0 0x2000>;
+ reg-names = "hc", "cqhci", "ice";
+
+ interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "hc_irq", "pwr_irq";
+
+ clocks = <&gcc GCC_SDCC1_AHB_CLK>,
+ <&gcc GCC_SDCC1_APPS_CLK>,
+ <&xo>,
+ <&gcc GCC_SDCC1_ICE_CORE_CLK>;
+ clock-names = "iface", "core", "xo", "ice";
+
+ resets = <&gcc GCC_SDCC1_BCR>;
+ supports-cqe;
+ bus-width = <8>;
+ status = "disabled";
+ };
+
blsp_dma: dma-controller@7884000 {
compatible = "qcom,bam-v1.7.0";
reg = <0x0 0x07884000 0x0 0x2b000>;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] arm64: dts: qcom: ipq6018: add SDHCI node
2023-04-24 12:13 ` [PATCH 3/3] arm64: dts: qcom: ipq6018: add SDHCI node Mantas Pucka
@ 2023-10-31 19:46 ` Robert Marko
0 siblings, 0 replies; 7+ messages in thread
From: Robert Marko @ 2023-10-31 19:46 UTC (permalink / raw)
To: Mantas Pucka, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Bhupesh Sharma
Cc: Abhishek Sahu, Anusha Canchi Ramachandra Rao, Sricharan R,
Sivaprakash Murugesan, linux-mmc, devicetree, linux-kernel,
linux-arm-msm, linux-clk
On 24. 04. 2023. 14:13, Mantas Pucka wrote:
> IPQ6018 has one SD/eMMC controller, add node for it.
>
> Signed-off-by: Mantas Pucka <mantas@8devices.com>
Tested-by: Robert Marko <robimarko@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 9ff4e9d45065..b129b23d68b1 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -414,6 +414,29 @@
> };
> };
>
> + sdhc_1: mmc@7804000 {
> + compatible = "qcom,ipq6018-sdhci", "qcom,sdhci-msm-v5";
> + reg = <0x0 0x07804000 0x0 0x1000>,
> + <0x0 0x07805000 0x0 0x1000>,
> + <0x0 0x07808000 0x0 0x2000>;
> + reg-names = "hc", "cqhci", "ice";
> +
> + interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "hc_irq", "pwr_irq";
> +
> + clocks = <&gcc GCC_SDCC1_AHB_CLK>,
> + <&gcc GCC_SDCC1_APPS_CLK>,
> + <&xo>,
> + <&gcc GCC_SDCC1_ICE_CORE_CLK>;
> + clock-names = "iface", "core", "xo", "ice";
> +
> + resets = <&gcc GCC_SDCC1_BCR>;
> + supports-cqe;
> + bus-width = <8>;
> + status = "disabled";
> + };
> +
> blsp_dma: dma-controller@7884000 {
> compatible = "qcom,bam-v1.7.0";
> reg = <0x0 0x07884000 0x0 0x2b000>;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks
2023-04-24 12:13 [PATCH 1/3] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks Mantas Pucka
2023-04-24 12:13 ` [PATCH 2/3] dt-bindings: mmc: sdhci-msm: add IPQ6018 compatible Mantas Pucka
2023-04-24 12:13 ` [PATCH 3/3] arm64: dts: qcom: ipq6018: add SDHCI node Mantas Pucka
@ 2023-04-25 1:30 ` Stephen Boyd
2 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2023-04-25 1:30 UTC (permalink / raw)
To: Andy Gross, Bhupesh Sharma, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski, Mantas Pucka, Michael Turquette, Rob Herring,
Ulf Hansson
Cc: Abhishek Sahu, Anusha Canchi Ramachandra Rao, Sricharan R,
Sivaprakash Murugesan, linux-mmc, devicetree, linux-kernel,
linux-arm-msm, linux-clk, Mantas Pucka
Quoting Mantas Pucka (2023-04-24 05:13:30)
> SDCC clocks must be rounded down to avoid overclocking the controller.
>
> Fixes: d9db07f088af ("clk: qcom: Add ipq6018 Global Clock Controller support")
>
There should be no extra newline here.
> Signed-off-by: Mantas Pucka <mantas@8devices.com>
^ permalink raw reply [flat|nested] 7+ messages in thread