From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BD0C636CC for ; Thu, 16 Feb 2023 11:13:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbjBPLNf (ORCPT ); Thu, 16 Feb 2023 06:13:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbjBPLNe (ORCPT ); Thu, 16 Feb 2023 06:13:34 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84C6E2DE6E for ; Thu, 16 Feb 2023 03:13:33 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id b1so1235581pft.1 for ; Thu, 16 Feb 2023 03:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+kR6wh9kwB/E7vRE8CyQpd6LBLK+EqxdavmtcVlfOZ4=; b=Sg+fQUNTyvr2FucvVuiPGyKptOmkutRklwZcQ74bdCjoB9dKmwUe+O3dHg1bLL+WbM GLPXT2Oc1YhiCN9bgWt87QXsZKMzqs17B5ZeOxieV8XDjAghFZ7kj89SMUk1tGTSVVLS cqgsFggPkidPlijzDql9Bvzljqp6ILWyqSrcH7KmXSaCAmQDqlxaRTsoper6rS+554Pm arcq3zT/m5Ag2IUxtufCw0B0kqN3hjcsXJAj1gOIBUtGTJX3XMPyAQi6BrsajIHRS89c GKGLBn4dER1Z42cJLAcUF48Jwzb1eHHaomFk7FJ0WFQ1tCdUt0QVD7tmxYdn0NaWChIl N0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+kR6wh9kwB/E7vRE8CyQpd6LBLK+EqxdavmtcVlfOZ4=; b=JBs+MtgAwZJuD6OlGTQLcnJ/kzy+Pb3fJCTCsxs2sRp8qC32YelRzpIVufYHN7DcHS I8Se+oPlRk8MPIeS9VosKFPVxpzTSC9h8hqhUuBGF/UoN7h1GEiAWpPCvHZFjg/K6GJz S6GWuzGGsHxPZLTcV+2/EpeZMuMWrTww+J3P7S/OuJT1feFN40zB1KPmxBq+EOEs9vul Rcbk9L7bzb0uihUoiA+JYSrCfZdVNQYlVaV/eEDlzBTwoFcruOat0U6ch3jTOQAT1/yx CG43PtmSaY6Dt96rx3+qVY4tDgkbgkgKr1hD8ORJsScZHf9fDvfPcXxMJRc9JFurN3rE RUhQ== X-Gm-Message-State: AO0yUKV3kWVNDBfAgEoIOqMbivqaSSYZxZQfLV+FpfLNi4nVYB7PoZOC LLqXTXRn+Wb3HnRJ0lrFhs9dPMPjsdpVJGtN53mgcw== X-Google-Smtp-Source: AK7set8RryQsbu+Kkw2qXt9myeqZ9YL9Pbk5ABXe5VqKD9hgnrBVz34nN6cjKsGVChY53slLb8UDby66Y68qOCd2T+k= X-Received: by 2002:a62:820f:0:b0:5a9:b28f:626c with SMTP id w15-20020a62820f000000b005a9b28f626cmr71691pfd.56.1676546012974; Thu, 16 Feb 2023 03:13:32 -0800 (PST) MIME-Version: 1.0 References: <15df9ef0-9b73-ca5a-d3cf-0585cd135bc5@gmail.com> <1c5996a5-491f-39d6-b120-bbef86473729@gmail.com> <723119a3-7c7f-6447-254e-bc340a1fe2de@gmail.com> <8e9d4c8a-40e0-65ef-ba72-ee8d1114ce97@linaro.org> In-Reply-To: From: Ulf Hansson Date: Thu, 16 Feb 2023 12:12:56 +0100 Message-ID: Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: meson-gx: support specifying cd interrupt To: Heiner Kallweit Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." , "devicetree@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 16 Feb 2023 at 10:49, Heiner Kallweit wrote: > > On 16.02.2023 10:41, Heiner Kallweit wrote: > > On 16.02.2023 10:34, Krzysztof Kozlowski wrote: > >> On 16/02/2023 10:29, Heiner Kallweit wrote: > >>> On 16.02.2023 10:18, Krzysztof Kozlowski wrote: > >>>> On 14/02/2023 22:42, Heiner Kallweit wrote: > >>>>> Support passing a second interrupt as card detect interrupt. > >>>>> > >>>>> Signed-off-by: Heiner Kallweit > >>>>> --- > >>>>> Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +- > >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml > >>>>> index 46e235bf2..c8c30300d 100644 > >>>>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml > >>>>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml > >>>>> @@ -28,7 +28,7 @@ properties: > >>>>> maxItems: 1 > >>>>> > >>>>> interrupts: > >>>>> - maxItems: 1 > >>>>> + maxItems: 2 > >>>> > >>>> Wait, you now *require* (not support) cd interrupt, so this looks like > >>>> ABI break. > >>>> > >>> The second interrupt is optional. If not provided MMC core falls back to > >>> cd polling. > >> > >> It is not. Your binding requires it. Did you test it on DTS without the > >> second interrupt? > >> > > You're right, the binding misses a minItems 1. I'll add that and the > > interrupt description. > > > Ulf, > do you require an add-on patch that fixes the binding issue or a > replacement patch? Please send an incremental patch on top, I would like to avoid any further rebase at this late in the release cycle. Kind regards Uffe