From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Christoph Müllner" <christoph.muellner@theobroma-systems.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
Shawn Lin <shawn.lin@rock-chips.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Michal Simek <michal.simek@xilinx.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
Tony Xie <tony.xie@rock-chips.com>, Randy Li <ayaka@soulik.info>,
Vicente Bergas <vicencb@gmail.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux
Subject: Re: [PATCH v3 2/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs.
Date: Mon, 25 Mar 2019 14:54:16 +0100 [thread overview]
Message-ID: <CAPDyKFrPBY14bvG7ZLON2xTTWEc2a1JjLdeDSkGmtdAZy5hokQ@mail.gmail.com> (raw)
In-Reply-To: <2D2515D6-1E11-4EA3-B016-EC37A9E3091D@theobroma-systems.com>
On Mon, 25 Mar 2019 at 14:39, Christoph Müllner
<christoph.muellner@theobroma-systems.com> wrote:
>
>
> > On 25.03.2019, at 14:27, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > On Fri, 22 Mar 2019 at 12:39, Christoph Muellner
> > <christoph.muellner@theobroma-systems.com> wrote:
> >>
> >> Direct commands (DCMDs) are an optional feature of eMMC 5.1's command
> >> queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI,
> >> which exposes a control register bit to enable the feature.
> >> The current implementation sets this bit unconditionally.
> >>
> >> This patch allows to suppress the feature activation,
> >> by specifying the property disable-cqe-dcmd.
> >>
> >> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
> >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> >
> > Applied for next, thanks!
> >
> > Perhaps both patch1 and patch2 should be tagged for stable? Then
> > please tell me and I can add a tag.
>
> Hi Ulf,
>
> yes tagging for stable would be nice.
> I guess, the following would fit:
>
> Fixes: 84362d79f436 ("mmc: sdhci-of-arasan: Add CQHCI support for arasan,sdhci-5.1")
>
Great, I have added that to both of the commits and a stable tag. Thanks!
[...]
Kind regards
Uffe
next prev parent reply other threads:[~2019-03-25 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 11:38 [PATCH v3 1/3] dt-bindings: mmc: Add disable-cqe-dcmd property Christoph Muellner
2019-03-22 11:38 ` [PATCH v3 2/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs Christoph Muellner
2019-03-25 13:27 ` Ulf Hansson
2019-03-25 13:39 ` Christoph Müllner
2019-03-25 13:54 ` Ulf Hansson [this message]
[not found] ` <20190322113808.16858-1-christoph.muellner-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
2019-03-22 11:38 ` [PATCH v3 3/3] arm64: dts: rockchip: Disable DCMDs on RK3399's eMMC controller Christoph Muellner
2019-03-25 13:27 ` Ulf Hansson
2019-03-27 12:21 ` Heiko Stuebner
2019-03-25 13:27 ` [PATCH v3 1/3] dt-bindings: mmc: Add disable-cqe-dcmd property Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrPBY14bvG7ZLON2xTTWEc2a1JjLdeDSkGmtdAZy5hokQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=ayaka@soulik.info \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tony.xie@rock-chips.com \
--cc=vicencb@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).