From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 2/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs. Date: Mon, 25 Mar 2019 14:54:16 +0100 Message-ID: References: <20190322113808.16858-1-christoph.muellner@theobroma-systems.com> <20190322113808.16858-2-christoph.muellner@theobroma-systems.com> <2D2515D6-1E11-4EA3-B016-EC37A9E3091D@theobroma-systems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <2D2515D6-1E11-4EA3-B016-EC37A9E3091D@theobroma-systems.com> Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?Q?Christoph_M=C3=BCllner?= Cc: Rob Herring , Mark Rutland , Heiko Stuebner , Shawn Lin , Adrian Hunter , Philipp Tomsich , Michal Simek , Viresh Kumar , Enric Balletbo i Serra , Matthias Brugger , Douglas Anderson , Tony Xie , Randy Li , Vicente Bergas , Ezequiel Garcia , Klaus Goger , "linux-mmc@vger.kernel.org" , DTML , Linux List-Id: devicetree@vger.kernel.org On Mon, 25 Mar 2019 at 14:39, Christoph M=C3=BCllner wrote: > > > > On 25.03.2019, at 14:27, Ulf Hansson wrote: > > > > On Fri, 22 Mar 2019 at 12:39, Christoph Muellner > > wrote: > >> > >> Direct commands (DCMDs) are an optional feature of eMMC 5.1's command > >> queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI, > >> which exposes a control register bit to enable the feature. > >> The current implementation sets this bit unconditionally. > >> > >> This patch allows to suppress the feature activation, > >> by specifying the property disable-cqe-dcmd. > >> > >> Signed-off-by: Christoph Muellner > >> Signed-off-by: Philipp Tomsich > >> Acked-by: Adrian Hunter > > > > Applied for next, thanks! > > > > Perhaps both patch1 and patch2 should be tagged for stable? Then > > please tell me and I can add a tag. > > Hi Ulf, > > yes tagging for stable would be nice. > I guess, the following would fit: > > Fixes: 84362d79f436 ("mmc: sdhci-of-arasan: Add CQHCI support for arasan,= sdhci-5.1") > Great, I have added that to both of the commits and a stable tag. Thanks! [...] Kind regards Uffe