From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF124C83F14 for ; Tue, 29 Aug 2023 11:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233588AbjH2LDC (ORCPT ); Tue, 29 Aug 2023 07:03:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235569AbjH2LC4 (ORCPT ); Tue, 29 Aug 2023 07:02:56 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97E4FE61 for ; Tue, 29 Aug 2023 04:02:23 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-5925e580f12so49144757b3.3 for ; Tue, 29 Aug 2023 04:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693306942; x=1693911742; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=htUA3Pqo/wgLtU7I+zMlvC08LizycSF6y3MTiiAzjIA=; b=SHVKGTKArE3D4BM2ZsqPPWSUAEyaHwP4S2Gx4s42htL72dNFX86nOXeclRNBARGLdQ ft3NgLRsUXf27FqtWnL0TvxRlODwbu+HLiJsZ/aCxhDDt+ETnIBHk424sRlEQwuT0tmS fL9XC9/7f48QWc4ogDzsHzWuwesB9hxxSutBhCvEWgVPinqCOc3G6lJEa6CeqqoMOCK2 eYclgA6jixDwTt++4hayHS6NqX4XO4nF4njBsFSl/mk/wS53yT1nK0NTwLC0D8QE0REf 5fqnhXxUWkB2UgPIbyUF2qEOuaWUlOq0ZWV5aXnSzWitbTLqkW5YitIN92Uzv4CpAPcN 67eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693306942; x=1693911742; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=htUA3Pqo/wgLtU7I+zMlvC08LizycSF6y3MTiiAzjIA=; b=FEuAwFyG7iRC+pyOIP7dhV8UewFftO9CJjhUoRfSKreCRu1ew4jUwGLyPxCBvhW+zq rxByDB3geYqgEm+MW+XqnMfhZ0F7Ovr/wnb/8ZpHDnzq0/lHE9G1qJTjiI73VN5ELvY+ lket/Q7hBa8Vh2e5HufLeCT2oRKm8+kmdlreUZfXI2UkmrqpZaJUAoxWAEkEzNSWiFFF CqmDqET4XKygugwTa30ZjXO4KqM4/wMUf6wmmzUgoacomXWsM0ya0v7QD71f37Tvm7e7 xGl37Smqk4//iWWBYrK6p1Cqq7UsAhPkawyT8jx5yeI/r/pMFV/bbc+l01uwYb0wyBmg 78eQ== X-Gm-Message-State: AOJu0YyVjQ1/GksaWoSEnkomKW3q0FneWb/BCcayfQhmLhPuupxwuj8O QE36vWBPsm+njz52Rbu9pWPkXK70vfHo2n9AdI+Bew== X-Google-Smtp-Source: AGHT+IHp3Ajd7M1WNI45jKTX2bxQ7+cfWJifOSd/dyJsestJojnJeanITjApP5TIGB6ATtG2mqNPkVJtIObLu75p+i0= X-Received: by 2002:a25:1ec4:0:b0:d0c:3be2:b626 with SMTP id e187-20020a251ec4000000b00d0c3be2b626mr24690245ybe.30.1693306942195; Tue, 29 Aug 2023 04:02:22 -0700 (PDT) MIME-Version: 1.0 References: <20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org> <20230217-topic-cpr3h-v14-3-9fd23241493d@linaro.org> In-Reply-To: <20230217-topic-cpr3h-v14-3-9fd23241493d@linaro.org> From: Ulf Hansson Date: Tue, 29 Aug 2023 13:01:44 +0200 Message-ID: Subject: Re: [PATCH v14 3/9] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3 driver To: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski Cc: AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Viresh Kumar , Nishanth Menon , Stephen Boyd , Niklas Cassel , Liam Girdwood , Mark Brown , Conor Dooley , "Rafael J. Wysocki" , Viresh Kumar , Robert Marko , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Jeffrey Hugo , Marijn Suijten , AngeloGioacchino Del Regno Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 28 Aug 2023 at 13:42, Konrad Dybcio wrote: > > From: AngeloGioacchino Del Regno > > Add the bindings for the CPR3 driver to the documentation. > > Signed-off-by: AngeloGioacchino Del Regno > [Konrad: Make binding check pass; update AGdR's email] > Tested-by: Jeffrey Hugo > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/soc/qcom/qcom,cpr3.yaml | 286 +++++++++++++++++++++ > 1 file changed, 286 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > new file mode 100644 > index 000000000000..acf2e294866b [...] > + > +examples: > + - | > + #include > + #include > + > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + cpu@0 { > + compatible = "qcom,kryo280"; > + device_type = "cpu"; > + reg = <0x0 0x0>; > + operating-points-v2 = <&cpu0_opp_table>; > + power-domains = <&apc_cprh 0>; > + power-domain-names = "cprh"; Rather than using a Qcom specific power-domain-name, perhaps a common power-domain-name for cpus, that can be used for "the performance domain" would be a good idea here? I have suggested using "perf" for the SCMI performance domain [1], perhaps that description should be extended to cover this and other performance domains too? > + }; > + > + cpu@100 { > + compatible = "qcom,kryo280"; > + device_type = "cpu"; > + reg = <0x0 0x100>; > + operating-points-v2 = <&cpu4_opp_table>; > + power-domains = <&apc_cprh 1>; > + power-domain-names = "cprh"; > + }; > + }; [...] Kind regards Uffe [1] https://lore.kernel.org/linux-arm-kernel/20230825112633.236607-9-ulf.hansson@linaro.org/