From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v5 1/3] power-domain: add power domain drivers for Rockchip platform Date: Wed, 22 Oct 2014 10:29:51 +0200 Message-ID: References: <1413882808-4669-1-git-send-email-jinkun.hong@rock-chips.com> <1413882808-4669-2-git-send-email-jinkun.hong@rock-chips.com> <20141021195854.GE8609@dtor-ws> <544725C4.4040703@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Hong jinkun , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , Russell King , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Randy Dunlap , "linux-doc@vger.kernel.org" , Doug Anderson , Heiko Stuebner , linux-rockchip@lists.infradead.org, Jack Dai , Geert Uytterhoeven , Dmitry Torokhov List-Id: devicetree@vger.kernel.org On 22 October 2014 10:07, Geert Uytterhoeven wrote: > On Wed, Oct 22, 2014 at 9:58 AM, Ulf Hansson wrote: >> Now, I just realized that while Geert added attach|detach_dev() >> callbacks for the generic PM domain, those are both "void" callbacks. >> It means the deferred probe error handling is broken for these >> callbacks. We should convert the attach_dev() callback into an int, I >> will cook a patch immediately. > > That was changed in v3: > - Move calling of the callbacks to a point where dev->pm_domain is > valid, so the domain parameter is no longer needed, That's good. > - Make callbacks return void. > But not this. :-) Sorry, for being too quick in reviewing that time. Kind regards Uffe