From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E658CC04AA5 for ; Thu, 25 Aug 2022 09:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235494AbiHYJy0 (ORCPT ); Thu, 25 Aug 2022 05:54:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234505AbiHYJyG (ORCPT ); Thu, 25 Aug 2022 05:54:06 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86F52AC270 for ; Thu, 25 Aug 2022 02:52:18 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id d8so15114622lfq.0 for ; Thu, 25 Aug 2022 02:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=/Xjm3zsGuKOlz7T50ivA2r0C2gPq3B5LrNzOmebJTKc=; b=VoKHBwr6XgeoBUP6orl2mDo0itQeZmtAVL7Ce3/QulBkW6wNNWoRjUMaGIGARvBgMZ jjdcSQybfLV+KDtA6/6UtdmwCJmeFJMREsXmTnpdBvukHBkITbl6+mCagHzFCDdmzCzy FhSFnmp9W+2uIi55Y/kJaxDeuIj79/AjCZ479t6WvmpB84Ypj7do2hR6yeLDGsX8SElG bx4GIw1T+rAktwui5kZpomK9zs7qvfa5uOmkXfnd78w7ayASPRfRTOpSTL+vgz8dMKVD r02UbVYozeSkKtfGDUgQmG+nwDMNHcUjRbgENUf95iD1HK41kmiYNS7GhImPde9CYNjI RMzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=/Xjm3zsGuKOlz7T50ivA2r0C2gPq3B5LrNzOmebJTKc=; b=rDASgh3jHly0qBNz7sAl6Qml0Q+EUqw09Svw3aesPK4dKPMiDF25MPY2qDzG6EMFnm nJg+3avHlUF/6wRDgFpsYtwMZTMuoddpbQ9+XWYkG32pP2Om6UbU3czQ6jkR0ZyLExD9 hQL4nq6I7ilpsVLu50PaONJAzqEv5AnjTzoQelLYakbthGtXZsYqCSQn/spRQQ4YEPE7 ZAUjta/Gqitp9i2vVKibvlV3ToDNbncfJGt8RQVnDznZlfl4hFh2zeBD+IN7rtfrNYex mcztUD1NQeLoFoa2t0H28fwUn4PHAqJBNgtWJtj9SktmFJX7MN5+KixDOOoKW+IMd8MB GBfw== X-Gm-Message-State: ACgBeo2AOJSr1ZmV0jUlr9JmOrHS8HAXQkqfhFYF2SUKk6jZC8SZ4+sj 45WxiL29cOANek7Trl6u+FkbET3YM9z7QfDu5vKMkQ== X-Google-Smtp-Source: AA6agR6DhLp3M8c7w7bIMGuhp2NG6eDLu/F6OQp/nGH+cyEvLm4tf0Rmr/KNhBxMXmjxcratFTKQEiipPgKwSCTojGU= X-Received: by 2002:a05:6512:6ca:b0:492:ef21:c085 with SMTP id u10-20020a05651206ca00b00492ef21c085mr938731lff.71.1661421104640; Thu, 25 Aug 2022 02:51:44 -0700 (PDT) MIME-Version: 1.0 References: <20220823145649.3118479-15-robh@kernel.org> In-Reply-To: <20220823145649.3118479-15-robh@kernel.org> From: Ulf Hansson Date: Thu, 25 Aug 2022 11:51:08 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: power: Add missing (unevaluated|additional)Properties on child nodes To: Rob Herring Cc: Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Andrey Smirnov , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 23 Aug 2022 at 16:57, Rob Herring wrote: > > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring Acked-by: Ulf Hansson Kind regards Uffe > --- > .../bindings/power/domain-idle-state.yaml | 10 ++++++++++ > .../devicetree/bindings/power/fsl,imx-gpc.yaml | 14 ++++++++++++++ > .../devicetree/bindings/power/fsl,imx-gpcv2.yaml | 14 ++++++++++++++ > 3 files changed, 38 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/domain-idle-state.yaml b/Documentation/devicetree/bindings/power/domain-idle-state.yaml > index 6a12efdf436a..4ee920a1de69 100644 > --- a/Documentation/devicetree/bindings/power/domain-idle-state.yaml > +++ b/Documentation/devicetree/bindings/power/domain-idle-state.yaml > @@ -20,6 +20,7 @@ properties: > patternProperties: > "^(cpu|cluster|domain)-": > type: object > + additionalProperties: false > description: > Each state node represents a domain idle state description. > > @@ -44,6 +45,15 @@ patternProperties: > state will yield power benefits, after overcoming the overhead while > entering the idle state. > > + arm,psci-suspend-param: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + power_state parameter to pass to the ARM PSCI suspend call. > + > + Device tree nodes that require usage of PSCI CPU_SUSPEND function > + (i.e. idle states node with entry-method property is set to "psci") > + must specify this property. > + > required: > - compatible > - entry-latency-us > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml > index a055b3e819d8..777e1d852ddd 100644 > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml > @@ -43,11 +43,21 @@ properties: > > pgc: > type: object > + additionalProperties: false > description: list of power domains provided by this controller. > > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > patternProperties: > "power-domain@[0-9]$": > type: object > + additionalProperties: false > + > properties: > > '#power-domain-cells': > @@ -78,6 +88,10 @@ properties: > - '#power-domain-cells' > - reg > > + required: > + - '#address-cells' > + - '#size-cells' > + > required: > - compatible > - reg > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > index 747622bdc57b..3b161e01f920 100644 > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > @@ -42,11 +42,21 @@ properties: > > pgc: > type: object > + additionalProperties: false > description: list of power domains provided by this controller. > > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > patternProperties: > "power-domain@[0-9]$": > type: object > + additionalProperties: false > + > properties: > > '#power-domain-cells': > @@ -85,6 +95,10 @@ properties: > - '#power-domain-cells' > - reg > > + required: > + - '#address-cells' > + - '#size-cells' > + > required: > - compatible > - reg > -- > 2.34.1 >