From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 01/12] mmc: mediatek: add support of mt2701/mt2712 Date: Tue, 10 Oct 2017 09:26:03 +0200 Message-ID: References: <1507604480-23246-1-git-send-email-chaotian.jing@mediatek.com> <1507604480-23246-2-git-send-email-chaotian.jing@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1507604480-23246-2-git-send-email-chaotian.jing@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Chaotian Jing Cc: Rob Herring , Mark Rutland , Matthias Brugger , Catalin Marinas , Will Deacon , yong mao , Linus Walleij , Heiner Kallweit , Phong LE , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org, "linux-kernel@vger.kernel.org" , srv_heupstream List-Id: devicetree@vger.kernel.org [...] > + > +static const struct of_device_id msdc_of_ids[] = { > + { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat}, > + { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat}, > + { .compatible = "mediatek,mt2701-mmc", .data = &mt2701_compat}, > + { .compatible = "mediatek,mt2712-mmc", .data = &mt2712_compat}, > + {} > +}; > +MODULE_DEVICE_TABLE(of, msdc_of_ids); As already stated in the other reply. These new compatible changes needs to be discussed and acked before the driver starts using them. In other words, make patch3 to precede this one. [...] Kind regards Uffe