From: Ulf Hansson <ulf.hansson@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>, Sekhar Nori <nsekhar@ti.com>,
linux-omap <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 2/3] mmc: host: omap_hsmmc: use mmc_regulator_get_supply() to get regulators
Date: Thu, 8 Jun 2017 09:12:40 +0200 [thread overview]
Message-ID: <CAPDyKFrsrUYTmpYE9WYgCfvNkvhtfaFDXUrgr8rxtNVUk0BxTQ@mail.gmail.com> (raw)
In-Reply-To: <20170607083612.14224-3-kishon@ti.com>
> host->pbias = devm_regulator_get_optional(host->dev, "pbias");
> @@ -2143,7 +2136,8 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
> if (ret)
> goto err_irq;
>
> - mmc->ocr_avail = mmc_pdata(host)->ocr_mask;
> + if (mmc_pdata(host)->ocr_mask)
> + mmc->ocr_avail = mmc_pdata(host)->ocr_mask;
This should rather be:
if (!mmc->ocr_avail)
mmc->ocr_avail = mmc_pdata(host)->ocr_mask
In other words, fall back to the platform ocr mask.
>
> omap_hsmmc_disable_irq(host);
>
> --
> 2.11.0
>
Kind regards
Uffe
next prev parent reply other threads:[~2017-06-08 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 8:36 [PATCH 0/3] omap_hsmmc: use mmc_regulator_get_supply() to get regulators Kishon Vijay Abraham I
2017-06-07 8:36 ` [PATCH 1/3] mmc: host: omap_hsmmc: Do not initialize MMC regulators to NULL on error Kishon Vijay Abraham I
2017-06-07 8:36 ` [PATCH 2/3] mmc: host: omap_hsmmc: use mmc_regulator_get_supply() to get regulators Kishon Vijay Abraham I
2017-06-08 7:12 ` Ulf Hansson [this message]
2017-06-07 8:36 ` [PATCH 3/3] Documentation: dt-bindings: Document deprecation of "vmmc_aux" and using "vqmmc" Kishon Vijay Abraham I
2017-06-09 13:53 ` Rob Herring
2017-06-08 7:15 ` [PATCH 0/3] omap_hsmmc: use mmc_regulator_get_supply() to get regulators Ulf Hansson
2017-06-09 7:51 ` Kishon Vijay Abraham I
[not found] ` <19f289a5-cc1d-a14a-130a-ae45710d969e-l0cyMroinI0@public.gmane.org>
2017-06-12 7:59 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrsrUYTmpYE9WYgCfvNkvhtfaFDXUrgr8rxtNVUk0BxTQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).